Skip to content

Commit 497586a

Browse files
authored
config: proper pipeline configuration to allow main builds as well as PR triggers (#2769)
* add a comment about the pipeline * fix config to support builds on PRs
1 parent aea24dc commit 497586a

2 files changed

Lines changed: 9 additions & 0 deletions

File tree

README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,9 @@ yarn start
5353
We use [storybook](https://storybook.js.org) to document API, edge-cases, and the usage of the library.
5454
A hosted version is available at [https://elastic.github.io/elastic-charts/storybook][docs].
5555

56+
## CI
57+
We're using the same [build pipeline](https://buildkite.com/elastic/kibana-elastic-charts-build) for building PRs and the main branch. This pipeline is triggered through webhook events hitting the [buildkite-pr-bot](https://github.com/elastic/buildkite-pr-bot). Configuration for the triggered pipelines can be adjusted in [pull-requests.json](./.buildkite/pull-requests.json).
58+
5659
## Goals
5760

5861
The primary goal of this library is to provide reusable set of chart components that can be used throughout Elastic's web products.

catalog-info.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,12 @@ spec:
2323
repository: elastic/elastic-charts
2424
provider_settings:
2525
trigger_mode: none
26+
build_branches: true
27+
build_pull_requests: true
28+
build_tags: false
29+
prefix_pull_request_fork_branch_names: false
30+
skip_pull_request_builds_for_existing_commits: false
31+
branch_configuration: 'main'
2632
pipeline_file: ".buildkite/pipelines/pull_request/pipeline.sh"
2733
teams:
2834
kibana-visualizations:

0 commit comments

Comments
 (0)