Skip to content

Commit 262a793

Browse files
Re-enable generative tests (#126421)
1 parent c2d0c59 commit 262a793

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

muted-tests.yml

-3
Original file line numberDiff line numberDiff line change
@@ -357,9 +357,6 @@ tests:
357357
- class: org.elasticsearch.search.basic.SearchWithRandomDisconnectsIT
358358
method: testSearchWithRandomDisconnects
359359
issue: https://github.com/elastic/elasticsearch/issues/122707
360-
- class: org.elasticsearch.xpack.esql.qa.single_node.GenerativeIT
361-
method: test
362-
issue: https://github.com/elastic/elasticsearch/issues/126139
363360
- class: org.elasticsearch.snapshots.SharedClusterSnapshotRestoreIT
364361
method: testDeletionOfFailingToRecoverIndexShouldStopRestore
365362
issue: https://github.com/elastic/elasticsearch/issues/126204

x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/generative/GenerativeRestTest.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ public abstract class GenerativeRestTest extends ESRestTestCase {
4141
"Unbounded sort not supported yet",
4242
"The field names are too complex to process", // field_caps problem
4343
"must be \\[any type except counter types\\]", // TODO refine the generation of count()
44+
"mismatched input .* expecting", // identifier generator needs to be refined, this happens when an identifier is a reserved keyword
4445

4546
// warnings
4647
"Field '.*' shadowed by field at line .*",
@@ -52,10 +53,9 @@ public abstract class GenerativeRestTest extends ESRestTestCase {
5253
"only supports KEYWORD or TEXT values, found expression", // https://github.com/elastic/elasticsearch/issues/126017
5354
"token recognition error at: '``", // https://github.com/elastic/elasticsearch/issues/125870
5455
"Unknown column \\[.*\\]", // https://github.com/elastic/elasticsearch/issues/126026
55-
"Expected \\[.*\\] but was \\[.*\\]", // https://github.com/elastic/elasticsearch/issues/126030
56-
"trying to encode an unsupported data type value for TopN", // still https://github.com/elastic/elasticsearch/issues/126030 probably
57-
"Block cannot be cast to", // https://github.com/elastic/elasticsearch/issues/126036
5856
"optimized incorrectly due to missing references", // https://github.com/elastic/elasticsearch/issues/116781
57+
"No matches found for pattern", // https://github.com/elastic/elasticsearch/issues/126418
58+
"JOIN left field .* is incompatible with right field", // https://github.com/elastic/elasticsearch/issues/126419
5959
"The incoming YAML document exceeds the limit:" // still to investigate, but it seems to be specific to the test framework
6060
);
6161

0 commit comments

Comments
 (0)