Skip to content

Commit 6cb2ea3

Browse files
authored
Support for quoted strings and ?params (#137502)
1 parent 8272dcd commit 6cb2ea3

File tree

14 files changed

+1692
-1433
lines changed

14 files changed

+1692
-1433
lines changed

x-pack/plugin/esql/src/main/antlr/PromqlBaseLexer.tokens

Lines changed: 83 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/src/main/antlr/PromqlBaseParser.tokens

Lines changed: 83 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/src/main/antlr/lexer/Promql.g4

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ PROMQL_UNQUOTED_IDENTIFIER
2323
PROMQL_QUOTED_IDENTIFIER: QUOTED_IDENTIFIER -> type(QUOTED_IDENTIFIER);
2424
PROMQL_NAMED_PARAMS: NAMED_OR_POSITIONAL_PARAM -> type(NAMED_OR_POSITIONAL_PARAM);
2525

26+
PROMQL_QUOTED_STRING: QUOTED_STRING -> type(QUOTED_STRING);
2627

2728
// Exit back to default mode on pipe
2829
PROMQL_PARAMS_PIPE : PIPE -> type(PIPE), popMode;

x-pack/plugin/esql/src/main/antlr/parser/Promql.g4

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ promqlParam
1717
promqlParamContent
1818
: PROMQL_UNQUOTED_IDENTIFIER
1919
| QUOTED_IDENTIFIER
20+
| QUOTED_STRING
21+
| NAMED_OR_POSITIONAL_PARAM
2022
;
2123

2224
promqlQueryPart

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/EsqlBaseLexer.interp

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)