Cluster loaded successfully

Author: mridula-s109

x-pack/plugin/search-business-rules/src/main/java/org/elasticsearch/xpack/searchbusinessrules/SearchBusinessRules.java

@@ -9,6 +9,9 @@
 
 import org.elasticsearch.plugins.Plugin;
 import org.elasticsearch.plugins.SearchPlugin;
+import org.elasticsearch.xcontent.ParseField;
+import org.elasticsearch.xpack.searchbusinessrules.PinnedQueryBuilder;
+import org.elasticsearch.xpack.searchbusinessrules.retriever.PinnedRetrieverBuilder;
 
 import java.util.List;
 
@@ -21,4 +24,11 @@ public List<QuerySpec<?>> getQueries() {
         return singletonList(new QuerySpec<>(PinnedQueryBuilder.NAME, PinnedQueryBuilder::new, PinnedQueryBuilder::fromXContent));
     }
 
+    @Override
+    public List<RetrieverSpec<?>> getRetrievers() {
+        return singletonList(new RetrieverSpec<>(
+            new ParseField(PinnedRetrieverBuilder.NAME),
+            PinnedRetrieverBuilder::fromXContent
+        ));
+    }
 }

x-pack/plugin/search-business-rules/src/main/java/org/elasticsearch/xpack/searchbusinessrules/retriever/PinnedRetrieverBuilder.java

@@ -89,10 +89,15 @@ private void validateIdsAndDocs(List<String> ids, List<SpecifiedDocument> docs)
     }
 
     private void validateSort(SearchSourceBuilder source) {
+        // Allow null or empty sort, or sort only containing _score
         List<SortBuilder<?>> sorts = source.sorts();
-        if (sorts != null && sorts.stream().anyMatch(sort -> sort instanceof ScoreSortBuilder == false)) {
-            throw new IllegalArgumentException("Pinned retriever only supports sorting by score. Custom sorting is not allowed.");
+        if (sorts != null && sorts.isEmpty() == false) {
+            // Check if there's any sort other than ScoreSortBuilder
+            if (sorts.stream().anyMatch(sort -> sort instanceof ScoreSortBuilder == false)) {
+                throw new IllegalArgumentException("Pinned retriever only supports sorting by score. Custom sorting is not allowed.");
+            }
         }
+        // If sorts is null, empty, or only contains ScoreSortBuilder, it's valid.
     }
 
     public PinnedRetrieverBuilder(List<String> ids, List<SpecifiedDocument> docs, RetrieverBuilder retrieverBuilder, int rankWindowSize) {

x-pack/plugin/search-business-rules/src/main/resources/META-INF/services/org.elasticsearch.plugins.SearchPlugin

@@ -0,0 +1 @@
+org.elasticsearch.xpack.searchbusinessrules.SearchBusinessRules

x-pack/plugin/search-business-rules/src/yamlRestTest/java/org/elasticsearch/xpack/searchbusinessrules/SearchBusinessRulesClientYamlTestSuiteIT.java

@@ -2,11 +2,21 @@
 
 import com.carrotsearch.randomizedtesting.annotations.ParametersFactory;
 
+import org.elasticsearch.test.cluster.ElasticsearchCluster;
+import org.elasticsearch.test.cluster.local.distribution.DistributionType;
 import org.elasticsearch.test.rest.yaml.ClientYamlTestCandidate;
 import org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase;
+import org.junit.ClassRule;
 
 public class SearchBusinessRulesClientYamlTestSuiteIT extends ESClientYamlSuiteTestCase {
 
+    @ClassRule
+    public static ElasticsearchCluster cluster = ElasticsearchCluster.local()
+        .distribution(DistributionType.DEFAULT)
+        .setting("xpack.license.self_generated.type", "trial")
+        .setting("xpack.security.enabled", "false")
+        .build();
+
     public SearchBusinessRulesClientYamlTestSuiteIT(final ClientYamlTestCandidate testCandidate) {
         super(testCandidate);
     }
@@ -15,4 +25,9 @@ public SearchBusinessRulesClientYamlTestSuiteIT(final ClientYamlTestCandidate te
     public static Iterable<Object[]> parameters() throws Exception {
         return ESClientYamlSuiteTestCase.createParameters();
     }
+
+    @Override
+    protected String getTestRestCluster() {
+        return cluster.getHttpAddresses();
+    }
 } 

x-pack/plugin/search-business-rules/src/yamlRestTest/resources/rest-api-spec/test/search-business-rules/10_pinned_retriever.yml

@@ -400,7 +400,7 @@ setup:
 ---
 "pinned retriever error cases":
   - do:
-      catch: /\[pinned\] duplicate id found in list: doc1/
+      catch: '/\[pinned\] duplicate id found in list: doc1/'
       search:
         index: test-index1
         body:
@@ -413,7 +413,7 @@ setup:
                     match_all: {}
 
   - do:
-      catch: /\[pinned\] Cannot specify both ids and docs parameters/
+      catch: '/\[pinned\] Cannot specify both ids and docs parameters/'
       search:
         index: test-index1
         body: