Skip to content

ESQL: Fix AbstractShapeGeometryFieldMapperTests #119265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 26, 2024
Merged

ESQL: Fix AbstractShapeGeometryFieldMapperTests #119265

merged 3 commits into from
Dec 26, 2024

Conversation

GalLalouche
Copy link
Contributor

Fix a bug in AbstractShapeGeometryFieldMapperTests when the directory reader would contain multiple leaves.

Resolves #119201.

@GalLalouche GalLalouche added >bug :Analytics/Geo Indexing, search aggregations of geo points and shapes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v8.18.0 labels Dec 24, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Hi @GalLalouche, I've created a changelog YAML for you.

@lkts lkts mentioned this pull request Dec 24, 2024
Merged
@GalLalouche GalLalouche force-pushed the fix/abstract_shape_test branch from 18a286c to 5d93f9f Compare December 24, 2024 20:38
@GalLalouche GalLalouche force-pushed the fix/abstract_shape_test branch from 5d93f9f to 5eb9bbe Compare December 25, 2024 09:41
ivancea
ivancea approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@ivancea ivancea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GalLalouche GalLalouche merged commit eed650e into elastic:main Dec 26, 2024
15 of 16 checks passed
@GalLalouche GalLalouche mentioned this pull request Dec 26, 2024
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.x

GalLalouche added a commit to GalLalouche/elasticsearch that referenced this pull request Dec 26, 2024
@GalLalouche
ESQL: Fix AbstractShapeGeometryFieldMapperTests (elastic#119265)
e74b6ae 
Fixed a bug in AbstractShapeGeometryFieldMapperTests when the directory reader would contain multiple leaves.

Resolves elastic#119201.
elasticsearchmachine pushed a commit that referenced this pull request Dec 26, 2024
@GalLalouche
[8.x] ESQL: Fix AbstractShapeGeometryFieldMapperTests (#119265) (#119284
0e0b4fb 
)

* ESQL: Fix AbstractShapeGeometryFieldMapperTests (#119265)

Fixed a bug in AbstractShapeGeometryFieldMapperTests when the directory reader would contain multiple leaves.

Resolves #119201.

* Unmute test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivancea ivancea ivancea approved these changes

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL :Analytics/Geo Indexing, search aggregations of geo points and shapes auto-backport Automatically create backport pull requests when merged >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] AbstractShapeGeometryFieldMapperTests testCartesianBoundsBlockLoader failing
3 participants
@GalLalouche @elasticsearchmachine @ivancea