Skip to content

Fix ThreadPoolMergeExecutorServiceTests testIORateIsAdjustedForRunningMergeTasks #126058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix ThreadPoolMergeExecutorServiceTests testIORateIsAdjustedForRunningMergeTasks #126058

wants to merge 1 commit into from

Conversation

albertzaharovits
Copy link
Contributor

Fixes #125842
Relates #120869

@albertzaharovits albertzaharovits added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. labels Apr 1, 2025
@albertzaharovits albertzaharovits self-assigned this Apr 1, 2025
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Indexing Meta label for Distributed Indexing team label Apr 1, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing)

@albertzaharovits
Copy link
Contributor Author

The only test failure (https://gradle-enterprise.elastic.co/s/f7fv2rsrf2mwy) was when some merge thread was interrupted...

henningandersen
henningandersen reviewed Apr 2, 2025
View reviewed changes
Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICS from the test run, the order of things is opposite. The assertBusy below seems to time-out, which then causes us to interrupt the threads.

I think we've not found the root cause here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henningandersen henningandersen henningandersen left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@albertzaharovits albertzaharovits

Labels
:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. Team:Distributed Indexing Meta label for Distributed Indexing team >test Issues or PRs that are addressing/adding tests v9.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] ThreadPoolMergeExecutorServiceTests testIORateIsAdjustedForRunningMergeTasks failing
3 participants
@albertzaharovits @elasticsearchmachine @henningandersen