From 47130acc9155f51dcb91c8da7b655bc62738c7b9 Mon Sep 17 00:00:00 2001 From: Artem Prigoda Date: Tue, 13 May 2025 21:11:58 +0200 Subject: [PATCH] Fix `IndexStatsIT#testThrottleStats` `Engine.PauseLock#throttle` can be called when the lock is being throttled, so we can't guarantee that all permits are available before throttling. Resolve #126359 See #127173 --- muted-tests.yml | 3 --- .../src/main/java/org/elasticsearch/index/engine/Engine.java | 1 - 2 files changed, 4 deletions(-) diff --git a/muted-tests.yml b/muted-tests.yml index e1612b941fc06..d4d1e4dfbc6ec 100644 --- a/muted-tests.yml +++ b/muted-tests.yml @@ -444,9 +444,6 @@ tests: - class: org.elasticsearch.xpack.esql.qa.mixed.EsqlClientYamlIT method: test {p0=esql/120_profile/avg 8.14 or after} issue: https://github.com/elastic/elasticsearch/issues/127879 -- class: org.elasticsearch.indices.stats.IndexStatsIT - method: testThrottleStats - issue: https://github.com/elastic/elasticsearch/issues/126359 - class: org.elasticsearch.search.vectors.IVFKnnFloatVectorQueryTests method: testRandomWithFilter issue: https://github.com/elastic/elasticsearch/issues/127963 diff --git a/server/src/main/java/org/elasticsearch/index/engine/Engine.java b/server/src/main/java/org/elasticsearch/index/engine/Engine.java index de8bfd0e3e61c..19c4ef852286e 100644 --- a/server/src/main/java/org/elasticsearch/index/engine/Engine.java +++ b/server/src/main/java/org/elasticsearch/index/engine/Engine.java @@ -612,7 +612,6 @@ public Condition newCondition() { } public void throttle() { - assert semaphore.availablePermits() == Integer.MAX_VALUE; semaphore.acquireUninterruptibly(Integer.MAX_VALUE - allowThreads); }