[transform] move loadIfNeeded in index file, remove unloading and afterAll hook on finish (#271265)

## Summary

Doing the same changes over each Transform FTR config to cut CI runtime:

- Add one await `esArchiver.loadIfNeeded('X')` in the index file's
before hook.
- Delete the per-child `loadIfNeeded('X')` calls.
- Delete any `esArchiver.unload('X')` in the index after hook.

Since we stop servers after each FTR config is finished, unloading data
is wasted time.

Some numbers:

- `loadIfNeeded` calls eliminated per CI run: 12 (hoisted once per suite
instead of once per child)
- `esArchiver.unload(...)` calls removed: 12 (2 per index file × 6
suites)
- Total esArchiver ops eliminated per CI run: ~24

Since each FTR config gets its own fresh ES+Kibana instance, none of the
top-level after hooks have any effect on subsequent configs. Saving time
by removing them and related calls across all 6 suites:

- `transform.securityUI.logout()` — browser session is killed with the
server anyway
- `transform.securityCommon.cleanTransformUsers/Roles()` — ES security
objects destroyed with the server
- `transform.testResources.resetKibanaTimeZone()` — Kibana instance
destroyed with the server

Author: dmlemeshko

x-pack/platform/test/functional/apps/transform/actions/deleting.ts

@@ -11,7 +11,6 @@ import type { FtrProviderContext } from '../../../ftr_provider_context';
 import { getLatestTransformConfig, getPivotTransformConfig } from '../helpers';
 
 export default function ({ getService }: FtrProviderContext) {
-  const esArchiver = getService('esArchiver');
   const transform = getService('transform');
 
   describe('deleting', function () {
@@ -64,7 +63,6 @@ export default function ({ getService }: FtrProviderContext) {
     ];
 
     before(async () => {
-      await esArchiver.loadIfNeeded('x-pack/platform/test/fixtures/es_archives/ml/ecommerce');
       await transform.testResources.createDataViewIfNeeded('ft_ecommerce', 'order_date');
 
       for (const testData of testDataList) {

x-pack/platform/test/functional/apps/transform/actions/index.ts

@@ -17,19 +17,7 @@ export default function ({ getService, loadTestFile }: FtrProviderContext) {
     before(async () => {
       await transform.securityCommon.createTransformRoles();
       await transform.securityCommon.createTransformUsers();
-    });
-
-    after(async () => {
-      // NOTE: Logout needs to happen before anything else to avoid flaky behavior
-      await transform.securityUI.logout();
-
-      await transform.securityCommon.cleanTransformUsers();
-      await transform.securityCommon.cleanTransformRoles();
-
-      await esArchiver.unload('x-pack/platform/test/fixtures/es_archives/ml/farequote');
-      await esArchiver.unload('x-pack/platform/test/fixtures/es_archives/ml/ecommerce');
-
-      await transform.testResources.resetKibanaTimeZone();
+      await esArchiver.loadIfNeeded('x-pack/platform/test/fixtures/es_archives/ml/ecommerce');
     });
 
     loadTestFile(require.resolve('./deleting'));

x-pack/platform/test/functional/apps/transform/actions/reauthorizing.ts

@@ -54,7 +54,6 @@ function generateHeaders(apiKey: SecurityCreateApiKeyResponse, version?: string)
 }
 
 export default function ({ getService }: FtrProviderContext) {
-  const esArchiver = getService('esArchiver');
   const transform = getService('transform');
 
   const apiKeysForTransformUsers = new Map<USER, SecurityCreateApiKeyResponse>();
@@ -137,7 +136,6 @@ export default function ({ getService }: FtrProviderContext) {
         apiKeysForTransformUsers.set(user.name as USER, apiKey)
       );
 
-      await esArchiver.loadIfNeeded('x-pack/platform/test/fixtures/es_archives/ml/ecommerce');
       await transform.testResources.createDataViewIfNeeded('ft_ecommerce', 'order_date');
 
       for (const testData of testDataList) {

x-pack/platform/test/functional/apps/transform/actions/resetting.ts

@@ -11,7 +11,6 @@ import type { FtrProviderContext } from '../../../ftr_provider_context';
 import { getLatestTransformConfig, getPivotTransformConfig } from '../helpers';
 
 export default function ({ getService }: FtrProviderContext) {
-  const esArchiver = getService('esArchiver');
   const transform = getService('transform');
 
   describe('resetting', function () {
@@ -66,7 +65,6 @@ export default function ({ getService }: FtrProviderContext) {
     ];
 
     before(async () => {
-      await esArchiver.loadIfNeeded('x-pack/platform/test/fixtures/es_archives/ml/ecommerce');
       await transform.testResources.createDataViewIfNeeded('ft_ecommerce', 'order_date');
 
       for (const testData of testDataList) {

x-pack/platform/test/functional/apps/transform/actions/starting.ts

@@ -45,7 +45,6 @@ interface TestDataLatest {
 type TestData = TestDataPivot | TestDataLatest;
 
 export default function ({ getService }: FtrProviderContext) {
-  const esArchiver = getService('esArchiver');
   const transform = getService('transform');
 
   describe('starting', function () {
@@ -109,7 +108,6 @@ export default function ({ getService }: FtrProviderContext) {
     ];
 
     before(async () => {
-      await esArchiver.loadIfNeeded('x-pack/platform/test/fixtures/es_archives/ml/ecommerce');
       await transform.testResources.createDataViewIfNeeded('ft_ecommerce', 'order_date');
 
       for (const testData of testDataList) {

x-pack/platform/test/functional/apps/transform/creation/index_pattern/creation_index_pattern.ts

@@ -13,13 +13,11 @@ import { isLatestTransformTestData, isPivotTransformTestData } from '../../helpe
 
 export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const canvasElement = getService('canvasElement');
-  const esArchiver = getService('esArchiver');
   const transform = getService('transform');
   const pageObjects = getPageObjects(['discover']);
 
   describe('creation_index_pattern', function () {
     before(async () => {
-      await esArchiver.loadIfNeeded('x-pack/platform/test/fixtures/es_archives/ml/ecommerce');
       await transform.testResources.createDataViewIfNeeded('ft_ecommerce', 'order_date');
       await transform.testResources.setKibanaTimeZoneToUTC();
 

x-pack/platform/test/functional/apps/transform/creation/index_pattern/index.ts

@@ -17,19 +17,7 @@ export default function ({ getService, loadTestFile }: FtrProviderContext) {
     before(async () => {
       await transform.securityCommon.createTransformRoles();
       await transform.securityCommon.createTransformUsers();
-    });
-
-    after(async () => {
-      // NOTE: Logout needs to happen before anything else to avoid flaky behavior
-      await transform.securityUI.logout();
-
-      await transform.securityCommon.cleanTransformUsers();
-      await transform.securityCommon.cleanTransformRoles();
-
-      await esArchiver.unload('x-pack/platform/test/fixtures/es_archives/ml/farequote');
-      await esArchiver.unload('x-pack/platform/test/fixtures/es_archives/ml/ecommerce');
-
-      await transform.testResources.resetKibanaTimeZone();
+      await esArchiver.loadIfNeeded('x-pack/platform/test/fixtures/es_archives/ml/ecommerce');
     });
 
     loadTestFile(require.resolve('./creation_index_pattern'));

x-pack/platform/test/functional/apps/transform/creation/index_pattern/wizard_max_page_search_size_reset.ts

@@ -13,12 +13,10 @@ import {
 import type { FtrProviderContext } from '../../../../ftr_provider_context';
 
 export default function ({ getService }: FtrProviderContext) {
-  const esArchiver = getService('esArchiver');
   const transform = getService('transform');
 
   describe('wizard max_page_search_size reset', function () {
     before(async () => {
-      await esArchiver.loadIfNeeded('x-pack/platform/test/fixtures/es_archives/ml/ecommerce');
       await transform.testResources.createDataViewIfNeeded('ft_ecommerce', 'order_date');
       await transform.testResources.setKibanaTimeZoneToUTC();
       await transform.securityUI.loginAsTransformPowerUser();

x-pack/platform/test/functional/apps/transform/creation/runtime_mappings_saved_search/creation_runtime_mappings.ts

@@ -14,7 +14,6 @@ import type { GroupByEntry, LatestTransformTestData, PivotTransformTestData } fr
 import { isLatestTransformTestData, isPivotTransformTestData } from '../../helpers';
 
 export default function ({ getService }: FtrProviderContext) {
-  const esArchiver = getService('esArchiver');
   const transform = getService('transform');
 
   const runtimeMappings = {
@@ -30,7 +29,6 @@ export default function ({ getService }: FtrProviderContext) {
 
   describe('creation with runtime mappings', function () {
     before(async () => {
-      await esArchiver.loadIfNeeded('x-pack/platform/test/fixtures/es_archives/ml/farequote');
       await transform.testResources.createDataViewIfNeeded('ft_farequote', '@timestamp');
       await transform.testResources.setKibanaTimeZoneToUTC();
 

x-pack/platform/test/functional/apps/transform/creation/runtime_mappings_saved_search/creation_saved_search.ts

@@ -12,12 +12,10 @@ import type { GroupByEntry, LatestTransformTestData, PivotTransformTestData } fr
 import { isLatestTransformTestData, isPivotTransformTestData } from '../../helpers';
 
 export default function ({ getService }: FtrProviderContext) {
-  const esArchiver = getService('esArchiver');
   const transform = getService('transform');
 
   describe('creation_saved_search', function () {
     before(async () => {
-      await esArchiver.loadIfNeeded('x-pack/platform/test/fixtures/es_archives/ml/farequote');
       await transform.testResources.createDataViewIfNeeded('ft_farequote', '@timestamp');
       await transform.testResources.createSavedSearchFarequoteFilterIfNeeded();
       await transform.testResources.setKibanaTimeZoneToUTC();