Merge branch '9.0' into backport/9.0/pr-236161

Author: cqliu1

docs/reference/kibana-accessibility-statement.md

@@ -7,6 +7,7 @@ products:
   - id: kibana
 mapped_pages:
   - https://www.elastic.co/guide/en/kibana/current/accessibility.html
+navigation_title: Accessibility
 ---
 
 # {{kib}} accessibility statement

x-pack/solutions/observability/plugins/synthetics/server/synthetics_service/get_api_key.ts

@@ -43,7 +43,10 @@ export const getAPIKeyForSyntheticsService = async ({
   server,
 }: {
   server: SyntheticsServerSetup;
-}): Promise<{ apiKey?: SyntheticsServiceApiKey; isValid: boolean }> => {
+}): Promise<{
+  apiKey?: SyntheticsServiceApiKey;
+  isValid: boolean;
+}> => {
   try {
     const apiKey = await syntheticsServiceAPIKeySavedObject.get(server);
 
@@ -67,11 +70,6 @@ export const getAPIKeyForSyntheticsService = async ({
       if (!hasPermissions) {
         return { isValid: false, apiKey };
       }
-
-      if (!isValid) {
-        server.logger.info('Synthetics api is no longer valid');
-      }
-
       return { apiKey, isValid };
     }
   } catch (err) {

x-pack/solutions/observability/plugins/synthetics/server/synthetics_service/synthetics_service.test.ts

@@ -275,7 +275,7 @@ describe('SyntheticsService', () => {
 
       await service.pushConfigs();
 
-      expect(serverMock.logger.error).toBeCalledWith(
+      expect(serverMock.logger.debug).toBeCalledWith(
         'API key is not valid. Cannot push monitor configuration to synthetics public testing locations'
       );
     });

x-pack/solutions/observability/plugins/synthetics/server/synthetics_service/synthetics_service.ts

@@ -191,9 +191,7 @@ export class SyntheticsService {
                   await service.pushConfigs();
                 } else {
                   if (!service.isAllowed) {
-                    service.logger.error(
-                      'User is not allowed to access Synthetics service. Please contact support.'
-                    );
+                    service.logger.debug('User is not allowed to access Synthetics service.');
                   }
                 }
               } catch (e) {
@@ -310,10 +308,12 @@ export class SyntheticsService {
   }
 
   async getOutput({ inspect }: { inspect: boolean } = { inspect: false }) {
-    const { apiKey, isValid } = await getAPIKeyForSyntheticsService({ server: this.server });
+    const { apiKey, isValid } = await getAPIKeyForSyntheticsService({
+      server: this.server,
+    });
     // do not check for api key validity if inspecting
     if (!isValid && !inspect) {
-      this.server.logger.error(
+      this.server.logger.debug(
         'API key is not valid. Cannot push monitor configuration to synthetics public testing locations'
       );
       this.invalidApiKeyError = true;

x-pack/solutions/search/plugins/search_playground/public/components/summarization_panel/instructions_field.tsx

@@ -53,6 +53,14 @@ export const InstructionsField: React.FC<InstructionsFieldProps> = ({ value, onC
         </span>
       }
       fullWidth
+      isInvalid={isEmpty(value)}
+      error={
+        isEmpty(value)
+          ? i18n.translate('xpack.searchPlayground.sidebar.instructionsField.errorMessage', {
+              defaultMessage: 'Instructions cannot be empty',
+            })
+          : undefined
+      }
     >
       <EuiTextArea
         data-test-subj="instructionsPrompt"

x-pack/solutions/security/plugins/security_solution/public/common/lib/telemetry/events/rule_upgrade/index.ts

@@ -18,7 +18,7 @@ export const ruleUpgradeFlyoutButtonClickEvent: RuleUpgradeTelemetryEvent = {
         optional: false,
       },
     },
-    hasMissingBaseVersion: {
+    hasBaseVersion: {
       type: 'boolean',
       _meta: {
         description: 'Indicates if the rule has a missing base version',
@@ -44,7 +44,7 @@ export const ruleUpgradeSingleButtonClickEvent: RuleUpgradeTelemetryEvent = {
 export const ruleUpgradeOpenFlyoutEvent: RuleUpgradeTelemetryEvent = {
   eventType: RuleUpgradeEventTypes.RuleUpgradeFlyoutOpen,
   schema: {
-    hasMissingBaseVersion: {
+    hasBaseVersion: {
       type: 'boolean',
       _meta: {
         description: 'Indicates if the rule has a missing base version',

x-pack/solutions/security/plugins/security_solution/public/common/lib/telemetry/events/rule_upgrade/types.ts

@@ -13,15 +13,17 @@ export enum RuleUpgradeEventTypes {
 }
 interface ReportRuleUpgradeFlyoutButtonClickParams {
   type: 'update' | 'dismiss';
-  hasMissingBaseVersion: boolean;
+  hasBaseVersion: boolean;
+  eventVersion: number;
 }
 
 interface ReportRuleUpgradeSingleButtonClickParams {
   hasBaseVersion: boolean;
 }
 
 interface ReportRuleUpgradeFlyoutOpenParams {
-  hasMissingBaseVersion: boolean;
+  hasBaseVersion: boolean;
+  eventVersion: number;
 }
 
 export interface RuleUpgradeTelemetryEventsMap {

x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_management/hooks/use_prebuilt_rules_upgrade.tsx

@@ -48,6 +48,8 @@ import type { RulesConflictStats } from '../../rule_management_ui/components/rul
 import { useKibana } from '../../../common/lib/kibana';
 
 const REVIEW_PREBUILT_RULES_UPGRADE_REFRESH_INTERVAL = 5 * 60 * 1000;
+const RULE_UPGRADE_FLYOUT_BUTTON_EVENT_VERSION = 2;
+const RULE_UPGRADE_FLYOUT_OPEN_EVENT_VERSION = 2;
 
 export const PREBUILT_RULE_UPDATE_FLYOUT_ANCHOR = 'updatePrebuiltRulePreview';
 
@@ -353,16 +355,18 @@ export function usePrebuiltRulesUpgrade({
   );
   const closeRulePreviewAction = (rule: RuleResponse, reason: RulePreviewFlyoutCloseReason) => {
     const ruleUpgradeState = rulesUpgradeState[rule.rule_id];
-    const hasMissingBaseVersion = ruleUpgradeState.has_base_version === false;
+    const hasBaseVersion = ruleUpgradeState.has_base_version === true;
     if (reason === 'dismiss') {
       telemetry.reportEvent(RuleUpgradeEventTypes.RuleUpgradeFlyoutButtonClick, {
         type: 'dismiss',
-        hasMissingBaseVersion,
+        hasBaseVersion,
+        eventVersion: RULE_UPGRADE_FLYOUT_BUTTON_EVENT_VERSION,
       });
     } else {
       telemetry.reportEvent(RuleUpgradeEventTypes.RuleUpgradeFlyoutButtonClick, {
         type: 'update',
-        hasMissingBaseVersion,
+        hasBaseVersion,
+        eventVersion: RULE_UPGRADE_FLYOUT_BUTTON_EVENT_VERSION,
       });
     }
   };
@@ -382,9 +386,11 @@ export function usePrebuiltRulesUpgrade({
     (ruleId: string) => {
       openRulePreviewDefault(ruleId);
       const ruleUpgradeState = rulesUpgradeState[ruleId];
-      const hasMissingBaseVersion = ruleUpgradeState.has_base_version === false;
+      const hasBaseVersion = ruleUpgradeState.has_base_version === true;
+
       telemetry.reportEvent(RuleUpgradeEventTypes.RuleUpgradeFlyoutOpen, {
-        hasMissingBaseVersion,
+        hasBaseVersion,
+        eventVersion: RULE_UPGRADE_FLYOUT_OPEN_EVENT_VERSION,
       });
     },
     [openRulePreviewDefault, rulesUpgradeState, telemetry]