Merge branch 'main' into event-driven-triggers_testing-modal_telemetry

Author: yngrdyn

src/core/test/scout/.meta/api/standard.json

@@ -1,5 +1,5 @@
 {
-  "sha1": "2b70f3fcb59bf151aebaba39638cabf81e58deca",
+  "sha1": "67a81345ddcbff97602a970df9c912ec77780659",
   "tests": [
     {
       "id": "686afb1e43c1702-93eb078795ca679",
@@ -325,6 +325,32 @@
         "column": 10
       }
     },
+    {
+      "id": "6054c2de485a042-eec0454c4331f2c",
+      "title": "translations serves a non-default locale file with the locale field intact",
+      "expectedStatus": "passed",
+      "tags": [
+        "@local-stateful-classic",
+        "@cloud-stateful-classic",
+        "@local-stateful-search",
+        "@cloud-stateful-search",
+        "@local-stateful-observability_complete",
+        "@cloud-stateful-observability_complete",
+        "@local-stateful-security_complete",
+        "@cloud-stateful-security_complete",
+        "@local-serverless-search",
+        "@cloud-serverless-search",
+        "@local-serverless-observability_complete",
+        "@cloud-serverless-observability_complete",
+        "@local-serverless-security_complete",
+        "@cloud-serverless-security_complete"
+      ],
+      "location": {
+        "file": "src/core/test/scout/api/tests/translations.spec.ts",
+        "line": 45,
+        "column": 10
+      }
+    },
     {
       "id": "6054c2de485a042-7c1b7d0f5a752d1",
       "title": "translations returns a 404 when not using the correct locale",
@@ -347,7 +373,7 @@
       ],
       "location": {
         "file": "src/core/test/scout/api/tests/translations.spec.ts",
-        "line": 45,
+        "line": 71,
         "column": 10
       }
     },

src/platform/packages/shared/kbn-react-hooks/src/use_stable_callback/use_stable_callback.ts

@@ -7,18 +7,18 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { useEffect, useRef } from 'react';
+import { useState } from 'react';
+import useLatest from 'react-use/lib/useLatest';
 
 /**
  * Accepts a callback and returns a function with a stable identity
  * that will always call the latest version of the callback when invoked
  */
-export const useStableCallback = <T extends (...args: never[]) => unknown>(fn: T | undefined) => {
-  const ref = useRef(fn);
+export const useStableCallback = <T extends (...args: Parameters<T>) => ReturnType<T>>(fn: T) => {
+  const latestFn = useLatest(fn);
+  const [stableFn] = useState(() => {
+    return ((...args: Parameters<T>) => latestFn.current(...args)) as T;
+  });
 
-  useEffect(() => {
-    ref.current = fn;
-  }, [fn]);
-
-  return useRef((...args: Parameters<T>) => ref.current?.(...args)).current;
+  return stableFn;
 };

src/platform/plugins/private/interactive_setup/public/app.tsx

@@ -76,7 +76,7 @@ export const App: FunctionComponent<AppProps> = ({ onSuccess }) => {
             ${euiShadowM};
           `}
         >
-          <EuiIcon type="logoElastic" size="xxl" />
+          <EuiIcon type="logoElastic" size="xxl" aria-hidden={true} />
         </span>
         <EuiTitle size="m">
           <h1>

src/platform/plugins/private/interactive_setup/public/cluster_configuration_form.tsx

@@ -330,7 +330,7 @@ export const CertificatePanel: FunctionComponent<CertificatePanelProps> = ({
     <EuiPanel color={compressed ? 'subdued' : undefined} hasBorder={!compressed}>
       <EuiFlexGroup responsive={false} alignItems="center" gutterSize="m">
         <EuiFlexItem grow={false}>
-          <EuiIcon type="document" size="l" />
+          <EuiIcon type="document" size="l" aria-hidden={true} />
         </EuiFlexItem>
         <EuiFlexItem>
           <EuiFlexGroup responsive={false} gutterSize="none" justifyContent="spaceBetween">
@@ -453,7 +453,7 @@ const CertificateChain: FunctionComponent<CertificateChainProps> = ({ certificat
                       <EuiSpacer size="s" />
                       <EuiFlexGroup responsive={false} justifyContent="center">
                         <EuiFlexItem grow={false}>
-                          <EuiIcon type="sortDown" color="subdued" />
+                          <EuiIcon type="sortDown" color="subdued" aria-hidden={true} />
                         </EuiFlexItem>
                       </EuiFlexGroup>
                       <EuiSpacer size="s" />

src/platform/plugins/shared/dashboard/test/scout/.meta/ui/parallel.json

@@ -1,5 +1,5 @@
 {
-  "sha1": "62d916926b7f9a09aa1e5dd32e8562a1509b305a",
+  "sha1": "7a294509cbff1cd5aea7b058f64e8462738d117c",
   "tests": [
     {
       "id": "98600d12651f127-aa69b48f5334963",

src/platform/plugins/shared/data_view_editor/test/scout/.meta/ui/standard.json

@@ -0,0 +1,19 @@
+{
+  "sha1": "f837afe9443012a45a6eb6ac3d5f4f0117c0aa1f",
+  "tests": [
+    {
+      "id": "a86ab1ab968d807-0bb82867e148f1f",
+      "title": "Create Data View wizard data stream is accepted as an index pattern source and wizard auto-detects the timestamp field",
+      "expectedStatus": "passed",
+      "tags": [
+        "@local-stateful-classic",
+        "@cloud-stateful-classic"
+      ],
+      "location": {
+        "file": "src/platform/plugins/shared/data_view_editor/test/scout/ui/tests/create_data_view_wizard.spec.ts",
+        "line": 41,
+        "column": 7
+      }
+    }
+  ]
+}

src/platform/plugins/shared/data_view_management/test/scout/.meta/ui/standard.json

@@ -1,5 +1,5 @@
 {
-  "sha1": "4d6b16666a495f40bc282f255d398cd3d0726717",
+  "sha1": "e62501d0bfed5ec7e2269cc6b3f211a9fa39dde2",
   "tests": [
     {
       "id": "be66c17a1888746-11e36bad76c85ff",

src/platform/plugins/shared/discover/moon.yml

@@ -150,6 +150,7 @@ dependsOn:
   - '@kbn/reporting-public'
   - '@kbn/logging'
   - '@kbn/logging-mocks'
+  - '@kbn/react-hooks'
 tags:
   - plugin
   - prod

src/platform/plugins/shared/discover/public/__mocks__/test_provider.tsx

@@ -22,7 +22,7 @@ import {
   DiscoverCustomizationProvider,
   type DiscoverCustomizationService,
 } from '../customizations';
-import { type ScopedProfilesManager } from '../context_awareness';
+import { EMPTY_CONTEXT_AWARENESS_TOOLKIT, type ScopedProfilesManager } from '../context_awareness';
 import type { DiscoverServices } from '../build_services';
 import { createDiscoverServicesMock } from './services';
 import { KibanaRenderContextProvider } from '@kbn/react-kibana-context-render';
@@ -121,7 +121,10 @@ export const DiscoverTestProvider = ({
   const scopedProfilesManager = useMemo(
     () =>
       originalScopedProfilesManager ??
-      services.profilesManager.createScopedProfilesManager({ scopedEbtManager }),
+      services.profilesManager.createScopedProfilesManager({
+        scopedEbtManager,
+        toolkit: EMPTY_CONTEXT_AWARENESS_TOOLKIT,
+      }),
     [originalScopedProfilesManager, scopedEbtManager, services.profilesManager]
   );
 

src/platform/plugins/shared/discover/public/application/context/context_app.test.tsx

@@ -14,7 +14,7 @@ import userEvent from '@testing-library/user-event';
 import { dataViewMock } from '@kbn/discover-utils/src/__mocks__';
 import { setUnifiedDocViewerServices } from '@kbn/unified-doc-viewer-plugin/public/plugin';
 import { mockUnifiedDocViewerServices } from '@kbn/unified-doc-viewer-plugin/public/__mocks__';
-import { DocViewsRegistry } from '@kbn/unified-doc-viewer';
+import { DocViewsRegistry, type DocViewerApi } from '@kbn/unified-doc-viewer';
 import { ContextApp, type ContextAppProps } from './context_app';
 import { createDiscoverServicesMock } from '../../__mocks__/services';
 import { DiscoverTestProvider } from '../../__mocks__/test_provider';
@@ -30,8 +30,6 @@ jest.mock('./hooks/use_context_app_fetch');
 jest.mock('./hooks/use_context_app_state');
 
 const services = createDiscoverServicesMock();
-const addFiltersMock = jest.spyOn(services.filterManager, 'addFilters');
-const updateSavedObjectMock = jest.spyOn(services.dataViews, 'updateSavedObject');
 const mockUseContextAppFetch = jest.mocked(useContextAppFetch);
 const mockUseContextAppState = jest.mocked(useContextAppState);
 
@@ -91,15 +89,44 @@ const setDocViewerRegistry = (render: (props: DocViewRenderProps) => React.React
 };
 
 describe('ContextApp test', () => {
+  const addFilterMock = jest.fn();
+  const setExpandedDocMock = jest.fn();
+  const docViewerRef = React.createRef<DocViewerApi>();
   const defaultProps: ContextAppProps = {
     dataView: dataViewMock,
     anchorId: 'mocked_anchor_id',
+    addFilter: addFilterMock,
+    expandedDoc: undefined,
+    initialDocViewerTabId: undefined,
+    docViewerRef,
+    setExpandedDoc: setExpandedDocMock,
   };
 
   const renderComponent = () => {
+    const StatefulContextApp = () => {
+      const [expandedDoc, setExpandedDocState] = React.useState(defaultProps.expandedDoc);
+      const [initialDocViewerTabId, setInitialDocViewerTabId] = React.useState(
+        defaultProps.initialDocViewerTabId
+      );
+      const setExpandedDoc: ContextAppProps['setExpandedDoc'] = (doc, options) => {
+        setExpandedDocMock(doc, options);
+        setExpandedDocState(doc);
+        setInitialDocViewerTabId(options?.initialTabId);
+      };
+
+      return (
+        <ContextApp
+          {...defaultProps}
+          expandedDoc={expandedDoc}
+          initialDocViewerTabId={initialDocViewerTabId}
+          setExpandedDoc={setExpandedDoc}
+        />
+      );
+    };
+
     renderWithKibanaRenderContext(
       <DiscoverTestProvider services={services}>
-        <ContextApp {...defaultProps} />
+        <StatefulContextApp />
       </DiscoverTestProvider>
     );
   };
@@ -148,7 +175,7 @@ describe('ContextApp test', () => {
     );
   });
 
-  it('should set filters correctly', async () => {
+  it('should call addFilter from the doc viewer', async () => {
     const user = userEvent.setup();
 
     setDocViewerRegistry(({ filter }) => (
@@ -168,15 +195,7 @@ describe('ContextApp test', () => {
 
     await user.click(await screen.findByTestId('docViewFilterButton'));
 
-    expect(addFiltersMock).toHaveBeenCalledTimes(1);
-    expect(addFiltersMock).toHaveBeenCalledWith([
-      {
-        $state: { store: 'appState' },
-        meta: { alias: null, disabled: false, index: 'the-data-view-id', negate: false },
-        query: { match_phrase: { extension: 'jpg' } },
-      },
-    ]);
-    expect(updateSavedObjectMock).toHaveBeenCalledTimes(1);
-    expect(updateSavedObjectMock).toHaveBeenCalledWith(dataViewMock, 0, true);
+    expect(addFilterMock).toHaveBeenCalledTimes(1);
+    expect(addFilterMock).toHaveBeenCalledWith('extension', 'jpg', '+');
   });
 });