Skip to content

Commit 303a78b

Browse files
Kiryousclaude
andcommitted
[One Workflow] Fix Actions menu row layout after EUI 116 upgrade
EUI 116 routes EuiSelectableListItem through the shared EuiListItemLayout, which adds vertical padding on __text and a gap on __content. renderActionOption owns its own spacing, so the new styles stacked on top and inflated every row. Zero out the gap/padding to restore the row height. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 5d496c3 commit 303a78b

1 file changed

Lines changed: 16 additions & 1 deletion

File tree

  • src/platform/plugins/shared/workflows_management/public/features/actions_menu_popover/ui

src/platform/plugins/shared/workflows_management/public/features/actions_menu_popover/ui/actions_menu.tsx

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -417,12 +417,26 @@ const componentStyles = {
417417
'& .euiSelectableListItem.compactOption': {
418418
paddingBlock: euiTheme.size.s,
419419
},
420+
// EUI 116 routes EuiSelectableListItem through EuiListItemLayout, which
421+
// adds gap on __content and vertical padding on __text and drops the
422+
// between-row border. renderActionOption owns its own spacing, so zero
423+
// the new gap/padding out and re-add the row border to match the design.
424+
'& .euiSelectableListItem__content': {
425+
gap: 0,
426+
},
427+
'& .euiSelectableListItem__text': {
428+
paddingBlock: 0,
429+
},
430+
'& .euiSelectableListItem:not(:last-of-type)': {
431+
borderBottom: euiTheme.border.thin,
432+
},
420433
'& .euiSelectableList': {
421434
maxHeight: '420px',
422435
overflowY: 'auto',
423436
},
424437
'& .euiSelectableList__groupLabel': {
425438
borderBottom: euiTheme.border.thin,
439+
paddingInline: '16px',
426440
},
427441
'& .euiSelectableList__groupLabel ~ .euiSelectableList__groupLabel': {
428442
marginTop: '24px',
@@ -435,7 +449,8 @@ const componentStyles = {
435449
}),
436450
header: ({ euiTheme }: UseEuiTheme) =>
437451
css({
438-
padding: euiTheme.size.m,
452+
paddingBlock: euiTheme.size.m,
453+
paddingInline: '16px',
439454
}),
440455
actionOption: css({
441456
gap: '12px',

0 commit comments

Comments
 (0)