[8.19] [Scout][a11y] adding axe-core validation (#243953) (#244796)

alexwizp · web-flow · commit 434c5b3d5039 · 2025-12-03T13:46:40.000+01:00
# Backport This will backport the following commits from `main` to `8.19`: - [[Scout][a11y] adding `axe-core` validation (#243953)](#243953)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -2348,6 +2348,7 @@ module.exports = {
       ],
       rules: {
         '@kbn/eslint/scout_no_describe_configure': 'error',
+        '@kbn/eslint/require_include_in_check_a11y': 'warn',
       },
     },
     {
diff --git a/package.json b/package.json
@@ -1357,6 +1357,7 @@
   },
   "devDependencies": {
     "@apidevtools/swagger-parser": "^12.1.0",
+    "@axe-core/playwright": "^4.11.0",
     "@babel/cli": "^7.24.7",
     "@babel/core": "^7.24.7",
     "@babel/eslint-parser": "^7.24.7",
@@ -1761,7 +1762,7 @@
     "aggregate-error": "^3.1.0",
     "argsplit": "^1.0.5",
     "autoprefixer": "^10.4.7",
-    "axe-core": "^4.10.0",
+    "axe-core": "^4.11.0",
     "babel-jest": "^29.7.0",
     "babel-loader": "^9.1.3",
     "babel-plugin-add-module-exports": "^1.0.4",
diff --git a/packages/kbn-eslint-plugin-eslint/index.js b/packages/kbn-eslint-plugin-eslint/index.js
@@ -21,5 +21,6 @@ module.exports = {
     no_unsafe_console: require('./rules/no_unsafe_console'),
     scout_no_describe_configure: require('./rules/scout_no_describe_configure'),
     require_kbn_fs: require('./rules/require_kbn_fs'),
+    require_include_in_check_a11y: require('./rules/require_include_in_check_a11y'),
   },
 };
diff --git a/packages/kbn-eslint-plugin-eslint/rules/require_include_in_check_a11y.js b/packages/kbn-eslint-plugin-eslint/rules/require_include_in_check_a11y.js
@@ -0,0 +1,67 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the "Elastic License
+ * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side
+ * Public License v 1"; you may not use this file except in compliance with, at
+ * your election, the "Elastic License 2.0", the "GNU Affero General Public
+ * License v3.0 only", or the "Server Side Public License, v 1".
+ */
+
+const isName = (node, expected) =>
+  (node?.type === 'Identifier' && node.name === expected) ||
+  (node?.type === 'Literal' && node.value === expected);
+
+module.exports = {
+  meta: {
+    type: 'suggestion',
+    docs: {
+      description:
+        'Warn when page.checkA11y is called without the include option to encourage scoped a11y scans.',
+      recommended: false,
+    },
+    messages: {
+      requireIncludeInCheckA11y:
+        'We recommend running checkA11y with the include parameter set to the root element you are testing. This makes the tests more isolated and reduces the time required to analyze the DOM structure.',
+    },
+    schema: [],
+  },
+
+  create(context) {
+    const isCheckA11yCall = (node) => {
+      const callee = node && node.callee;
+      if (!callee || callee.type !== 'MemberExpression') return false;
+      return isName(callee.property, 'checkA11y');
+    };
+
+    const hasIncludeProperty = (objExpr) => {
+      for (const prop of objExpr.properties) {
+        if (prop.type === 'Property' && isName(prop.key, 'include')) {
+          return true;
+        }
+      }
+      return false;
+    };
+
+    return {
+      CallExpression(node) {
+        if (!isCheckA11yCall(node)) return;
+
+        const args = node.arguments || [];
+        if (args.length === 0) {
+          context.report({ node, messageId: 'requireIncludeInCheckA11y' });
+          return;
+        }
+
+        const firstArg = args[0];
+        if (!firstArg || firstArg.type !== 'ObjectExpression') {
+          context.report({ node, messageId: 'requireIncludeInCheckA11y' });
+          return;
+        }
+
+        if (!hasIncludeProperty(firstArg)) {
+          context.report({ node, messageId: 'requireIncludeInCheckA11y' });
+        }
+      },
+    };
+  },
+};
diff --git a/packages/kbn-eslint-plugin-eslint/rules/require_include_in_check_a11y.test.js b/packages/kbn-eslint-plugin-eslint/rules/require_include_in_check_a11y.test.js
@@ -0,0 +1,111 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the "Elastic License
+ * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side
+ * Public License v 1"; you may not use this file except in compliance with, at
+ * your election, the "Elastic License 2.0", the "GNU Affero General Public
+ * License v3.0 only", or the "Server Side Public License, v 1".
+ */
+
+const { RuleTester } = require('eslint');
+const rule = require('./require_include_in_check_a11y');
+const dedent = require('dedent');
+
+const ruleTester = new RuleTester({
+  parser: require.resolve('@typescript-eslint/parser'),
+  parserOptions: {
+    sourceType: 'module',
+    ecmaVersion: 2018,
+  },
+});
+
+const MESSAGE =
+  'We recommend running checkA11y with the include parameter set to the root element you are testing. This makes the tests more isolated and reduces the time required to analyze the DOM structure.';
+
+ruleTester.run('@kbn/eslint/require_include_in_check_a11y', rule, {
+  valid: [
+    {
+      code: dedent`
+        page.checkA11y({ include: '#root' });
+      `,
+    },
+    {
+      code: dedent`
+        page.checkA11y({ include: rootEl });
+      `,
+    },
+    {
+      code: dedent`
+        something.checkA11y({ include: '#app', exclude: ['#legacy'] });
+      `,
+    },
+    {
+      code: dedent`
+        page['checkA11y']({ include: '#root' });
+      `,
+    },
+    {
+      code: dedent`
+        page.checkA11y({ include: '#root', other: true });
+      `,
+    },
+    {
+      code: dedent`
+        page.checkA11y({ ['include']: '#root' });
+      `,
+    },
+  ],
+
+  invalid: [
+    {
+      code: dedent`
+        page.checkA11y();
+      `,
+      errors: [{ line: 1, message: MESSAGE }],
+    },
+    {
+      code: dedent`
+        page.checkA11y({});
+      `,
+      errors: [{ line: 1, message: MESSAGE }],
+    },
+    {
+      code: dedent`
+        page.checkA11y({ foo: 1 });
+      `,
+      errors: [{ line: 1, message: MESSAGE }],
+    },
+    {
+      code: dedent`
+        page.checkA11y({ 'include ': '#root' });
+      `,
+      errors: [{ line: 1, message: MESSAGE }],
+    },
+    {
+      code: dedent`
+        page.checkA11y(config);
+      `,
+      errors: [{ line: 1, message: MESSAGE }],
+    },
+    {
+      code: dedent`
+        page['checkA11y']();
+      `,
+      errors: [{ line: 1, message: MESSAGE }],
+    },
+    {
+      // include only in second arg (rule checks first arg)
+      code: dedent`
+        page.checkA11y({}, { include: '#root' });
+      `,
+      errors: [{ line: 1, message: MESSAGE }],
+    },
+    {
+      // Non-object first argument
+      code: dedent`
+        page.checkA11y('not an object');
+      `,
+      errors: [{ line: 1, message: MESSAGE }],
+    },
+  ],
+});
diff --git a/renovate.json b/renovate.json
@@ -249,7 +249,8 @@
     {
       "groupName": "axe-core",
       "matchDepNames": [
-        "axe-core"
+        "axe-core",
+        "@axe-core/playwright"
       ],
       "reviewers": [
         "team:appex-qa"
diff --git a/src/platform/packages/shared/kbn-axe-config/index.ts b/src/platform/packages/shared/kbn-axe-config/index.ts
@@ -50,3 +50,8 @@ export const AXE_OPTIONS = {
     },
   },
 };
+
+export const AXE_IMPACT_LEVELS: Array<'minor' | 'moderate' | 'serious' | 'critical'> = [
+  'critical',
+  'serious',
+];
diff --git a/src/platform/packages/shared/kbn-scout/src/playwright/fixtures/scope/test/scout_page/index.ts b/src/platform/packages/shared/kbn-scout/src/playwright/fixtures/scope/test/scout_page/index.ts
@@ -9,6 +9,7 @@
 
 import { Page } from '@playwright/test';
 import { PathOptions } from '../../../../../common/services/kibana_url';
+import type { RunA11yScanOptions } from '../../../../utils';
 
 /**
  * Extends the Playwright 'Page' interface with methods specific to Kibana.
@@ -31,6 +32,17 @@ export type ScoutPage = Page & {
    * @returns A Promise resolving when the indicator is hidden.
    */
   waitForLoadingIndicatorHidden: () => ReturnType<Page['waitForSelector']>;
+  /**
+   * Performs an accessibility (a11y) scan of the current page using axe-core.
+   * Use this in tests to collect formatted violation summaries (one string per violation).
+   *
+   * @param options - Optional accessibility scan configuration (e.g. selectors to include, exclude, timeout).
+   * @returns A Promise resolving to an object with a 'violations' array containing
+   *          human-readable formatted strings for each detected violation (empty if none).
+   */
+  checkA11y: (options?: RunA11yScanOptions) => Promise<{
+    violations: string[];
+  }>;
   /**
    * Types text into an input field character by character with a specified delay between each character.
    * @param selector - The css selector for the input element.
diff --git a/src/platform/packages/shared/kbn-scout/src/playwright/fixtures/scope/test/scout_page/single_thread.ts b/src/platform/packages/shared/kbn-scout/src/playwright/fixtures/scope/test/scout_page/single_thread.ts
@@ -12,6 +12,7 @@ import type { Page } from '@playwright/test';
 import { test as base } from '@playwright/test';
 import type { ScoutPage } from '.';
 import type { PathOptions } from '../../../../../common/services/kibana_url';
+import { checkA11y } from '../../../../utils';
 import type { KibanaUrl, ScoutLogger } from '../../worker';
 
 /**
@@ -106,6 +107,9 @@ export function extendPlaywrightPage({
     extendedPage.testSubj.waitForSelector('globalLoadingIndicator-hidden', {
       state: 'attached',
     });
+
+  extendedPage.checkA11y = (options) => checkA11y(page, options);
+
   // Method to type text with delay character by character
   extendedPage.typeWithDelay = (selector: string, text: string, options?: { delay: number }) =>
     typeWithDelay(page, selector, text, options);
diff --git a/src/platform/packages/shared/kbn-scout/src/playwright/utils/axe.ts b/src/platform/packages/shared/kbn-scout/src/playwright/utils/axe.ts
@@ -0,0 +1,100 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the "Elastic License
+ * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side
+ * Public License v 1"; you may not use this file except in compliance with, at
+ * your election, the "Elastic License 2.0", the "GNU Affero General Public
+ * License v3.0 only", or the "Server Side Public License, v 1".
+ */
+
+import type { Page } from '@playwright/test';
+import type { Result } from 'axe-core';
+import AxeBuilder from '@axe-core/playwright';
+import { AXE_OPTIONS, AXE_IMPACT_LEVELS } from '@kbn/axe-config';
+
+export interface RunA11yScanOptions {
+  /** Optional CSS selectors to include in analysis */
+  include?: string[];
+  /** Optional CSS selectors to exclude from analysis */
+  exclude?: string[];
+  /** Timeout in ms for the scan (defaults 10000) */
+  timeoutMs?: number;
+}
+
+/**
+ * Runs an Axe accessibility scan
+ *
+ * Failure modes:
+ * - Timeout: Can occur on large or complex DOMs. The scan rejects with a timeout Error; tests should
+ *   be made more isolated by narrowing scope via the `include` option.
+ * - Axe/Playwright errors: Underlying errors propagate and indicate a failed scan.
+ */
+const runA11yScan = async (
+  page: Page,
+  { include = [], exclude = [], timeoutMs = 10000 }: RunA11yScanOptions = {}
+) => {
+  const builder = new AxeBuilder({ page });
+  builder.options(AXE_OPTIONS);
+
+  for (const selector of include) {
+    builder.include(selector);
+  }
+
+  for (const selector of exclude) {
+    builder.exclude(selector);
+  }
+
+  const analysisPromise = builder.analyze();
+  let timeoutId: ReturnType<typeof setTimeout> | undefined;
+
+  const result = await Promise.race([
+    analysisPromise,
+    new Promise<never>((_, reject) => {
+      timeoutId = setTimeout(
+        () => reject(new Error(`Axe accessibility scan timed out after ${timeoutMs}ms`)),
+        timeoutMs
+      );
+    }),
+  ]);
+
+  if (timeoutId) {
+    clearTimeout(timeoutId);
+  }
+
+  let violations: Result[] = result.violations;
+
+  if (AXE_IMPACT_LEVELS?.length) {
+    violations = violations.filter((v) => v.impact && AXE_IMPACT_LEVELS.includes(v.impact));
+  }
+
+  return { violations };
+};
+
+export const checkA11y = async (page: Page, options?: RunA11yScanOptions) => {
+  const { violations } = await runA11yScan(page, options);
+
+  const formatA11yViolation = (v: Result): string => {
+    const nodesSection = v.nodes
+      .map((n, idx) => {
+        const selectors = `${n.target.join(', ')}(xpath: ${n.xpath})`;
+        const failure = n.failureSummary?.trim() || 'No failure summary provided';
+        return `  ${idx + 1}. Selectors: ${selectors}\n     Failure: ${failure}`;
+      })
+      .join('\n');
+
+    return [
+      `\nAccessibility violation detected!\n`,
+      `  Rule: ${v.id}. Impact: (${v.impact ?? 'impact unknown'})`,
+      `  Description: ${v.description}`,
+      `  Help: ${v.help}. See more: ${v.helpUrl}`,
+      `  Page: ${page.url()}`,
+      `  Nodes:\n${nodesSection}`,
+    ]
+      .join('\n')
+      .trim();
+  };
+
+  return {
+    violations: violations.map((v) => formatA11yViolation(v)),
+  };
+};
diff --git a/src/platform/packages/shared/kbn-scout/src/playwright/utils/index.ts b/src/platform/packages/shared/kbn-scout/src/playwright/utils/index.ts
@@ -9,3 +9,4 @@
 
 export { isValidUTCDate, formatTime, getPlaywrightGrepTag, execPromise } from './runner_utils';
 export { resolveSelector, type SelectorInput } from './locator_helper';
+export { checkA11y, type RunA11yScanOptions } from './axe';
diff --git a/src/platform/packages/shared/kbn-scout/test/scout/ui/tests/axe.spec.ts b/src/platform/packages/shared/kbn-scout/test/scout/ui/tests/axe.spec.ts
diff --git a/src/platform/packages/shared/kbn-scout/tsconfig.json b/src/platform/packages/shared/kbn-scout/tsconfig.json
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -2348,6 +2348,7 @@ module.exports = {`
`2348`	`2348`	`],`
`2349`	`2349`	`rules: {`
`2350`	`2350`	`'@kbn/eslint/scout_no_describe_configure': 'error',`
	`2351`	`+ '@kbn/eslint/require_include_in_check_a11y': 'warn',`
`2351`	`2352`	`},`
`2352`	`2353`	`},`
`2353`	`2354`	`{`