refactor(ml): remove filterEsql prop from MlDataSourcePicker and MlOpenSessionFlyout

- Eliminated the `filterEsql` prop from both `MlDataSourcePicker` and `MlOpenSessionFlyout` components to simplify their interfaces.
- Updated the logic to filter out ES|QL-based saved searches directly within the `MlOpenSessionFlyout`

Author: KodeRad

x-pack/platform/packages/private/ml/aiops_components/src/ml_data_source_picker/ml_data_source_picker.tsx

@@ -42,8 +42,6 @@ export interface MlDataSourcePickerProps {
   services: MlDataSourcePickerServices;
   DataViewPickerComponent: ComponentType<DataViewPickerProps>;
   SavedObjectFinderComponent: MlOpenSessionFlyoutProps['SavedObjectFinderComponent'];
-  /** When true, ES|QL-based sessions are hidden from the session picker */
-  filterEsql?: boolean;
   /** Called after a field is saved via the field editor */
   onFieldSaved?: () => void;
 }
@@ -55,7 +53,6 @@ export const MlDataSourcePicker: FC<MlDataSourcePickerProps> = ({
   services,
   DataViewPickerComponent,
   SavedObjectFinderComponent,
-  filterEsql = false,
   onFieldSaved,
 }) => {
   const [savedDataViews, setSavedDataViews] = useState<DataViewListItem[]>([]);
@@ -189,7 +186,6 @@ export const MlDataSourcePicker: FC<MlDataSourcePickerProps> = ({
         onClose={onCloseSession}
         onOpenSavedSearch={onOpenSavedSearch}
         SavedObjectFinderComponent={SavedObjectFinderComponent}
-        filterEsql={filterEsql}
       />
     </>
   ) : (

x-pack/platform/packages/private/ml/aiops_components/src/ml_data_source_picker/ml_open_session_flyout.tsx

@@ -21,15 +21,12 @@ import {
   EuiTitle,
   useGeneratedHtmlId,
 } from '@elastic/eui';
-import {
-  SavedSearchType,
-  SavedSearchTypeDisplayName,
-  type SavedSearchAttributes,
-} from '@kbn/saved-search-plugin/common';
+import { SavedSearchType, SavedSearchTypeDisplayName } from '@kbn/saved-search-plugin/common';
 import type { ApplicationStart, IUiSettingsClient } from '@kbn/core/public';
 import type { ContentManagementPublicStart } from '@kbn/content-management-plugin/public';
 import type { SavedObjectFinderProps } from '@kbn/saved-objects-finder-plugin/public';
-import type { SavedObjectCommon } from '@kbn/saved-objects-finder-plugin/common';
+import type { FinderAttributes, SavedObjectCommon } from '@kbn/saved-objects-finder-plugin/common';
+import { isEsqlSavedSearch, type DiscoverSessionFinderAttributes } from '@kbn/discover-utils';
 
 export type { SavedObjectFinderProps };
 
@@ -49,16 +46,13 @@ export interface MlOpenSessionFlyoutProps {
   onClose: () => void;
   onOpenSavedSearch: (id: string) => void;
   SavedObjectFinderComponent: ComponentType<SavedObjectFinderProps>;
-  /** When true, ES|QL-based sessions are hidden from the list */
-  filterEsql?: boolean;
 }
 
 export const MlOpenSessionFlyout: FC<MlOpenSessionFlyoutProps> = ({
   services,
   onClose,
   onOpenSavedSearch,
   SavedObjectFinderComponent,
-  filterEsql = false,
 }) => {
   const modalTitleId = useGeneratedHtmlId();
   const { http, application, contentManagement, uiSettings } = services;
@@ -108,12 +102,10 @@ export const MlOpenSessionFlyout: FC<MlOpenSessionFlyoutProps> = ({
                   defaultMessage: 'Discover session',
                 }
               ),
-              ...(filterEsql
-                ? {
-                    showSavedObject: (savedObject: SavedObjectCommon<SavedSearchAttributes>) =>
-                      !savedObject.attributes.isTextBasedQuery,
-                  }
-                : {}),
+              // ES|QL Based saved searches are not supported in Discover sessions, filter them out
+              showSavedObject: (
+                savedObject: SavedObjectCommon<FinderAttributes & DiscoverSessionFinderAttributes>
+              ) => !isEsqlSavedSearch(savedObject),
             },
           ]}
           onChoose={onOpenSavedSearch}

x-pack/platform/plugins/shared/ml/public/application/datavisualizer/index_based/index_data_visualizer.tsx

@@ -204,7 +204,6 @@ export const IndexDataVisualizerPage: FC<{ esql: boolean }> = ({ esql = false })
       services={services}
       DataViewPickerComponent={DataViewPicker}
       SavedObjectFinderComponent={SavedObjectFinder}
-      filterEsql
       onFieldSaved={() => mlTimefilterRefresh$.next({ lastRefresh: Date.now() })}
     />
   ) : undefined;