Merge branch 'main' into flaky-test-237285

Author: elasticmachine

.buildkite/package-lock.json

@@ -24,7 +24,7 @@
     "@types/jscodeshift": "^0.12.0",
     "@types/minimatch": "^3.0.5",
     "@types/minimist": "^1.2.5",
-    "@types/node": "^22.19.1",
+    "@types/node": "22.19.0",
     "jest": "^30.0.3",
     "jscodeshift": "^17.1.2",
     "nock": "^12.0.2",

.buildkite/package.json

@@ -7,5 +7,5 @@ source .buildkite/scripts/common/util.sh
 .buildkite/scripts/bootstrap.sh
 
 echo --- Check Types
-set +e
-node scripts/type_check --with-archive
+
+node scripts/type_check

.buildkite/scripts/steps/typecheck/check_types.sh

@@ -2625,6 +2625,7 @@ x-pack/solutions/security/test/serverless/functional/configs/config.context_awar
 /x-pack/solutions/security/plugins/security_solution/public/detections/utils @elastic/security-threat-hunting-investigations
 /x-pack/solutions/security/plugins/security_solution/public/flyout/document_details @elastic/security-threat-hunting-investigations
 /x-pack/solutions/security/plugins/security_solution/public/flyout/network_details @elastic/security-threat-hunting-investigations
+/x-pack/solutions/security/plugins/security_solution/public/flyout/attack_details @elastic/security-threat-hunting-investigations
 /x-pack/solutions/security/plugins/security_solution/public/flyout/shared @elastic/security-threat-hunting-investigations
 /x-pack/solutions/security/plugins/security_solution/public/flyout/rule_details @elastic/security-threat-hunting-investigations
 /x-pack/solutions/security/plugins/security_solution/public/investigations @elastic/security-threat-hunting-investigations

.github/CODEOWNERS

@@ -21,7 +21,7 @@ If you want to use a Kibana release in production, give it a test run, or just p
 
 - Download the latest version on the [Kibana Download Page](https://www.elastic.co/downloads/kibana).
 - Learn more about Kibana's features and capabilities on the
-[Kibana Product Page](https://www.elastic.co/products/kibana).
+[Kibana Product Page](https://www.elastic.co/kibana).
 - We also offer a hosted version of Kibana on our
 [Cloud Service](https://www.elastic.co/cloud/as-a-service).
 
@@ -32,8 +32,7 @@ out an open PR:
 
 - [CONTRIBUTING.md](CONTRIBUTING.md) will help you get Kibana up and running.
 - If you would like to contribute code, please follow our [STYLEGUIDE.mdx](STYLEGUIDE.mdx).
-- For all other questions, check out the [FAQ.md](FAQ.md) and
-[wiki](https://github.com/elastic/kibana/wiki).
+- For all other questions, check out the [FAQ.md](FAQ.md).
 
 ## Documentation
 

README.md

@@ -1829,7 +1829,7 @@
     "@types/moment-duration-format": "^2.2.6",
     "@types/mustache": "^4.2.5",
     "@types/nock": "^10.0.3",
-    "@types/node": "22.19.1",
+    "@types/node": "22.19.0",
     "@types/node-fetch": "2.6.4",
     "@types/node-forge": "^1.3.14",
     "@types/nodemailer": "^7.0.4",

package.json

@@ -10,7 +10,7 @@
 import chalk from 'chalk';
 import type { ToolingLog } from '@kbn/tooling-log';
 
-import { Config, createRunner } from './lib';
+import { Config, SOLUTION_BUILDS, createRunner } from './lib';
 import * as Tasks from './tasks';
 
 export interface BuildOptions {
@@ -167,16 +167,12 @@ export async function buildDistributables(log: ToolingLog, options: BuildOptions
 
   if (options.createDockerServerless) {
     // control w/ --docker-images and --skip-docker-serverless
-    artifactTasks.push(Tasks.CreateDockerServerless('x64', null));
-    artifactTasks.push(Tasks.CreateDockerServerless('x64', 'workplaceai'));
-    artifactTasks.push(Tasks.CreateDockerServerless('x64', 'observability'));
-    artifactTasks.push(Tasks.CreateDockerServerless('x64', 'elasticsearch'));
-    artifactTasks.push(Tasks.CreateDockerServerless('x64', 'security'));
-    artifactTasks.push(Tasks.CreateDockerServerless('aarch64', null));
-    artifactTasks.push(Tasks.CreateDockerServerless('aarch64', 'workplaceai'));
-    artifactTasks.push(Tasks.CreateDockerServerless('aarch64', 'observability'));
-    artifactTasks.push(Tasks.CreateDockerServerless('aarch64', 'elasticsearch'));
-    artifactTasks.push(Tasks.CreateDockerServerless('aarch64', 'security'));
+    artifactTasks.push(Tasks.CreateDockerServerless('x64'));
+    artifactTasks.push(Tasks.CreateDockerServerless('aarch64'));
+    SOLUTION_BUILDS.forEach((solution) => {
+      artifactTasks.push(Tasks.CreateDockerServerless('x64', solution));
+      artifactTasks.push(Tasks.CreateDockerServerless('aarch64', solution));
+    });
   }
 
   if (options.createDockerFIPS) {

src/dev/build/build_distributables.ts

@@ -44,7 +44,7 @@ export async function unzipBuffer(buffer: Buffer): Promise<ZipEntry[]> {
   return zipEntries;
 }
 
-export async function createZipFile(entries: ZipEntry[], destination: string): Promise<Buffer> {
+export async function createZipFile(entries: ZipEntry[], destination: string): Promise<void> {
   const zipfile = new yazl.ZipFile();
 
   for (const entry of entries) {

src/dev/build/lib/archive_utils.ts

@@ -11,6 +11,7 @@ import chalk from 'chalk';
 
 import type { Config } from './config';
 import type { Platform } from './platform';
+import { dashSuffix } from './util';
 
 export class Build {
   private buildDesc: string = '';
@@ -24,32 +25,30 @@ export class Build {
   }
 
   resolvePathForPlatform(platform: Platform, ...args: string[]) {
-    const variant = platform.getVariant() ? `-${platform.getVariant()}` : '';
-    const solution = platform.getSolution() ? `-${platform.getSolution()}` : '';
     return this.config.resolveFromRepo(
       'build',
       'default',
-      `kibana${variant}${solution}-${this.config.getBuildVersion()}-${platform.getBuildName()}`,
+      `kibana${dashSuffix(platform.getVariant())}${dashSuffix(
+        platform.getSolutionArtifact()
+      )}-${this.config.getBuildVersion()}-${platform.getBuildName()}`,
       ...args
     );
   }
 
   getPlatformArchivePath(platform: Platform) {
     const ext = platform.isWindows() ? 'zip' : 'tar.gz';
-    const variant = platform.getVariant() ? `-${platform.getVariant()}` : '';
-    const solution = platform.getSolution() ? `-${platform.getSolution()}` : '';
     return this.config.resolveFromRepo(
       'target',
-      `${
-        this.name
-      }${variant}${solution}-${this.config.getBuildVersion()}-${platform.getBuildName()}.${ext}`
+      `${this.name}${dashSuffix(platform.getVariant())}${dashSuffix(
+        platform.getSolutionArtifact()
+      )}-${this.config.getBuildVersion()}-${platform.getBuildName()}.${ext}`
     );
   }
 
   getRootDirectory(platform: Platform) {
-    const variant = platform.getVariant() ? `-${platform.getVariant()}` : '';
-    const solution = platform.getSolution() ? `-${platform.getSolution()}` : '';
-    return `${this.name}${variant}${solution}-${this.config.getBuildVersion()}`;
+    return `${this.name}${dashSuffix(platform.getVariant())}${dashSuffix(
+      platform.getSolutionArtifact()
+    )}-${this.config.getBuildVersion()}`;
   }
 
   getName() {

src/dev/build/lib/build.ts

@@ -18,9 +18,10 @@ import {
   type PluginPackage,
   getPluginPackagesFilter,
 } from '@kbn/repo-packages';
+import type { KibanaSolution } from '@kbn/projects-solutions-groups';
 import type { VersionInfo } from './version_info';
 import { getVersionInfo } from './version_info';
-import type { PlatformName, PlatformArchitecture, Solution } from './platform';
+import type { PlatformName, PlatformArchitecture } from './platform';
 import { ALL_PLATFORMS, SERVERLESS_PLATFORMS } from './platform';
 import type { BuildOptions } from '../build_distributables';
 
@@ -275,7 +276,7 @@ export class Config {
     return getPackages(this.repoRoot).filter((p) => !p.isDevOnly() && this.pluginFilter(p));
   }
 
-  getPrivateSolutionPackagesFromRepo(project: Solution) {
+  getPrivateSolutionPackagesFromRepo(project: KibanaSolution) {
     return getPackages(this.repoRoot).filter(
       (p) => p.group === project && p.visibility === 'private'
     );