[Discover] Pre-migration cleanup: additional within-plugin dedupe opportunities (#271647)

- Closes #270615

## Summary

### Area 1: Field-data behavior — MERGED
**Files changed:**
- Deleted
`src/platform/test/functional/apps/discover/group2_data_grid2/_data_grid_field_data.ts`
- Removed its `loadTestFile` entry from `group2_data_grid2/index.ts`
- Moved 2 unique grid-specific tests (`doc view should show exact header
fields`, `doc view should sort ascending`) into
`group5/_field_data_with_fields_api.ts`
**Why:** 4 of 6 tests were byte-for-byte duplicates of tests already in
`_field_data_with_fields_api.ts` (php hit count, php highlight,
type:apache hit count, bad syntax error). The 2 remaining grid-specific
tests were merged into the canonical file, eliminating an entire test
file and its setup overhead from the `group2_data_grid2` CI config.
---
### Area 4: Embeddable dashboard round-trip — MERGED WITH SHARED HELPER
**Files changed:**
- Deleted
`src/platform/test/functional/apps/discover/embeddable_2/_esql_embeddable.ts`
- Removed its `loadTestFile` entry from `embeddable_2/index.ts`
- Restructured `embeddable/_saved_search_embeddable.ts` to add a
`describeEditSessionTests` helper that generates 3 edit-session tests
(linked edit + return, by-value edit + return, save-as-new) for any
panel type
- The helper is called twice: once for saved search panels, once for
ES|QL panels
- Both use the same `discover.getSavedSearchDocumentCount()` assertion
(same UI component for both panel types)
**Why:** 3 of 4 ES|QL tests repeated the same edit-session navigation
contract as the saved-search tests. A shared helper now exercises both
panel types with zero code duplication, while each type gets its own
test runs to catch type-specific regressions. The 1 unique "add ES|QL
panel" smoke test is covered implicitly by the linked-session edit test.
---
### Area 2: Context navigation — REPOSITIONED
**Files changed:**
- Moved the "should open the context view with the same columns" test in
`group2_data_grid1/_data_grid_context.ts` to run **after** the anchor
test instead of before it
**Why:** Previously this test ran first (on Discover, not on the context
view) making it a duplicate of what `context/_discover_navigation.ts`
checks. By placing it after the anchor test navigates to context, it now
verifies that the **context view** inherited the correct columns — a
different and valid assertion.

### Area 5: Sidebar/doc viewer search-flow
**Why not changed:** The 8 overlapping test titles test the same
*scenarios* (wildcard, fuzzy, etc.) but on completely different UI
surfaces with different APIs (`unifiedFieldList.findFieldByName` vs
`discover.findFieldByNameOrValueInDocViewer`), different assertion
strategies (exact field name arrays vs DOM cell counts), and different
expected values (4 vs 3 fields for fuzzy search due to different search
corpora). They run on separate CI configs so deduplication saves 0s. A
shared helper would be entirely parameters — harder to read than the
original tests.
### Area 3: Read-only badge privilege checks
**Why not changed:** 2 of 3 files have already been migrated to Scout.
The remaining `discover_security.ts` has unique Discover-specific tests
(share URLs, CSV export, alias access) with no remaining overlap.



### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

Author: jughosta

src/platform/test/functional/apps/discover/embeddable/_saved_search_embeddable.ts

@@ -200,62 +200,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       });
     });
 
-    it('can edit a session and return to the dashboard', async () => {
-      await addSearchEmbeddableToDashboard('logstash hits');
-      expect(await discover.getSavedSearchDocumentCount()).to.be('4,633 documents');
-      await discover.editEmbeddableInDiscover();
-      // Run validations concurrently
-      await Promise.all([
-        globalNav
-          .getFirstBreadcrumb()
-          .then((firstBreadcrumb) => expect(firstBreadcrumb).to.be('Dashboards')),
-        discover
-          .getSavedSearchTitle()
-          .then((lastBreadcrumb) => expect(lastBreadcrumb).to.be('Editing logstash hits')),
-        testSubjects
-          .exists('unifiedTabs_tabsBar', { timeout: 1000 })
-          .then((unifiedTabs) => expect(unifiedTabs).to.be(true)),
-        discover.isOnDashboardsEditMode().then((editMode) => expect(editMode).to.be(true)),
-      ]);
-      await queryBar.setQuery('test');
-      await queryBar.submitQuery();
-      await discover.waitUntilTabIsLoaded();
-      await discover.saveSearch('logstash hits');
-      await dashboard.waitForRenderComplete();
-      await dashboard.verifyNoRenderErrors();
-      expect(await discover.getSavedSearchDocumentCount()).to.be('35 documents');
-    });
-
-    it('can edit a by-value session and return to the dashboard', async () => {
-      await addSearchEmbeddableToDashboard();
-      await dashboardPanelActions.clickPanelAction('embeddablePanelAction-unlinkFromLibrary');
-      await dashboardPanelActions.clickEdit();
-      await header.waitUntilLoadingHasFinished();
-
-      // Run validations concurrently
-      await Promise.all([
-        globalNav
-          .getFirstBreadcrumb()
-          .then((firstBreadcrumb) => expect(firstBreadcrumb).to.be('Dashboards')),
-        discover
-          .getSavedSearchTitle()
-          .then((lastBreadcrumb) =>
-            expect(lastBreadcrumb).to.be('Editing Rendering Test: saved search')
-          ),
-        testSubjects
-          .exists('unifiedTabs_tabsBar', { timeout: 1000 })
-          .then((unifiedTabs) => expect(unifiedTabs).not.to.be(true)),
-        discover.isOnDashboardsEditMode().then((editMode) => expect(editMode).to.be(true)),
-      ]);
-      await queryBar.setQuery('test');
-      await queryBar.submitQuery();
-      await discover.waitUntilTabIsLoaded();
-      await discover.clickSaveSearchButton();
-      await dashboard.waitForRenderComplete();
-      await dashboard.verifyNoRenderErrors();
-      expect(await discover.getSavedSearchDocumentCount()).to.be('13 documents');
-    });
-
     it('can cancel a By Value edit and return to the dashboard', async () => {
       await addSearchEmbeddableToDashboard();
       // Have to unlink else the cancel flow fails?
@@ -326,28 +270,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       ]);
     });
 
-    it('switches to Discover mode if search is saved as new', async () => {
-      await addSearchEmbeddableToDashboard();
-      await discover.editEmbeddableInDiscover();
-      await discover.saveAsSearch('Rendering Test: saved as search');
-      await header.waitUntilLoadingHasFinished();
-      // Run validations concurrently
-      await Promise.all([
-        globalNav
-          .getFirstBreadcrumb()
-          .then((firstBreadcrumb) => expect(firstBreadcrumb).to.be('Discover')),
-        discover
-          .getSavedSearchTitle()
-          .then((lastBreadcrumb) =>
-            expect(lastBreadcrumb).to.be('Rendering Test: saved as search')
-          ),
-        testSubjects
-          .exists('unifiedTabs_tabsBar', { timeout: 1000 })
-          .then((unifiedTabs) => expect(unifiedTabs).to.be(true)),
-        discover.isOnDashboardsEditMode().then((editMode) => expect(editMode).to.be(false)),
-      ]);
-    });
-
     it('switches by-value to Discover mode if search is saved as new', async () => {
       await addSearchEmbeddableToDashboard();
       await dashboardPanelActions.clickPanelAction('embeddablePanelAction-unlinkFromLibrary');
@@ -372,5 +294,133 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         discover.isOnDashboardsEditMode().then((editMode) => expect(editMode).to.be(false)),
       ]);
     });
+
+    describe('edit session round-trip', () => {
+      before(async () => {
+        await kibanaServer.importExport.load(
+          'src/platform/test/functional/fixtures/kbn_archiver/discover'
+        );
+      });
+
+      after(async () => {
+        await kibanaServer.importExport.unload(
+          'src/platform/test/functional/fixtures/kbn_archiver/discover'
+        );
+      });
+
+      describeEditSessionTests({
+        title: 'saved search panel',
+        panelName: 'Rendering Test: saved search',
+        editingTitle: 'Rendering Test: saved search',
+        savedAsTitle: 'Rendering Test: saved as search',
+      });
+
+      describeEditSessionTests({
+        title: 'ES|QL panel',
+        panelName: 'ES|QL Discover Session',
+        editingTitle: 'ES|QL Discover Session',
+        savedAsTitle: 'ES|QL Discover Session Saved As',
+      });
+    });
   });
+
+  /**
+   * Generates the shared edit-session round-trip tests for a given embeddable type.
+   * Each session type (saved search vs ES|QL) exercises the same navigation contract.
+   */
+  function describeEditSessionTests({
+    title,
+    panelName,
+    editingTitle,
+    savedAsTitle,
+  }: {
+    title: string;
+    panelName: string;
+    editingTitle: string;
+    savedAsTitle: string;
+  }) {
+    describe(title, () => {
+      beforeEach(async () => {
+        await dashboard.navigateToApp();
+        await filterBar.ensureFieldEditorModalIsClosed();
+        await dashboard.gotoDashboardLandingPage();
+        await dashboard.clickNewDashboard();
+      });
+
+      it('can edit a linked session and return to the dashboard', async () => {
+        await dashboardAddPanel.addSavedSearch(panelName);
+        await header.waitUntilLoadingHasFinished();
+        await dashboard.waitForRenderComplete();
+        expect(await discover.getSavedSearchDocumentCount()).to.not.be(undefined);
+        await discover.editEmbeddableInDiscover();
+        await header.waitUntilLoadingHasFinished();
+        // Run validations concurrently
+        await Promise.all([
+          globalNav
+            .getFirstBreadcrumb()
+            .then((firstBreadcrumb) => expect(firstBreadcrumb).to.be('Dashboards')),
+          discover
+            .getSavedSearchTitle()
+            .then((lastBreadcrumb) => expect(lastBreadcrumb).to.be(`Editing ${editingTitle}`)),
+          testSubjects
+            .exists('unifiedTabs_tabsBar', { timeout: 1000 })
+            .then((unifiedTabs) => expect(unifiedTabs).to.be(true)),
+          discover.isOnDashboardsEditMode().then((editMode) => expect(editMode).to.be(true)),
+        ]);
+        await discover.saveSearch(panelName);
+        await dashboard.waitForRenderComplete();
+        await dashboard.verifyNoRenderErrors();
+        expect(await discover.getSavedSearchDocumentCount()).to.not.be(undefined);
+      });
+
+      it('can edit a by-value session and return to the dashboard', async () => {
+        await dashboardAddPanel.addSavedSearch(panelName);
+        await header.waitUntilLoadingHasFinished();
+        await dashboard.waitForRenderComplete();
+        await dashboardPanelActions.clickPanelAction('embeddablePanelAction-unlinkFromLibrary');
+        await dashboardPanelActions.clickEdit();
+        await header.waitUntilLoadingHasFinished();
+        // Run validations concurrently
+        await Promise.all([
+          globalNav
+            .getFirstBreadcrumb()
+            .then((firstBreadcrumb) => expect(firstBreadcrumb).to.be('Dashboards')),
+          discover
+            .getSavedSearchTitle()
+            .then((lastBreadcrumb) => expect(lastBreadcrumb).to.be(`Editing ${editingTitle}`)),
+          testSubjects
+            .exists('unifiedTabs_tabsBar', { timeout: 1000 })
+            .then((unifiedTabs) => expect(unifiedTabs).not.to.be(true)),
+          discover.isOnDashboardsEditMode().then((editMode) => expect(editMode).to.be(true)),
+        ]);
+        await discover.clickSaveSearchButton();
+        await dashboard.waitForRenderComplete();
+        await dashboard.verifyNoRenderErrors();
+        expect(await discover.getSavedSearchDocumentCount()).to.not.be(undefined);
+      });
+
+      it('switches to Discover mode if search is saved as new', async () => {
+        await dashboardAddPanel.addSavedSearch(panelName);
+        await header.waitUntilLoadingHasFinished();
+        await dashboard.waitForRenderComplete();
+        await discover.editEmbeddableInDiscover();
+        await header.waitUntilLoadingHasFinished();
+        await discover.saveAsSearch(savedAsTitle);
+        await header.waitUntilLoadingHasFinished();
+        // Run validations concurrently
+        await Promise.all([
+          globalNav
+            .getFirstBreadcrumb()
+            .then((firstBreadcrumb) => expect(firstBreadcrumb).to.be('Discover')),
+          discover
+            .getSavedSearchTitle()
+            .then((lastBreadcrumb) => expect(lastBreadcrumb).to.be(savedAsTitle)),
+          testSubjects
+            .exists('unifiedTabs_tabsBar', { timeout: 1000 })
+            .then((unifiedTabs) => expect(unifiedTabs).to.be(true)),
+          discover.isOnDashboardsEditMode().then((editMode) => expect(editMode).to.be(false)),
+        ]);
+      });
+    });
+  }
 }

src/platform/test/functional/apps/discover/embeddable_2/_esql_embeddable.ts

@@ -26,7 +26,6 @@ export default function ({ getService, loadTestFile }: FtrProviderContext) {
 
     loadTestFile(require.resolve('./multiple_data_views'));
     loadTestFile(require.resolve('./_log_stream_embeddable'));
-    loadTestFile(require.resolve('./_esql_embeddable'));
     loadTestFile(require.resolve('./_new_panel_embeddable'));
     loadTestFile(require.resolve('./_save_session_to_dashboard'));
   });

src/platform/test/functional/apps/discover/embeddable_2/index.ts

@@ -65,11 +65,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       await timePicker.resetDefaultAbsoluteRangeViaUiSettings();
     });
 
-    it('should open the context view with the same columns', async () => {
-      const columnNames = await dataGrid.getHeaderFields();
-      expect(columnNames).to.eql(['@timestamp', ...TEST_COLUMN_NAMES]);
-    });
-
     it('should open the context view with the selected document as anchor', async () => {
       // get the timestamp of the first row
       const discoverFields = await dataGrid.getFields();
@@ -81,6 +76,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       await rowActions[1].click();
       await context.waitUntilContextLoadingHasFinished();
 
+      const columnNames = await dataGrid.getHeaderFields();
+      expect(columnNames).to.eql(['@timestamp', ...TEST_COLUMN_NAMES]);
+
       await dataGrid.clickRowToggle({ isAnchorRow: true });
       await dataGrid.isShowingDocViewer();
       const anchorTimestamp = await testSubjects.getVisibleText('tableDocViewRow-@timestamp-value');