fix scout tests

Author: juliaElastic

x-pack/platform/plugins/shared/ingest_hub/test/scout/ui/tests/onboarding_connect_step.spec.ts

@@ -13,15 +13,15 @@ test.describe('Onboarding connect step', { tag: tags.stateful.classic }, () => {
   test.beforeAll(async ({ apiServices }) => {
     await apiServices.core.settings({
       'feature_flags.overrides': {
-        'ingestHub.onboardingEnabled': true,
+        'ingestHub.onboardingEnabled': 'true',
       },
     });
   });
 
   test.afterAll(async ({ apiServices }) => {
     await apiServices.core.settings({
       'feature_flags.overrides': {
-        'ingestHub.onboardingEnabled': false,
+        'ingestHub.onboardingEnabled': 'false',
       },
     });
   });
@@ -53,10 +53,16 @@ test.describe('Onboarding connect step', { tag: tags.stateful.classic }, () => {
     page,
   }) => {
     await browserAuth.loginAsAdmin();
+
+    // Deselect all services so selectedServiceIds is empty → showIdentityFederation = true
+    await page.gotoApp('onboarding/aws#services');
+    await expect(page.testSubj.locator('onboardingStep-services')).toBeVisible();
+    await page.testSubj.locator('servicesStep-deselectAllButton').click();
+
     await page.gotoApp('onboarding/aws#connect');
     await expect(page.testSubj.locator('onboardingStep-connect')).toBeVisible();
 
-    // Identity federation is the default auth type; with no connectors the New Identity tab is shown
+    // Identity federation is shown when no services are selected; with no connectors the New Identity tab is shown
     await expect(page.testSubj.locator('awsIdentityFederationSetup-roleArn')).toBeVisible();
     await expect(
       page.testSubj.locator('awsIdentityFederationSetup-launchCloudFormation')
@@ -127,6 +133,12 @@ test.describe('Onboarding connect step', { tag: tags.stateful.classic }, () => {
       connectorId = response.data.item.id;
 
       await browserAuth.loginAsAdmin();
+
+      // Deselect all services so selectedServiceIds is empty → showIdentityFederation = true
+      await page.gotoApp('onboarding/aws#services');
+      await expect(page.testSubj.locator('onboardingStep-services')).toBeVisible();
+      await page.testSubj.locator('servicesStep-deselectAllButton').click();
+
       await page.gotoApp('onboarding/aws#connect');
       await expect(page.testSubj.locator('onboardingStep-connect')).toBeVisible();
 

x-pack/platform/plugins/shared/ingest_hub/test/scout/ui/tests/onboarding_ff_enabled.spec.ts

@@ -21,7 +21,7 @@ test.describe('Onboarding app — FF enabled', { tag: tags.stateful.classic }, (
   test.afterAll(async ({ apiServices }) => {
     await apiServices.core.settings({
       'feature_flags.overrides': {
-        'ingestHub.onboardingEnabled': false,
+        'ingestHub.onboardingEnabled': 'false',
       },
     });
   });
@@ -34,15 +34,15 @@ test.describe('Onboarding app — FF enabled', { tag: tags.stateful.classic }, (
 
     await test.step('redirects to first step hash when no hash is present', async () => {
       await page.gotoApp('onboarding/aws');
-      await expect(page).toHaveURL(/#connect/);
+      await expect(page).toHaveURL(/#services/);
     });
 
     await test.step('renders the onboarding step shell', async () => {
       await expect(page.testSubj.locator('onboardingShell')).toBeVisible();
     });
 
-    await test.step('shows the connect step as current', async () => {
-      await expect(page.testSubj.locator('onboardingStep-connect')).toBeVisible();
+    await test.step('shows the services step as current', async () => {
+      await expect(page.testSubj.locator('onboardingStep-services')).toBeVisible();
     });
 
     await test.step('renders 5 step indicators', async () => {

x-pack/platform/plugins/shared/ingest_hub/test/scout/ui/tests/onboarding_services_step.spec.ts

@@ -9,9 +9,10 @@ import { tags } from '@kbn/scout';
 import { expect } from '@kbn/scout/ui';
 import { test } from '../fixtures';
 
-// cloudwatch_logs and cloudwatch_metrics have defaultEnabled: false; all others are enabled by default.
-const TOTAL_SERVICES = 14;
-const DEFAULT_SELECTED_COUNT = 12;
+// 54 services have showInUI: true. 7 of those have defaultEnabled: false:
+// cloudwatch_logs, cloudwatch_metrics, cloudtrail_otel, vpcflow_otel, waf_otel, aws_logs, firehose.
+const TOTAL_SERVICES = 54;
+const DEFAULT_SELECTED_COUNT = 47;
 
 test.describe('Onboarding services step', { tag: tags.stateful.classic }, () => {
   test.beforeAll(async ({ apiServices }) => {
@@ -38,9 +39,11 @@ test.describe('Onboarding services step', { tag: tags.stateful.classic }, () =>
     const rows = page.locator('[data-test-subj^="servicesStep-serviceRow-"]');
     await expect(rows).toHaveCount(TOTAL_SERVICES);
 
-    // cloudwatch_logs and cloudwatch_metrics are off by default
+    // services with defaultEnabled: false are unchecked
     await expect(page.testSubj.locator('servicesStep-toggle-cloudwatch_logs')).not.toBeChecked();
     await expect(page.testSubj.locator('servicesStep-toggle-cloudwatch_metrics')).not.toBeChecked();
+    await expect(page.testSubj.locator('servicesStep-toggle-cloudtrail_otel')).not.toBeChecked();
+    await expect(page.testSubj.locator('servicesStep-toggle-firehose')).not.toBeChecked();
 
     // a defaultEnabled service is checked
     await expect(page.testSubj.locator('servicesStep-toggle-guardduty')).toBeChecked();