chore: cleanup

Author: jonwalstedt

oas_docs/output/kibana.serverless.yaml

@@ -2906,9 +2906,6 @@ paths:
                           nullable: true
                         description: Payload of the attachment. Required unless `origin` is provided (content is resolved once at send time).
                         type: object
-                      groupId:
-                        description: Optional group identifier. Attachments sharing the same groupId are removed together in the UI.
-                        type: string
                       hidden:
                         description: When true, the attachment will not be displayed in the UI.
                         type: boolean
@@ -3292,9 +3289,6 @@ paths:
                           nullable: true
                         description: Payload of the attachment. Required unless `origin` is provided (content is resolved once at send time).
                         type: object
-                      groupId:
-                        description: Optional group identifier. Attachments sharing the same groupId are removed together in the UI.
-                        type: string
                       hidden:
                         description: When true, the attachment will not be displayed in the UI.
                         type: boolean

oas_docs/output/kibana.yaml

@@ -2976,9 +2976,6 @@ paths:
                           nullable: true
                         description: Payload of the attachment. Required unless `origin` is provided (content is resolved once at send time).
                         type: object
-                      groupId:
-                        description: Optional group identifier. Attachments sharing the same groupId are removed together in the UI.
-                        type: string
                       hidden:
                         description: When true, the attachment will not be displayed in the UI.
                         type: boolean
@@ -3362,9 +3359,6 @@ paths:
                           nullable: true
                         description: Payload of the attachment. Required unless `origin` is provided (content is resolved once at send time).
                         type: object
-                      groupId:
-                        description: Optional group identifier. Attachments sharing the same groupId are removed together in the UI.
-                        type: string
                       hidden:
                         description: When true, the attachment will not be displayed in the UI.
                         type: boolean

x-pack/platform/plugins/shared/agent_builder/public/application/context/conversation/upsert_attachments_into_list.ts

@@ -24,14 +24,21 @@ export const upsertAttachmentsIntoList = (
 ): ConversationAttachment[] => {
   const existing = [...(existingAttachments ?? [])];
 
+  // Map of id -> attachment for the incoming list (only items with id). Used to update
+  // existing entries in O(1). keyBy keeps last occurrence when ids repeat, which we want.
   const nextById = keyBy(
     nextAttachments.filter((a): a is ConversationAttachment & { id: string } => Boolean(a.id)),
     'id'
   );
 
+  // Ids already present in existing list — used to decide which next items are truly "new"
+  // and should be appended (we must not re-append when we only meant to update by id).
   const existingIds = new Set(existing.map((a) => a.id).filter((id): id is string => Boolean(id)));
 
+  // Preserve existing order: each slot keeps its item or the updated version from nextById.
   const updated = existing.map((a) => (a.id && nextById[a.id] ? nextById[a.id] : a));
+
+  // Append only items that are new (no id) or whose id was not in the existing list.
   const newItems = nextAttachments.filter((a) => !a.id || !existingIds.has(a.id));
 
   return [...updated, ...newItems];

x-pack/solutions/security/plugins/security_solution/public/agent_builder/helpers.test.tsx

@@ -87,7 +87,8 @@ describe('stringifyEssentialAlertData', () => {
       anotherNonEssential: ['shouldAlsoBeExcluded'],
     };
 
-    const parsed = JSON.parse(stringifyEssentialAlertData(rawData));
+    const result = stringifyEssentialAlertData(rawData);
+    const parsed = JSON.parse(result);
 
     expect(parsed).toHaveProperty(ESSENTIAL_ALERT_FIELDS[0]);
     expect(parsed).toHaveProperty(ESSENTIAL_ALERT_FIELDS[1]);
@@ -96,18 +97,36 @@ describe('stringifyEssentialAlertData', () => {
   });
 
   it('excludes non-essential fields', () => {
-    const parsed = JSON.parse(
-      stringifyEssentialAlertData({ field1: ['value1'], field2: ['value2'] })
-    );
+    const rawData: Record<string, string[]> = {
+      field1: ['value1'],
+      field2: ['value2'],
+    };
+
+    const result = stringifyEssentialAlertData(rawData);
+    const parsed = JSON.parse(result);
+
     expect(Object.keys(parsed).length).toBe(0);
   });
 
   it('returns valid JSON string', () => {
-    const rawData = { [ESSENTIAL_ALERT_FIELDS[0]]: ['value1'] };
-    expect(JSON.parse(stringifyEssentialAlertData(rawData))).toEqual(rawData);
+    const rawData: Record<string, string[]> = {
+      [ESSENTIAL_ALERT_FIELDS[0]]: ['value1'],
+    };
+
+    const result = stringifyEssentialAlertData(rawData);
+
+    expect(() => JSON.parse(result)).not.toThrow();
+    expect(JSON.parse(result)).toEqual({
+      [ESSENTIAL_ALERT_FIELDS[0]]: ['value1'],
+    });
   });
 
   it('handles empty input', () => {
-    expect(JSON.parse(stringifyEssentialAlertData({}))).toEqual({});
+    const rawData: Record<string, string[]> = {};
+
+    const result = stringifyEssentialAlertData(rawData);
+    const parsed = JSON.parse(result);
+
+    expect(parsed).toEqual({});
   });
 });