Use browser hooks for Chrome Next state

Keep useIsNextChrome in the browser hooks package only and remove duplicate browser-components feature flag plumbing.

Author: Dosant

src/core/packages/chrome/browser-components/index.ts

@@ -21,4 +21,4 @@ export { GridLayoutProjectSideNav } from './src/project/sidenav/grid_layout_side
 export { Sidebar } from './src/sidebar';
 export { AppMenuBar } from './src/project/app_menu';
 export { HeaderBreadcrumbsBadges, HeaderTopBanner, ChromelessHeader } from './src/shared';
-export { useHasAppMenu, useHasInlineAppHeader, useIsNextChrome } from './src/shared/chrome_hooks';
+export { useHasAppMenu, useHasInlineAppHeader } from './src/shared/chrome_hooks';

src/core/packages/chrome/browser-components/moon.yml

@@ -35,12 +35,9 @@ dependsOn:
   - '@kbn/core-chrome-layout-constants'
   - '@kbn/core-chrome-sidebar-components'
   - '@kbn/ui-side-navigation'
-  - '@kbn/core-chrome-feature-flags'
   - '@kbn/core-custom-branding-browser'
   - '@kbn/core-custom-branding-common'
   - '@kbn/core-doc-links-browser'
-  - '@kbn/core-feature-flags-browser'
-  - '@kbn/core-feature-flags-browser-mocks'
   - '@kbn/core-doc-links-browser-mocks'
   - '@kbn/core-http-browser'
   - '@kbn/core-http-browser-mocks'

src/core/packages/chrome/browser-components/src/context.tsx

@@ -13,7 +13,6 @@ import type { InternalApplicationStart } from '@kbn/core-application-browser-int
 import type { DocLinksStart } from '@kbn/core-doc-links-browser';
 import type { HttpStart } from '@kbn/core-http-browser';
 import type { CustomBrandingStart } from '@kbn/core-custom-branding-browser';
-import type { FeatureFlagsStart } from '@kbn/core-feature-flags-browser';
 
 export interface ChromeComponentsDeps {
   application: Pick<
@@ -23,7 +22,6 @@ export interface ChromeComponentsDeps {
   http: Pick<HttpStart, 'basePath' | 'getLoadingCount$'>;
   docLinks: DocLinksStart;
   customBranding: Pick<CustomBrandingStart, 'customBranding$'>;
-  featureFlags: Pick<FeatureFlagsStart, 'getBooleanValue' | 'getBooleanValue$'>;
 }
 
 const ChromeComponentsContext = createContext<ChromeComponentsDeps | null>(null);

src/core/packages/chrome/browser-components/src/shared/chrome_hooks.ts

@@ -26,7 +26,6 @@ import type { DocLinksStart } from '@kbn/core-doc-links-browser';
 import type { CustomBranding } from '@kbn/core-custom-branding-common';
 import { useObservable } from '@kbn/use-observable';
 import { useChromeService } from '@kbn/core-chrome-browser-context';
-import { isNextChrome } from '@kbn/core-chrome-feature-flags';
 import { useChromeComponentsDeps } from '../context';
 
 /**
@@ -284,12 +283,6 @@ export function useGlobalSearch(): GlobalSearchConfig | undefined {
   return useObservable(config$, undefined);
 }
 
-/** Returns whether the next-chrome experience is enabled via feature flag. */
-export function useIsNextChrome(): boolean {
-  const { featureFlags } = useChromeComponentsDeps();
-  return isNextChrome(featureFlags);
-}
-
 /** Whether an inline `AppHeader` is currently mounted by the active app. */
 export function useHasInlineAppHeader(): boolean {
   const chrome = useChromeService();

src/core/packages/chrome/browser-components/src/test_helpers.tsx

@@ -15,7 +15,6 @@ import { applicationServiceMock } from '@kbn/core-application-browser-mocks';
 import { docLinksServiceMock } from '@kbn/core-doc-links-browser-mocks';
 import { chromeServiceMock } from '@kbn/core-chrome-browser-mocks';
 import { coreContextMock } from '@kbn/core-base-browser-mocks';
-import { coreFeatureFlagsMock } from '@kbn/core-feature-flags-browser-mocks';
 import { ChromeServiceProvider } from '@kbn/core-chrome-browser-context';
 import { CoreEnvContextProvider } from '@kbn/react-kibana-context-env';
 import type { InternalChromeStart } from '@kbn/core-chrome-browser-internal-types';
@@ -39,7 +38,6 @@ export const createMockChromeComponentsDeps = () => {
     customBranding: {
       customBranding$: new BehaviorSubject<CustomBranding>({}),
     },
-    featureFlags: coreFeatureFlagsMock.createStart(),
   } satisfies ChromeComponentsDeps;
 };
 

src/core/packages/chrome/browser-components/tsconfig.json

@@ -35,12 +35,9 @@
     "@kbn/core-chrome-layout-constants",
     "@kbn/core-chrome-sidebar-components",
     "@kbn/ui-side-navigation",
-    "@kbn/core-chrome-feature-flags",
     "@kbn/core-custom-branding-browser",
     "@kbn/core-custom-branding-common",
     "@kbn/core-doc-links-browser",
-    "@kbn/core-feature-flags-browser",
-    "@kbn/core-feature-flags-browser-mocks",
     "@kbn/core-doc-links-browser-mocks",
     "@kbn/core-http-browser",
     "@kbn/core-http-browser-mocks",

src/core/packages/chrome/browser-internal/src/chrome_service.test.tsx

@@ -247,7 +247,6 @@ describe('start', () => {
       http: startDeps.http,
       docLinks: startDeps.docLinks,
       customBranding: startDeps.customBranding,
-      featureFlags: startDeps.featureFlags,
     });
 
     it('ClassicHeader renders within ChromeComponentsProvider', async () => {

src/core/packages/chrome/layout/core-chrome-layout/layouts/grid/grid_layout.tsx

@@ -101,7 +101,6 @@ export class GridLayout implements LayoutService {
       http,
       docLinks,
       customBranding,
-      featureFlags,
     };
 
     const GridLayoutContent = React.memo(() => {