Skip to content

Commit 765ff68

Browse files
committed
Merge branch 'main' of github.com:elastic/kibana into feature/chrome-next
2 parents f7009e1 + 3484d10 commit 765ff68

1,683 files changed

Lines changed: 55515 additions & 23847 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.agents/skills/evals-write-spec/SKILL.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ evaluate.describe('Suite name', { tag: tags.serverless.observability.complete },
2424

2525
evaluate('test name', async ({ executorClient, connector }) => {
2626
await executorClient.runExperiment(
27-
{ dataset, task },
27+
{ datasets: [dataset], task },
2828
evaluators
2929
);
3030
});
@@ -202,7 +202,7 @@ export function createEvaluateDataset({
202202
return async ({ dataset }) => {
203203
await executorClient.runExperiment(
204204
{
205-
dataset,
205+
datasets: [dataset],
206206
task: async ({ input }) => {
207207
const response = await chatClient.converse({ messages: [{ message: input.question }] });
208208
return { messages: response.messages, steps: response.steps };

.agents/skills/evals-write-spec/references/evaluator-patterns.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ type MyTaskOutput = TaskOutput & {
2020
};
2121

2222
await executorClient.runExperiment(
23-
{ dataset, task },
23+
{ datasets: [dataset], task },
2424
selectEvaluators<MyExample, MyTaskOutput>([
2525
{
2626
name: 'NonEmptyDocuments',
@@ -246,7 +246,7 @@ A common pattern passes both CODE and LLM evaluators to `runExperiment`:
246246

247247
```ts
248248
await executorClient.runExperiment(
249-
{ dataset, task },
249+
{ datasets: [dataset], task },
250250
[
251251
createCriteriaEvaluator({ evaluators }),
252252
createToolCallsEvaluator({ evaluators }),

.agents/skills/flaky-test-investigator/SKILL.md

Lines changed: 2 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,6 @@ For every failure, try to retrieve:
4242
- **Server logs** (`kibana.log`, `elasticsearch.log` when present). Cross-reference the failure timestamp with any errors in the logs — a server-side 500 or unexpected warning is strong evidence the failure is a product bug, not a test bug.
4343
- **Full session trace** when the framework supports it (Scout / Playwright). Lets you scrub through every step, locator query, network call, and DOM snapshot.
4444

45-
How to actually find and download each artifact type is framework-specific — see "Retrieve failure artifacts" below.
46-
4745
Things to specifically check in the artifacts before forming a root-cause hypothesis:
4846

4947
- **Did the expected element render at all?** If yes and the selector missed it → flaky selector (Tier 2 fix territory). If no → real rendering / race / data issue (Tier 1 territory).
@@ -53,27 +51,9 @@ Things to specifically check in the artifacts before forming a root-cause hypoth
5351

5452
If artifacts are not available (expired, not uploaded, no `read_artifacts` token), say so in the report rather than fabricating a hypothesis. "Screenshot would have resolved this; not available" is a valid open question.
5553

56-
### Retrieve failure artifacts
57-
58-
The standard recipe is **list → filter by path → download by ID**, always scoped to the failed job's UUID. Two Buildkite gotchas to know about first:
59-
60-
- **Failed-attempt jobs are hidden by default.** `/builds/<n>` returns only the latest attempt; append `?include_retried_jobs=true` to find the original failing job (the one cited in `failed-test` comments). `retried` and `retried_in_job_id` link the two.
61-
- **Per-job artifacts use a different endpoint than build-wide artifacts.** If a build retried to green, failure artifacts only live on the failed job's listing (`bk artifacts list <build> -p <pipeline> --job-uuid <jobId>`). Don't conclude "no screenshot uploaded" until you've checked there.
62-
63-
**Scout** (`@kbn/scout-reporting`, not standard Playwright output — `playwright-report/`, `trace.zip`, and video are NOT published):
64-
65-
- `.scout/reports/scout-playwright-test-failures-<runId>/test-failures-summary.json` — maps test name → HTML report. Start here.
66-
- `.scout/reports/scout-playwright-test-failures-<runId>/<testId>.html` — self-contained: error, stdout, embedded screenshot. Usually sufficient on its own.
67-
- `.scout/reports/scout-playwright-test-failures-<runId>/scout-failures-<runId>.ndjson` — one record per failure (`id` = `<testId>`, `owner`, `location`, `error.*`) for programmatic use.
68-
- `**/.scout/test-artifacts/<test-slug>/test-failed-<N>.png` — plain Playwright screenshot; the PNG doesn't carry `<testId>`, so correlate via spec path.
69-
70-
**FTR** (a single content `<hash>` links every artifact for one failure):
71-
72-
- `target/test_failures/<jobId>_<hash>.{json,log,html}``.json` is source of truth; full Kibana/ES stdout lives in `system-out` (there is no separate `kibana.log`). Pull this first.
73-
- `<test-root>/screenshots/failure/*-<hash>.png` and `<test-root>/failure_debug/html/*-<hash>.html` — UI tests only; fetch only when the failure is UI-side.
74-
- `.es/*.log` — transport/cluster-shaped failures.
54+
### List failure artifacts
7555

76-
`target/test_failures/` is shared with Scout; filter by `.jobName` (e.g. `FTR Configs #90` vs `Scout Lane #12`) to keep only FTR. On Cloud FTR pipelines the layout differs: one self-contained HTML per failure at `<config-path-with-underscores>-<unix-timestamp>/html/<contentHash>.html` — no `target/test_failures/`, screenshot, or DOM artifacts.
56+
`bk artifacts list <build> -p <pipeline> --job-uuid <jobId> --json` returns a JSON listing of every artifact uploaded for the failing job. Pass `--job-uuid <jobId>` for the failed attempt (without it, `bk` only returns the latest attempt and hides retried failures). If a build retried to green, failure artifacts only live on the failed job's listing; don't conclude "no screenshot" until you've scoped to the right job UUID.
7757

7858
### Understand the scope
7959

.buildkite/ftr-manifests/ftr_platform_stateful_configs.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,6 @@ enabled:
234234
- x-pack/platform/test/functional_basic/apps/transform/edit_clone/config.ts
235235
- x-pack/platform/test/functional_basic/apps/transform/creation/runtime_mappings_saved_search/config.ts
236236
- x-pack/platform/test/functional_basic/apps/transform/permissions/config.ts
237-
- x-pack/platform/test/functional_basic/apps/transform/feature_controls/config.ts
238237
- x-pack/platform/test/functional_cors/config.ts
239238
- x-pack/platform/test/functional_embedded/config.ts
240239
- x-pack/platform/test/functional_execution_context/config.ts
@@ -252,13 +251,11 @@ enabled:
252251
- x-pack/platform/test/functional/apps/aiops/config.ts
253252
- x-pack/platform/test/functional/apps/api_keys/config.ts
254253
- x-pack/platform/test/functional/apps/canvas/config.ts
255-
- x-pack/platform/test/functional/apps/cross_cluster_replication/config.ts
256254
- x-pack/platform/test/functional/apps/dashboard/group1/config.ts
257255
- x-pack/platform/test/functional/apps/dashboard/group3/config.ts
258256
- x-pack/platform/test/functional/apps/discover/group1/config.ts
259257
- x-pack/platform/test/functional/apps/discover/group2/config.ts
260258
- x-pack/platform/test/functional/apps/discover/group3/config.ts
261-
- x-pack/platform/test/functional/apps/index_lifecycle_management/config.ts
262259
- x-pack/platform/test/functional/apps/index_management/config.ts
263260
- x-pack/platform/test/functional/apps/lens/group1/config.ts
264261
- x-pack/platform/test/functional/apps/lens/group2/config.ts
@@ -287,7 +284,6 @@ enabled:
287284
- x-pack/platform/test/functional/apps/license_management/config.ts
288285
- x-pack/platform/test/functional/apps/logstash/config.ts
289286
- x-pack/platform/test/functional/apps/managed_content/config.ts
290-
- x-pack/platform/test/functional/apps/management/config.ts
291287
- x-pack/platform/test/functional/apps/maps/group1/config.ts
292288
- x-pack/platform/test/functional/apps/maps/group2/config.ts
293289
- x-pack/platform/test/functional/apps/maps/group3/config.ts
@@ -325,7 +321,6 @@ enabled:
325321
- x-pack/platform/test/functional/apps/transform/actions/config.ts
326322
- x-pack/platform/test/functional/apps/transform/edit_clone/config.ts
327323
- x-pack/platform/test/functional/apps/transform/permissions/config.ts
328-
- x-pack/platform/test/functional/apps/transform/feature_controls/config.ts
329324
- x-pack/platform/test/functional/apps/user_profiles/config.ts
330325
- x-pack/platform/test/functional/apps/visualize/config.ts
331326
- x-pack/platform/test/functional/apps/watcher/config.ts

.buildkite/scout_ci_config.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,12 @@ plugins:
1212
- cloud_security_posture
1313
- console
1414
- contentManagementExamples
15+
- cross_cluster_replication
1516
- custom_branding
1617
- dashboard
1718
- dashboard_markdown
1819
- data
20+
- data_view_editor
1921
- data_views
2022
- data_view_management
2123
- dev_tools
@@ -31,6 +33,7 @@ plugins:
3133
- graph
3234
- grokdebugger
3335
- home
36+
- index_lifecycle_management
3437
- index_management
3538
- infra
3639
- ingest_hub
@@ -39,6 +42,7 @@ plugins:
3942
- kibana_overview
4043
- lens
4144
- logstash
45+
- management
4246
- maps
4347
- ml
4448
- monitoring

.buildkite/scripts/common/setup_job_env.sh

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ EOF
130130
# Set up Kibana Evals secrets
131131
{
132132
if [[ "${KBN_EVALS:-}" =~ ^(1|true)$ ]]; then
133-
echo "KBN_EVALS was set - exposing evals connectors and ES export credentials"
133+
echo "KBN_EVALS was set - exposing evals connectors and export credentials"
134134

135135
KBN_EVALS_CONFIG_JSON="$(vault_get kbn-evals config | base64 -d)"
136136
# Validate config shape (safe; does not print secrets)
@@ -145,10 +145,6 @@ EOF
145145
export KBN_EVALS_CONFIG_B64
146146
KBN_EVALS_CONFIG_B64="$(printf '%s' "$KBN_EVALS_CONFIG_JSON" | base64)"
147147

148-
# Elasticsearch cluster for evaluation results export
149-
export EVALUATIONS_ES_URL="$(jq -r '.evaluationsEs.url // empty' <<<"$KBN_EVALS_CONFIG_JSON")"
150-
export EVALUATIONS_ES_API_KEY="$(jq -r '.evaluationsEs.apiKey // empty' <<<"$KBN_EVALS_CONFIG_JSON")"
151-
152148
# Optional: separate cluster for trace-based evaluators
153149
export TRACING_ES_URL="$(jq -r '.tracingEs.url // empty' <<<"$KBN_EVALS_CONFIG_JSON")"
154150
export TRACING_ES_API_KEY="$(jq -r '.tracingEs.apiKey // empty' <<<"$KBN_EVALS_CONFIG_JSON")"

.buildkite/scripts/steps/evals/run_suite.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ fi
1818
# The value should be the platform-level `pluginId` use-case identifier.
1919
# `@kbn/evals` defaults this to `kbn_evals`, but you can override via KBN_EVALS_TELEMETRY_PLUGIN_ID.
2020

21-
# Set a base run id from the Buildkite build. The evaluator fixture appends the
22-
# connector id to produce a unique run_id per model (e.g. bk-<build>-<connector>).
23-
# Correlation across models in the same build uses ci.buildkite.build_id which
24-
# is populated automatically from BUILDKITE_BUILD_ID in score_repository.ts.
21+
# Set a base build run ID from the Buildkite build. This is used as a seed for
22+
# generating deterministic per-task experiment IDs (not as the experiment_id itself).
23+
# Suite-run grouping in the UI uses metadata.ci.build_id which is populated
24+
# automatically from BUILDKITE_BUILD_ID in the Buildkite metadata.
2525
if [[ -z "${TEST_RUN_ID:-}" ]] && [[ -n "${BUILDKITE_BUILD_ID:-}" ]]; then
2626
export TEST_RUN_ID="bk-${BUILDKITE_BUILD_ID}"
2727
fi

.buildkite/scripts/steps/kbn_ui_publish.sh

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -96,14 +96,11 @@ if [[ "${DRY_RUN:-}" == "1" ]]; then
9696
fi
9797

9898
report_step "Fetching Artifactory credentials"
99-
# The secret is stored at `kv/ci-shared/serverless/cloud-ui/kbn-ui-artifactory-registry`,
100-
# so that engineering orgs and CIs from kibana and cloud-ui can both access it without
101-
# granting broader vault permissions.
102-
# Secret layout:
99+
# Secret layout at `secret/ci/elastic-kibana/kbn-ui-artifactory`:
103100
# registry - full npm registry URL
104101
# npm_token - auth token
105-
NPM_REGISTRY="$(vault_kv_get kv/ci-shared/serverless/cloud-ui/kbn-ui-artifactory-registry registry_url)"
106-
NPM_TOKEN="$(vault_kv_get kv/ci-shared/serverless/cloud-ui/kbn-ui-artifactory-registry npm_token)"
102+
NPM_REGISTRY="$(vault_get kbn-ui-artifactory registry)"
103+
NPM_TOKEN="$(vault_get kbn-ui-artifactory npm_token)"
107104
if [[ -z "$NPM_REGISTRY" || -z "$NPM_TOKEN" ]]; then
108105
echo "ERROR: Artifactory credentials missing from vault." >&2
109106
exit 1

.eslintrc.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3002,8 +3002,8 @@ module.exports = {
30023002
'@kbn/*',
30033003
'!@kbn/i18n',
30043004
'!@kbn/i18n-react',
3005-
'!@kbn/core-chrome-layout-constants',
3006-
'!@kbn/core-chrome-layout-utils',
3005+
'!@kbn/ui-chrome-layout-constants',
3006+
'!@kbn/ui-chrome-layout-utils',
30073007
],
30083008
},
30093009
],

.github/CODEOWNERS

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,6 +350,7 @@ src/core/packages/user-profile/server-mocks @elastic/kibana-core
350350
src/core/packages/user-settings/server @elastic/kibana-security
351351
src/core/packages/user-settings/server-internal @elastic/kibana-security
352352
src/core/packages/user-settings/server-mocks @elastic/kibana-security
353+
src/core/packages/user-settings/types @elastic/kibana-security
353354
src/core/packages/user-storage/browser @elastic/appex-sharedux
354355
src/core/packages/user-storage/browser-internal @elastic/appex-sharedux
355356
src/core/packages/user-storage/browser-mocks @elastic/appex-sharedux
@@ -360,6 +361,8 @@ src/core/packages/user-storage/server-mocks @elastic/appex-sharedux
360361
src/core/test-helpers/kbn-server @elastic/kibana-core
361362
src/core/test-helpers/model-versions @elastic/kibana-core
362363
src/platform/kbn-ui/chrome-layout @elastic/appex-sharedux
364+
src/platform/kbn-ui/chrome-layout-constants @elastic/appex-sharedux
365+
src/platform/kbn-ui/chrome-layout-utils @elastic/appex-sharedux
363366
src/platform/kbn-ui/side-navigation @elastic/appex-sharedux
364367
src/platform/packages/private/analytics/utils/analytics_collection_utils @elastic/kibana-core
365368
src/platform/packages/private/dashboard/dashboard-navigation-options-common @elastic/kibana-presentation
@@ -915,7 +918,6 @@ src/platform/test/plugin_functional/plugins/core_plugin_route_timeouts @elastic/
915918
src/platform/test/plugin_functional/plugins/core_provider_plugin @elastic/kibana-core
916919
src/platform/test/plugin_functional/plugins/data_search @elastic/kibana-data-discovery
917920
src/platform/test/plugin_functional/plugins/elasticsearch_client_plugin @elastic/kibana-core
918-
src/platform/test/plugin_functional/plugins/eui_provider_dev_warning @elastic/appex-sharedux
919921
src/platform/test/plugin_functional/plugins/hardening @elastic/kibana-security
920922
src/platform/test/plugin_functional/plugins/index_patterns @elastic/kibana-data-discovery
921923
src/platform/test/plugin_functional/plugins/kbn_sample_panel_action @elastic/appex-sharedux
@@ -1189,6 +1191,7 @@ x-pack/platform/plugins/shared/inbox @elastic/security-genai-research-and-develo
11891191
x-pack/platform/plugins/shared/index_management @elastic/kibana-management
11901192
x-pack/platform/plugins/shared/inference @elastic/search-kibana
11911193
x-pack/platform/plugins/shared/inference_endpoint @elastic/search-kibana
1194+
x-pack/platform/plugins/shared/inference_workflows @elastic/search-kibana
11921195
x-pack/platform/plugins/shared/ingest_hub @elastic/obs-onboarding-team
11931196
x-pack/platform/plugins/shared/ingest_pipelines @elastic/kibana-management
11941197
x-pack/platform/plugins/shared/lens @elastic/kibana-visualizations
@@ -3405,6 +3408,8 @@ x-pack/solutions/observability/plugins/observability_shared/public/components/pr
34053408
/src/core/packages/chrome @elastic/appex-sharedux
34063409
/src/platform/kbn-ui/_tooling @elastic/appex-sharedux
34073410
/src/platform/kbn-ui/chrome-layout @elastic/appex-sharedux
3411+
/src/platform/kbn-ui/chrome-layout-constants @elastic/appex-sharedux
3412+
/src/platform/kbn-ui/chrome-layout-utils @elastic/appex-sharedux
34083413
/src/platform/kbn-ui/side-navigation @elastic/appex-sharedux
34093414
/x-pack/platform/test/serverless/api_integration/test_suites/favorites @elastic/appex-sharedux # Assigned per https://github.com/elastic/kibana/pull/200985
34103415
/src/platform/test/api_integration/apis/short_url/**/*.ts @elastic/appex-sharedux # Assigned per https://github.com/elastic/kibana/pull/200209/files#r1846654156
@@ -3539,6 +3544,7 @@ x-pack/solutions/observability/plugins/synthetics/server/saved_objects/synthetic
35393544
/src/cli/ @elastic/kibana-operations
35403545
/src/cli_keystore/ @elastic/kibana-operations
35413546
/.github/workflows/ @elastic/kibana-operations
3547+
/.github/workflows/failed-test-investigator.md @elastic/kibana-operations @elastic/appex-qa
35423548
/.github/aw/ @elastic/kibana-operations
35433549
/.buildkite/ @elastic/kibana-operations
35443550
/moon.yml @elastic/kibana-operations

0 commit comments

Comments
 (0)