Test fixes

Author: kowalczyk-krzysztof

src/platform/plugins/shared/dashboard/public/dashboard_listing/dashboard_listing.tsx

@@ -93,6 +93,7 @@ export const DashboardListing = ({
     return {
       primaryActionItem: {
         id: 'create',
+        testId: 'dashboardListingCreateButton',
         iconType: 'plus',
         label: i18n.translate('dashboard.listing.createButtonLabel', {
           defaultMessage: 'Create',

src/platform/plugins/shared/dashboard/test/scout/ui/parallel_tests/dashboard_listing_navigation.spec.ts

@@ -39,7 +39,8 @@ spaceTest.describe(
           'clicking create new dashboard button navigates to the editor',
           async () => {
             await pageObjects.dashboard.goto();
-            await page.testSubj.click('newItemButton');
+            await page.testSubj.click('dashboardListingCreateButton');
+            await page.testSubj.click('createDashboardButton');
             await expect(page.testSubj.locator('dashboardAddTopNavButton')).toBeVisible({
               timeout: 20_000,
             });
@@ -48,7 +49,7 @@ spaceTest.describe(
 
         await spaceTest.step('navigating back to listing page from a new dashboard', async () => {
           await page.goBack();
-          await expect(page.testSubj.locator('newItemButton')).toBeVisible();
+          await expect(page.testSubj.locator('dashboardListingCreateButton')).toBeVisible();
         });
       }
     );
@@ -57,7 +58,8 @@ spaceTest.describe(
       'saving a dashboard and returning to the listing page shows it',
       async ({ page, pageObjects }) => {
         await pageObjects.dashboard.goto();
-        await page.testSubj.click('newItemButton');
+        await page.testSubj.click('dashboardListingCreateButton');
+        await page.testSubj.click('createDashboardButton');
         await expect(page.testSubj.locator('dashboardAddTopNavButton')).toBeVisible({
           timeout: 20_000,
         });

src/platform/test/accessibility/apps/dashboard.ts

@@ -142,7 +142,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       await listingTable.clickDeleteSelected();
       await a11y.testAppSnapshot();
       await common.clickConfirmOnModal();
-      await listingTable.isShowingEmptyPromptCreateNewButton();
+      await dashboard.expectCreateButtonExists();
     });
   });
 }

src/platform/test/functional/page_objects/dashboard_page.ts

@@ -458,7 +458,7 @@ export class DashboardPageObject extends FtrService {
         await this.common.clickConfirmOnModal();
       }
     }
-    await this.listingTable.clickNewButton();
+    await this.clickCreatePopoverItem('createDashboardButton');
     if (expectWarning) {
       await this.testSubjects.existOrFail('dashboardCreateConfirm');
     }
@@ -473,8 +473,23 @@ export class DashboardPageObject extends FtrService {
     await this.waitForRenderComplete();
   }
 
+  public async clickCreatePopoverItem(
+    itemTestSubj: 'createDashboardButton' | 'createVisualizationButton' | 'createAnnotationButton'
+  ) {
+    await this.testSubjects.click('dashboardListingCreateButton');
+    await this.testSubjects.click(itemTestSubj);
+  }
+
   public async clickCreateDashboardPrompt() {
-    await this.testSubjects.click('newItemButton');
+    await this.clickCreatePopoverItem('createDashboardButton');
+  }
+
+  public async expectCreateButtonExists() {
+    await this.testSubjects.existOrFail('dashboardListingCreateButton');
+  }
+
+  public async expectCreateButtonMissing() {
+    await this.testSubjects.missingOrFail('dashboardListingCreateButton');
   }
 
   public async getCreateDashboardPromptExists() {

x-pack/performance/journeys_e2e/dashboard_listing_page.ts

@@ -37,7 +37,8 @@ export const journey = new Journey({
     await deletedDashboard.waitFor({ state: 'detached' });
   })
   .step('Add dashboard', async ({ page, inputDelays }) => {
-    await page.click(subj('newItemButton'));
+    await page.click(subj('dashboardListingCreateButton'));
+    await page.click(subj('createDashboardButton'));
     await page.click(subj('dashboardInteractiveSaveMenuItem'));
     await page.type(subj('savedObjectTitle'), `foobar dashboard ${uuidv4()}`, {
       delay: inputDelays.TYPING,

x-pack/platform/test/functional/apps/dashboard/group1/feature_controls/dashboard_security.ts

@@ -106,7 +106,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
         await testSubjects.existOrFail('dashboardLandingPage', {
           timeout: config.get('timeouts.waitFor'),
         });
-        await testSubjects.existOrFail('newItemButton');
+        await dashboard.expectCreateButtonExists();
       });
 
       it(`doesn't show read-only badge`, async () => {
@@ -288,7 +288,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
         await testSubjects.existOrFail('dashboardLandingPage', {
           timeout: config.get('timeouts.waitFor'),
         });
-        await testSubjects.missingOrFail('newItemButton');
+        await dashboard.expectCreateButtonMissing();
       });
 
       it(`shows read-only badge`, async () => {
@@ -396,7 +396,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
           args: navigationArgs,
         });
         await testSubjects.existOrFail('dashboardLandingPage', { timeout: 10000 });
-        await testSubjects.missingOrFail('newItemButton');
+        await dashboard.expectCreateButtonMissing();
       });
 
       it(`shows read-only badge`, async () => {

x-pack/platform/test/functional/apps/dashboard/group1/feature_controls/dashboard_spaces.ts

@@ -61,7 +61,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
         await testSubjects.existOrFail('dashboardLandingPage', {
           timeout: config.get('timeouts.waitFor'),
         });
-        await testSubjects.existOrFail('newItemButton');
+        await dashboard.expectCreateButtonExists();
       });
 
       it(`create new dashboard shows addNew button`, async () => {

x-pack/solutions/search/test/serverless/functional/test_suites/default_dataview.ts

@@ -45,7 +45,8 @@ export default function ({ getPageObject, getService }: FtrProviderContext) {
       await svlCommonNavigation.sidenav.clickLink({ deepLinkId: 'dashboards' });
       await testSubjects.existOrFail('~breadcrumb-deepLinkId-dashboards');
       await testSubjects.existOrFail('emptyListPrompt');
-      await testSubjects.click('newItemButton');
+      await testSubjects.click('dashboardListingCreateButton');
+      await testSubjects.click('createDashboardButton');
       await svlCommonNavigation.breadcrumbs.expectBreadcrumbExists({
         text: 'Editing New Dashboard',
       });