[9.4] [js-yaml to yaml migration] @elastic/obs-onboarding-team (#252349) (#271832)

kibanamachine · jeramysoucy · web-flow · commit 889a48102e03 · 2026-05-29T10:20:55.000Z
# Backport This will backport the following commits from `main` to `9.4`: - [[js-yaml to yaml migration] @elastic/obs-onboarding-team (#252349)](#252349)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>
diff --git a/src/platform/packages/shared/kbn-otel-demo/src/demos/online_boutique/manifests.ts b/src/platform/packages/shared/kbn-otel-demo/src/demos/online_boutique/manifests.ts
@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import yaml from 'js-yaml';
+import { stringify } from 'yaml';
 import type { DemoManifestGenerator, ManifestOptions } from '../../types';
 
 /**
@@ -415,6 +415,6 @@ export const onlineBoutiqueManifests: DemoManifestGenerator = {
       });
     }
 
-    return manifests.map((m) => yaml.dump(m)).join('---\n');
+    return manifests.map((m) => stringify(m)).join('---\n');
   },
 };
diff --git a/src/platform/packages/shared/kbn-otel-demo/src/demos/otel_demo/manifests.ts b/src/platform/packages/shared/kbn-otel-demo/src/demos/otel_demo/manifests.ts
@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import yaml from 'js-yaml';
+import { stringify } from 'yaml';
 import type { DemoManifestGenerator, ManifestOptions } from '../../types';
 
 import { HTTP_OTLP_SERVICES, getFlagdConfig } from './config';
@@ -470,6 +470,6 @@ export const otelDemoManifests: DemoManifestGenerator = {
       });
     }
 
-    return manifests.map((m) => yaml.dump(m)).join('---\n');
+    return manifests.map((m) => stringify(m)).join('---\n');
   },
 };
diff --git a/src/platform/packages/shared/kbn-otel-demo/src/get_kubernetes_manifests.ts b/src/platform/packages/shared/kbn-otel-demo/src/get_kubernetes_manifests.ts
@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import yaml from 'js-yaml';
+import { stringify } from 'yaml';
 
 const OTEL_DEMO_VERSION = '1.12.0';
 const NAMESPACE = 'otel-demo';
@@ -493,7 +493,7 @@ export function getKubernetesManifests(options: K8sManifestOptions): string {
     },
   });
 
-  return manifests.map((m) => yaml.dump(m)).join('---\n');
+  return manifests.map((m) => stringify(m)).join('---\n');
 }
 
 function createDeployment(opts: {
diff --git a/src/platform/packages/shared/kbn-otel-demo/src/read_kibana_config.ts b/src/platform/packages/shared/kbn-otel-demo/src/read_kibana_config.ts
@@ -10,7 +10,7 @@
 import type { ToolingLog } from '@kbn/tooling-log';
 import { unflattenObject } from '@kbn/object-utils';
 import fs from 'fs';
-import yaml from 'js-yaml';
+import { parse } from 'yaml';
 import { pickBy, identity } from 'lodash';
 import { resolve } from 'path';
 
@@ -49,7 +49,7 @@ export const readKibanaConfig = (log: ToolingLog, configPath?: string): KibanaCo
   let serverConfigValues = {};
 
   if (fs.existsSync(configPathToUse)) {
-    const loaded = (yaml.load(fs.readFileSync(configPathToUse, 'utf8')) || {}) as Record<
+    const loaded = (parse(fs.readFileSync(configPathToUse, 'utf8')) || {}) as Record<
       string,
       unknown
     >;
diff --git a/src/platform/packages/shared/kbn-otel-semantic-conventions/__tests__/generate_semconv.test.ts b/src/platform/packages/shared/kbn-otel-semantic-conventions/__tests__/generate_semconv.test.ts
@@ -9,7 +9,7 @@
 
 import * as fs from 'fs';
 import * as path from 'path';
-import * as yaml from 'js-yaml';
+import * as yaml from 'yaml';
 import { processSemconvYaml, extractFirstExample } from '../src/lib/generate_semconv';
 import type { ResolvedSemconvYaml, YamlGroup } from '../src/types/semconv_types';
 
@@ -30,7 +30,7 @@ describe('OpenTelemetry Semantic Conventions Processing', () => {
 
   const createYamlFile = (groups: YamlGroup[]) => {
     const yamlContent: ResolvedSemconvYaml = { groups };
-    fs.writeFileSync(tempYamlFile, yaml.dump(yamlContent), 'utf8');
+    fs.writeFileSync(tempYamlFile, yaml.stringify(yamlContent), 'utf8');
   };
 
   describe('Deterministic Ordering for PR Diffs', () => {
@@ -135,7 +135,7 @@ describe('OpenTelemetry Semantic Conventions Processing', () => {
     });
 
     it('handles missing groups property', () => {
-      fs.writeFileSync(tempYamlFile, yaml.dump({ notGroups: [] }), 'utf8');
+      fs.writeFileSync(tempYamlFile, yaml.stringify({ notGroups: [] }), 'utf8');
 
       expect(() => processSemconvYaml(tempYamlFile)).toThrow(
         /missing or invalid "groups" property/
diff --git a/src/platform/packages/shared/kbn-otel-semantic-conventions/src/lib/generate_semconv.ts b/src/platform/packages/shared/kbn-otel-semantic-conventions/src/lib/generate_semconv.ts
@@ -8,7 +8,7 @@
  */
 
 import * as fs from 'fs';
-import * as yaml from 'js-yaml';
+import * as yaml from 'yaml';
 import { getHardcodedMappings } from './hardcoded_mappings';
 import { sortObjectByKeys } from './sorting_utils';
 import type {
@@ -254,7 +254,7 @@ function processMetricGroups(
 function loadYamlFile(filePath: string): ResolvedSemconvYaml {
   try {
     const fileContent = fs.readFileSync(filePath, 'utf8');
-    const parsed = yaml.load(fileContent) as ResolvedSemconvYaml;
+    const parsed = yaml.parse(fileContent) as ResolvedSemconvYaml;
 
     if (!parsed || !parsed.groups || !Array.isArray(parsed.groups)) {
       throw new Error('Invalid YAML structure: missing or invalid "groups" property');
diff --git a/src/platform/packages/shared/kbn-otel-semantic-conventions/src/sort_yaml.ts b/src/platform/packages/shared/kbn-otel-semantic-conventions/src/sort_yaml.ts
@@ -8,7 +8,7 @@
  */
 
 import * as fs from 'fs';
-import * as yaml from 'js-yaml';
+import { parse, stringify } from 'yaml';
 
 interface YamlAttribute {
   name?: string;
@@ -61,7 +61,7 @@ export function sortYamlFile(inputFile: string, outputFile: string): void {
   try {
     // Read and parse the YAML file
     const yamlContent = fs.readFileSync(inputFile, 'utf8');
-    const data = yaml.load(yamlContent) as ResolvedSemconvYaml;
+    const data = parse(yamlContent) as ResolvedSemconvYaml;
 
     if (!data || !data.groups) {
       throw new Error('Invalid YAML structure: missing "groups" property');
@@ -74,11 +74,11 @@ export function sortYamlFile(inputFile: string, outputFile: string): void {
     };
 
     // Write the sorted YAML back to file
-    const sortedYaml = yaml.dump(sortedData, {
+    const sortedYaml = stringify(sortedData, {
       indent: 2,
       lineWidth: -1, // Disable line wrapping
-      noRefs: true, // Disable anchors/references
-      sortKeys: false, // We handle sorting manually for better control
+      aliasDuplicateObjects: false, // Disable anchors/references
+      sortMapEntries: false, // We handle sorting manually for better control
     });
 
     fs.writeFileSync(outputFile, sortedYaml, 'utf8');
diff --git a/x-pack/solutions/observability/plugins/observability_onboarding/server/routes/flow/route.ts b/x-pack/solutions/observability/plugins/observability_onboarding/server/routes/flow/route.ts
@@ -12,7 +12,7 @@ import {
   FleetUnauthorizedError,
   type PackageClient,
 } from '@kbn/fleet-plugin/server';
-import { dump } from 'js-yaml';
+import { stringify } from 'yaml';
 import type { PackageDataStreamTypes } from '@kbn/fleet-plugin/common/types';
 import { generateAgentConfigTar } from './generate_agent_config';
 import { createWiredStreamsRoutingProcessor } from './inject_wired_streams_routing';
@@ -508,7 +508,7 @@ async function ensureInstalledIntegrations(
         pkgName,
         pkgVersion: '1.0.0', // Custom integrations are always installed as version `1.0.0`
         title: pkgName,
-        config: dump({
+        config: stringify({
           inputs: [
             {
               id: `filestream-${pkgName}`,
