Skip to content

Commit ab0657b

Browse files
jasonrhodesclaude
andauthored
[SLO] Remove legacy feedback button from SLO (#271688)
Closes elastic/kibana-team#2852 Note: alert details feedback button referenced in the closed issue was previously removed in #266810 ## Summary Removes the legacy `FeedbackButton` components from the SLO header menu and the observability alert details page as part of the [1Feedback consolidation initiative](elastic/kibana-team#2790). All non-1Feedback widgets must be removed by the 9.5 release. - Deletes `slo/.../feedback_button.tsx` and removes its import + usage from `header_menu.tsx` #### Before (SLOs) <img width="1512" height="384" alt="Screenshot 2026-05-28 at 7 59 13 AM" src="https://github.com/user-attachments/assets/d247350e-665b-4c1f-bf3f-576ddf8d35a9" /> #### After (SLOs) <img width="1512" height="818" alt="Screenshot 2026-05-28 at 4 15 26 PM" src="https://github.com/user-attachments/assets/77685981-eda9-4ced-99f3-6d92da1ba2e5" /> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 6c6e833 commit ab0657b

6 files changed

Lines changed: 0 additions & 105 deletions

File tree

x-pack/platform/plugins/private/translations/translations/de-DE.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47448,7 +47448,6 @@
4744847448
"xpack.slo.errorRateChart.errorRateLabel": "Fehlerrate",
4744947449
"xpack.slo.eventsChartPanel.euiIcon.noResultsLabel": "keine Ergebnisse",
4745047450
"xpack.slo.extraInstanceIds.badge": "+{count, plural, one {# instance} other {# Instanzen}}",
47451-
"xpack.slo.featureFeedbackButtonLabel": "Feedback geben",
4745247451
"xpack.slo.featureRegistry.linkSloTitle": "SLOs",
4745347452
"xpack.slo.fieldSelector.all": "Alle",
4745447453
"xpack.slo.formattedConfigLabel.valid": "Es können nur gültige Formularkonfigurationen inspiziert werden.",

x-pack/platform/plugins/private/translations/translations/fr-FR.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47288,7 +47288,6 @@
4728847288
"xpack.slo.errorRateChart.errorRateLabel": "Taux d'erreur",
4728947289
"xpack.slo.eventsChartPanel.euiIcon.noResultsLabel": "aucun résultat",
4729047290
"xpack.slo.extraInstanceIds.badge": "+{count, plural, one {# instance} other {# instances}}",
47291-
"xpack.slo.featureFeedbackButtonLabel": "Fournir des commentaires",
4729247291
"xpack.slo.featureRegistry.linkSloTitle": "SLO",
4729347292
"xpack.slo.fieldSelector.all": "Tous",
4729447293
"xpack.slo.formattedConfigLabel.valid": "Seules les configurations de formulaires valides peuvent être inspectées.",

x-pack/platform/plugins/private/translations/translations/ja-JP.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47629,7 +47629,6 @@
4762947629
"xpack.slo.errorRateChart.errorRateLabel": "エラー率",
4763047630
"xpack.slo.eventsChartPanel.euiIcon.noResultsLabel": "結果なし",
4763147631
"xpack.slo.extraInstanceIds.badge": "+{count, plural, one {# instance} other {#件のインスタンス}}",
47632-
"xpack.slo.featureFeedbackButtonLabel": "フィードバックを送信",
4763347632
"xpack.slo.featureRegistry.linkSloTitle": "SLO",
4763447633
"xpack.slo.fieldSelector.all": "すべて",
4763547634
"xpack.slo.formattedConfigLabel.valid": "有効な形式の構成のみを検査できます。",

x-pack/platform/plugins/private/translations/translations/zh-CN.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47619,7 +47619,6 @@
4761947619
"xpack.slo.errorRateChart.errorRateLabel": "错误率",
4762047620
"xpack.slo.eventsChartPanel.euiIcon.noResultsLabel": "无结果",
4762147621
"xpack.slo.extraInstanceIds.badge": "+{count, plural, one {# instance} other {# 个实例}}",
47622-
"xpack.slo.featureFeedbackButtonLabel": "反馈",
4762347622
"xpack.slo.featureRegistry.linkSloTitle": "SLO",
4762447623
"xpack.slo.fieldSelector.all": "全部",
4762547624
"xpack.slo.formattedConfigLabel.valid": "只能检查有效表单配置。",

x-pack/solutions/observability/plugins/slo/public/components/header_menu/header_menu.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import { paths } from '@kbn/slo-shared-plugin/common/locators/paths';
1313
import { useKibana } from '../../hooks/use_kibana';
1414
import { usePluginContext } from '../../hooks/use_plugin_context';
1515
import { InspectorHeaderLink } from '../inspect/inspector_header_link';
16-
import { FeedbackButton } from '../../pages/slos/components/common/feedback_button';
1716

1817
export function HeaderMenu(): React.ReactElement | null {
1918
const { http, theme, docLinks } = useKibana().services;
@@ -28,7 +27,6 @@ export function HeaderMenu(): React.ReactElement | null {
2827
<EuiFlexItem>
2928
<EuiHeaderLinks gutterSize="xs">
3029
<InspectorHeaderLink />
31-
<FeedbackButton />
3230
<EuiHeaderLink
3331
color="primary"
3432
href={http.basePath.prepend('/app/observability/annotations')}

x-pack/solutions/observability/plugins/slo/public/pages/slos/components/common/feedback_button.tsx

Lines changed: 0 additions & 99 deletions
This file was deleted.

0 commit comments

Comments
 (0)