Fixes

Author: stratoula

src/platform/packages/shared/kbn-esql-language/src/commands/registry/stats/autocomplete.test.ts

@@ -29,11 +29,7 @@ import {
 } from '../../definitions/all_operators';
 import type { ICommandCallbacks } from '../types';
 import type { FunctionReturnType } from '../../definitions/types';
-import {
-  ESQL_NUMBER_TYPES,
-  FunctionDefinitionTypes,
-  ESQL_COMMON_NUMERIC_TYPES,
-} from '../../definitions/types';
+import { FunctionDefinitionTypes, ESQL_COMMON_NUMERIC_TYPES } from '../../definitions/types';
 import { findAutocompleteAstPosition } from '../../../language/shared/parse_for_autocomplete_query';
 import { setTestFunctions } from '../../definitions/utils/test_functions';
 import {
@@ -307,7 +303,7 @@ describe('STATS Autocomplete', () => {
             ...getFieldNamesByType(roundParameterTypes),
             ...getFunctionSignaturesByReturnType(
               Location.STATS_BY,
-              ESQL_NUMBER_TYPES,
+              roundParameterTypes,
               { scalar: true, grouping: true },
               undefined,
               ['round']
@@ -321,7 +317,7 @@ describe('STATS Autocomplete', () => {
             ...getFieldNamesByType(roundParameterTypes),
             ...getFunctionSignaturesByReturnType(
               Location.STATS_BY,
-              ESQL_NUMBER_TYPES,
+              roundParameterTypes,
               { scalar: true, grouping: true },
               undefined,
               ['round']

src/platform/packages/shared/kbn-esql-language/src/language/hover/helpers.ts

@@ -39,10 +39,22 @@ export const getVariablesHoverContent = (
   return buildVariablesHoverContent(usedVariablesInNode, variables);
 };
 
+const getParamNameAtOffset = (text: string, offset: number): string | undefined => {
+  let start = offset;
+  while (start > 0 && /\w/.test(text[start - 1])) start--;
+  if (start > 0 && text[start - 1] === '?') {
+    let end = offset;
+    while (end < text.length && /\w/.test(text[end])) end++;
+    return text.slice(start, end);
+  }
+  return undefined;
+};
+
 export function getPromqlHoverItem(
   root: WalkerAstNode,
   offset: number,
-  callbacks?: ESQLCallbacks
+  callbacks?: ESQLCallbacks,
+  fullText?: string
 ): { contents: Array<{ value: string }> } {
   let functionNode: PromQLFunction | undefined;
   let selectorNode: PromQLSelector | undefined;
@@ -80,6 +92,19 @@ export function getPromqlHoverItem(
     }
   }
 
+  // Fallback for params in PromQL label matchers: the PromQL parser doesn't store
+  // named params in label.value, so the Walker never visits them. Scan the raw text.
+  if (!paramNode && fullText) {
+    const paramName = getParamNameAtOffset(fullText, offset);
+    if (paramName) {
+      const variables = callbacks?.getVariables?.();
+      const variablesContent = buildVariablesHoverContent([paramName], variables);
+      if (variablesContent.length) {
+        return { contents: variablesContent };
+      }
+    }
+  }
+
   if (literalNode) {
     const hoverType = literalNode.literalType === 'time' ? 'duration' : 'scalar';
 

src/platform/packages/shared/kbn-esql-language/src/language/hover/index.ts

@@ -32,7 +32,7 @@ export async function getHoverItem(fullText: string, offset: number, callbacks?:
   const commandAtOffset = [...root.commands].reverse().find((cmd) => offset >= cmd.location.min);
 
   if (commandAtOffset?.name === 'promql') {
-    return getPromqlHoverItem(root, offset, callbacks);
+    return getPromqlHoverItem(root, offset, callbacks, fullText);
   }
 
   let containingFunction: ESQLFunction<'variadic-call'> | undefined;