Adhoc tasks run immediately. Make it explicit.

Author: sdesalas

x-pack/platform/plugins/shared/task_manager/server/task_scheduling.test.ts

@@ -1337,6 +1337,8 @@ describe('TaskScheduling', () => {
             schedule: undefined,
             traceparent: 'parent',
             enabled: true,
+            runAt: new Date(),
+            scheduledAt: new Date(),
           },
         ],
         undefined
@@ -1366,6 +1368,8 @@ describe('TaskScheduling', () => {
             schedule: undefined,
             traceparent: 'parent',
             enabled: true,
+            runAt: new Date(),
+            scheduledAt: new Date(),
           },
           {
             ...task2,
@@ -1410,6 +1414,8 @@ describe('TaskScheduling', () => {
         id: undefined,
         traceparent: 'parent',
         enabled: true,
+        runAt: new Date(),
+        scheduledAt: new Date(),
       });
 
       expect(omit(bulkSchedulePayload[1], 'runAt', 'scheduledAt')).toEqual({
@@ -1436,7 +1442,7 @@ describe('TaskScheduling', () => {
       expect(t2RunAt).toBeLessThanOrEqual(5 * 60 * 1000);
     });
 
-    test('does not jitter ad-hoc tasks at i > 0', async () => {
+    test('runs ad-hoc tasks immediately without jitter, even at i > 0', async () => {
       const taskScheduling = new TaskScheduling(taskSchedulingOpts);
       const recurringTask = {
         taskType: 'foo',
@@ -1459,13 +1465,17 @@ describe('TaskScheduling', () => {
           id: undefined,
           traceparent: 'parent',
           enabled: true,
+          runAt: new Date(),
+          scheduledAt: new Date(),
         },
         {
           ...adHocTask,
           id: undefined,
           schedule: undefined,
           traceparent: 'parent',
           enabled: true,
+          runAt: new Date(),
+          scheduledAt: new Date(),
         },
       ]);
     });

x-pack/platform/plugins/shared/task_manager/server/task_scheduling.ts

@@ -385,8 +385,8 @@ export class TaskScheduling {
 }
 
 const addJitter = (interval?: string): { runAt: Date; scheduledAt: Date } | undefined => {
-  // Adhoc tasks run immediately, no explicit date means they are set to run now inside the store.
-  if (!interval) return undefined;
+  // Adhoc tasks run immediately.
+  if (!interval) return { runAt: new Date(), scheduledAt: new Date() };
 
   const now = Date.now();
   const maximumOffsetTimestamp = now + 1000 * 60 * 5; // now + 5 minutes