Skip to content

Commit b6b21d0

Browse files
committed
fix linting issues
1 parent f875e53 commit b6b21d0

5 files changed

Lines changed: 15 additions & 13 deletions

File tree

x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_details_ui/components/change_history_table/changed_fields_badges.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,15 +37,15 @@ export const ChangedFieldsBadges = memo(function ChangedFieldsBadges({
3737

3838
return (
3939
<>
40-
{visible.map((field) => (
41-
<EuiBadge key={field} color="hollow">
40+
{visible.map((field, i) => (
41+
<EuiBadge key={field} color="hollow" tabIndex={i}>
4242
{convertFieldToDisplayName(field)}
4343
</EuiBadge>
4444
))}
4545
&nbsp;
4646
{overflowFieldNames.length > 0 && (
4747
<EuiToolTip content={`${overflowFieldNames.join(', ')}${isLargeOverflow ? ', +' : ''}`}>
48-
<EuiBadge color="hollow">{`+${overflowFieldNames.length}${
48+
<EuiBadge color="hollow" tabIndex={inlineLimit}>{`+${overflowFieldNames.length}${
4949
isLargeOverflow ? '+' : ''
5050
}`}</EuiBadge>
5151
</EuiToolTip>

x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_details_ui/components/change_history_table/rule_action_item_wrapper.tsx

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
* 2.0.
66
*/
77

8-
import React, { PropsWithChildren } from 'react';
9-
import { EuiFlexGroup, EuiFlexItem, EuiLink, EuiPanel, useEuiTheme } from '@elastic/eui';
8+
import React, { type PropsWithChildren } from 'react';
9+
import { EuiButtonEmpty, EuiFlexGroup, EuiFlexItem, EuiPanel, useEuiTheme } from '@elastic/eui';
1010
import { css } from '@emotion/react';
1111
import type { RuleHistoryItem } from '../../../../../common/api/detection_engine/rule_management';
1212
import * as i18n from './translations';
@@ -26,9 +26,9 @@ export function RuleActionItemWrapper({
2626
return (
2727
<EuiPanel
2828
hasBorder={false}
29-
paddingSize="s"
3029
css={css`
3130
background-color: ${euiTheme.colors.backgroundBaseSubdued};
31+
padding: ${euiTheme.size.xxs} ${euiTheme.size.s};
3232
`}
3333
>
3434
<EuiFlexGroup
@@ -41,12 +41,13 @@ export function RuleActionItemWrapper({
4141
<EuiFlexItem>{children}</EuiFlexItem>
4242
{onOpenDetails && (
4343
<EuiFlexItem grow={false}>
44-
<EuiLink
44+
<EuiButtonEmpty
45+
size="s"
4546
onClick={() => onOpenDetails(item)}
4647
data-test-subj={`ruleChangeHistoryViewDetails-${item.id}`}
4748
>
4849
<i18n.VIEW_DETAILS_LINK />
49-
</EuiLink>
50+
</EuiButtonEmpty>
5051
</EuiFlexItem>
5152
)}
5253
</EuiFlexGroup>

x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_details_ui/pages/rule_details/index.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -676,6 +676,7 @@ export const RuleDetailsPage = connector(
676676
{isDeleteConfirmationVisible && (
677677
<EuiConfirmModal
678678
title={ruleI18n.SINGLE_DELETE_CONFIRMATION_TITLE}
679+
aria-label={ruleI18n.SINGLE_DELETE_CONFIRMATION_TITLE}
679680
onCancel={handleDeletionCancel}
680681
onConfirm={() => handleDeletionConfirm()}
681682
confirmButtonText={ruleI18n.DELETE_CONFIRMATION_CONFIRM}

x-pack/solutions/security/plugins/security_solution/public/detections/components/rules/rule_info/rule_revision.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* 2.0.
66
*/
77

8-
import React, { memo, ReactElement } from 'react';
8+
import React, { memo, type ReactElement } from 'react';
99
import { EuiBadge, EuiHorizontalRule, EuiText, EuiToolTip } from '@elastic/eui';
1010
import { FormattedMessage } from '@kbn/i18n-react';
1111
import * as i18n from './translations';
@@ -22,7 +22,7 @@ export const RuleRevision = memo(function RuleRevision({
2222
return (
2323
<div data-test-subj={dataTestSubj}>
2424
<FormattedMessage
25-
id="xpack.securitySolution.detectionEngine.ruleDetails.version"
25+
id="xpack.securitySolution.detectionEngine.ruleDetails.revision"
2626
defaultMessage="Revision: {revision}"
2727
values={{
2828
revision: (
@@ -51,5 +51,5 @@ function RuleRevisionToolTip({ children }: RuleRevisionToolTipProps): JSX.Elemen
5151
</>
5252
);
5353

54-
return <EuiToolTip content={content} children={children} />;
54+
return <EuiToolTip content={content}>{children}</EuiToolTip>;
5555
}

x-pack/solutions/security/plugins/security_solution/public/detections/components/rules/rule_info/rule_version.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* 2.0.
66
*/
77

8-
import React, { memo, ReactElement } from 'react';
8+
import React, { memo, type ReactElement } from 'react';
99
import { EuiBadge, EuiHorizontalRule, EuiText, EuiToolTip } from '@elastic/eui';
1010
import { FormattedMessage } from '@kbn/i18n-react';
1111
import * as i18n from './translations';
@@ -51,5 +51,5 @@ function RuleVersionToolTip({ children }: RuleVersionToolTipProps): JSX.Element
5151
</>
5252
);
5353

54-
return <EuiToolTip content={content} children={children} />;
54+
return <EuiToolTip content={content}>{children}</EuiToolTip>;
5555
}

0 commit comments

Comments
 (0)