make remembering last space the default experience

Author: eokoneyo

src/core/packages/user-settings/types/index.d.ts

@@ -47,6 +47,10 @@ export interface UserSettingsData {
   contrastMode?: ContrastModeValue;
   locale?: LocaleValue;
   solutionNavOptOut?: boolean;
+  /**
+   * Whether the user wants to be redirected to the last accessed space on login.
+   * @default true
+   */
   rememberSelectedSpace?: boolean;
   /**
    * The id of the last space the user navigated into. Persisted server-side on every

x-pack/platform/plugins/shared/security/public/account_management/user_profile/user_profile.test.tsx

@@ -77,7 +77,7 @@ describe('useUserProfileForm', () => {
             "contrastMode": "system",
             "darkMode": "space_default",
             "locale": "en",
-            "rememberSelectedSpace": false,
+            "rememberSelectedSpace": true,
           },
         },
         "user": Object {

x-pack/platform/plugins/shared/security/public/account_management/user_profile/user_profile.tsx

@@ -706,7 +706,7 @@ function UserSpaceConfigEditor({ formik }: { formik: ReturnType<typeof useUserPr
       >
         <FormField
           label={
-            <EuiText id={rememberSelectedSpaceLabelId} size="s">
+            <EuiText size="s">
               <p>
                 <FormattedMessage
                   id="xpack.security.accountManagement.userProfile.rememberSelectedSpaceSwitchDescription"
@@ -716,8 +716,9 @@ function UserSpaceConfigEditor({ formik }: { formik: ReturnType<typeof useUserPr
             </EuiText>
           }
           as={EuiSwitch}
+          id={rememberSelectedSpaceLabelId}
           name="data.userSettings.rememberSelectedSpace"
-          checked={formik.values.data.userSettings.rememberSelectedSpace || false}
+          checked={formik.values.data.userSettings.rememberSelectedSpace ?? true}
           aria-describedby={rememberSelectedSpaceLabelId}
           onChange={async (e) => {
             await formik.setFieldTouched('data.userSettings.rememberSelectedSpace', true);
@@ -967,7 +968,7 @@ export function useUserProfileForm({ user, data }: UserProfileProps) {
             locale:
               data.userSettings?.locale ||
               toCanonicalLocaleId(i18n.getLocale(), getAvailableLocales()),
-            rememberSelectedSpace: data.userSettings?.rememberSelectedSpace || false,
+            rememberSelectedSpace: data.userSettings?.rememberSelectedSpace ?? true,
           },
         }
       : undefined,

x-pack/platform/plugins/shared/security/server/routes/user_profile/update.ts

@@ -59,7 +59,7 @@ const userProfileUpdateSchema = schema.object({
       ),
       locale: schema.maybe(schema.string({ maxLength: MAX_STRING_FIELD_LENGTH })),
       rememberSelectedSpace: schema.maybe(schema.boolean()),
-      lastSelectedSpaceId: schema.maybe(schema.string({ maxLength: MAX_STRING_FIELD_LENGTH })),
+      lastSelectedSpaceId: schema.nullable(schema.string({ maxLength: MAX_STRING_FIELD_LENGTH })),
     })
   ),
 });

x-pack/platform/plugins/shared/spaces/server/lib/request_interceptors/on_post_auth_interceptor.test.ts

@@ -97,7 +97,7 @@ describe('initSpacesOnPostAuthRequestInterceptor', () => {
   });
 
   describe('GET / (kibana root)', () => {
-    it('redirects to last selected space when user opted in and space is accessible', async () => {
+    it('redirects to last selected space when user explicitly opts in and space is accessible', async () => {
       getSpaceId.mockReturnValue(DEFAULT_SPACE_ID);
       getAll.mockResolvedValue([space('default'), space('foo')]);
       getCurrent.mockResolvedValue({