Skip to content

Commit c5435af

Browse files
kibanamachineCopilotalexwizp
authored
[9.3] Fix @elastic/eui/require-table-caption lint violations in drilldown manager UI (#271377) (#271440)
# Backport This will backport the following commits from `main` to `9.3`: - [Fix @elastic/eui/require-table-caption lint violations in drilldown manager UI (#271377)](#271377) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Copilot","email":"198982749+Copilot@users.noreply.github.com"},"sourceCommit":{"committedDate":"2026-05-27T12:22:43Z","message":"Fix @elastic/eui/require-table-caption lint violations in drilldown manager UI (#271377)\n\nTwo `EuiInMemoryTable` instances in the drilldown manager UI were\nmissing the required `tableCaption` prop, violating\n`@elastic/eui/require-table-caption`.\n\n### Changes\n\n- **`drilldown_template_table`** — Added `tableCaption` with i18n\nstring: *\"Drilldown templates\"*\n- **`drilldown_table`** — Added `tableCaption` with i18n string:\n*\"Drilldowns\"*\n\n```tsx\n<EuiInMemoryTable\n tableCaption={txtTableCaption}\n items={drilldowns}\n // ...\n/>\n```\n\nCaptions describe the dataset per EUI accessibility guidelines and use\n`i18n.translate` for localization.\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>","sha":"fa6e1f14d584a5fc26a2e62c3a4bbad2cb1c68ec","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Embedding","Project:Accessibility","release_note:skip","Feature:Drilldowns","💝community","backport:version","a11y:agent-pr","v9.5.0","v9.3.5","v9.4.2"],"title":"Fix @elastic/eui/require-table-caption lint violations in drilldown manager UI","number":271377,"url":"https://github.com/elastic/kibana/pull/271377","mergeCommit":{"message":"Fix @elastic/eui/require-table-caption lint violations in drilldown manager UI (#271377)\n\nTwo `EuiInMemoryTable` instances in the drilldown manager UI were\nmissing the required `tableCaption` prop, violating\n`@elastic/eui/require-table-caption`.\n\n### Changes\n\n- **`drilldown_template_table`** — Added `tableCaption` with i18n\nstring: *\"Drilldown templates\"*\n- **`drilldown_table`** — Added `tableCaption` with i18n string:\n*\"Drilldowns\"*\n\n```tsx\n<EuiInMemoryTable\n tableCaption={txtTableCaption}\n items={drilldowns}\n // ...\n/>\n```\n\nCaptions describe the dataset per EUI accessibility guidelines and use\n`i18n.translate` for localization.\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>","sha":"fa6e1f14d584a5fc26a2e62c3a4bbad2cb1c68ec"}},"sourceBranch":"main","suggestedTargetBranches":["9.3","9.4"],"targetPullRequestStates":[{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/271377","number":271377,"mergeCommit":{"message":"Fix @elastic/eui/require-table-caption lint violations in drilldown manager UI (#271377)\n\nTwo `EuiInMemoryTable` instances in the drilldown manager UI were\nmissing the required `tableCaption` prop, violating\n`@elastic/eui/require-table-caption`.\n\n### Changes\n\n- **`drilldown_template_table`** — Added `tableCaption` with i18n\nstring: *\"Drilldown templates\"*\n- **`drilldown_table`** — Added `tableCaption` with i18n string:\n*\"Drilldowns\"*\n\n```tsx\n<EuiInMemoryTable\n tableCaption={txtTableCaption}\n items={drilldowns}\n // ...\n/>\n```\n\nCaptions describe the dataset per EUI accessibility guidelines and use\n`i18n.translate` for localization.\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>","sha":"fa6e1f14d584a5fc26a2e62c3a4bbad2cb1c68ec"}},{"branch":"9.3","label":"v9.3.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.4","label":"v9.4.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
1 parent 24d4509 commit c5435af

4 files changed

Lines changed: 18 additions & 0 deletions

File tree

‎src/platform/plugins/shared/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_table/drilldown_table.tsx‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import {
1818
txtEditDrilldown,
1919
txtCloneDrilldown,
2020
txtSelectDrilldown,
21+
txtTableCaption,
2122
txtName,
2223
txtAction,
2324
txtTrigger,
@@ -144,6 +145,7 @@ export const DrilldownTable: React.FC<DrilldownTableProps> = ({
144145
itemId="id"
145146
columns={columns}
146147
responsiveBreakpoint={false}
148+
tableCaption={txtTableCaption}
147149
selection={{
148150
onSelectionChange: (selection) => {
149151
setSelectedDrilldowns(selection.map((drilldown) => drilldown.id));

‎src/platform/plugins/shared/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_table/i18n.ts‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,13 @@ export const txtDeleteDrilldowns = (count: number) =>
3838
},
3939
});
4040

41+
export const txtTableCaption = i18n.translate(
42+
'uiActionsEnhanced.components.DrilldownTable.tableCaption',
43+
{
44+
defaultMessage: 'Drilldowns',
45+
}
46+
);
47+
4148
export const txtSelectDrilldown = i18n.translate(
4249
'uiActionsEnhanced.components.DrilldownTable.selectThisDrilldownCheckboxLabel',
4350
{

‎src/platform/plugins/shared/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_template_table/drilldown_template_table.tsx‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import {
1717
txtSingleItemCopyActionLabel,
1818
txtActionColumnTitle,
1919
txtTriggerColumnTitle,
20+
txtTableCaption,
2021
} from './i18n';
2122
import { TextWithIcon } from '../text_with_icon';
2223
import { TriggerLineItem } from '../trigger_line_item';
@@ -118,6 +119,7 @@ export const DrilldownTemplateTable: React.FC<DrilldownTemplateTableProps> = ({
118119
},
119120
selectableMessage: () => txtSelectableMessage,
120121
}}
122+
tableCaption={txtTableCaption}
121123
/>
122124
<EuiSpacer />
123125
{!!onClone && !!selected.length && (

‎src/platform/plugins/shared/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_template_table/i18n.ts‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,13 @@ export const txtSingleItemCopyActionLabel = i18n.translate(
5454
}
5555
);
5656

57+
export const txtTableCaption = i18n.translate(
58+
'uiActionsEnhanced.components.DrilldownTemplateTable.tableCaption',
59+
{
60+
defaultMessage: 'Drilldown templates',
61+
}
62+
);
63+
5764
export const txtCopyButtonLabel = (count: number) =>
5865
i18n.translate('uiActionsEnhanced.components.DrilldownTemplateTable.copyButtonLabel', {
5966
defaultMessage: 'Copy ({count})',

0 commit comments

Comments
 (0)