Skip to content

Commit d99c401

Browse files
gsoldevilacursoragentdavismcphee
authored
Use uuid matchers in search MV13 rollback fixtures (#271196)
## Summary - Updates the `search` rollback fixtures for model version 13 (`10.13.0.json`) to use `{ "$match": "uuid" }` for Discover session tab IDs instead of hardcoded UUIDs. - MV13 tab IDs are generated via `uuidv5(savedObjectId, …)` during migration, but rollback tests bulk-create documents without fixed IDs, so the tab ID changes on every CI run and caused false fixture mismatches on unrelated PRs. - Adds a **Saved object fixtures** section to `.github/CODEOWNERS`, assigning each `__fixtures__/<type>/` folder to the team that owns the corresponding registered SO type (derived from the registering plugin's `kibana.jsonc` owner or more specific CODEOWNERS paths). ## Test plan - [x] `node scripts/check_changes.ts` - [ ] CI: **Check changes in Saved Objects** rollback tests for `search` pass when MV13 is in scope --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Davis McPhee <davismcphee@hotmail.com>
1 parent 44d78cb commit d99c401

2 files changed

Lines changed: 42 additions & 2 deletions

File tree

.github/CODEOWNERS

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1407,6 +1407,46 @@ src/platform/plugins/private/ftr_apis/server/routes/task_manager @elastic/respon
14071407
x-pack/platform/test/serverless/api_integration/test_suites/platform_security @elastic/kibana-security
14081408
/src/platform/test/functional/apps/management @elastic/kibana-management
14091409

1410+
# Saved object fixtures
1411+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/action @elastic/response-ops
1412+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/alert @elastic/response-ops
1413+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/alerting_action_policy @elastic/rna-project-team
1414+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/alerting_rule_template @elastic/response-ops
1415+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/api_key_pending_invalidation @elastic/response-ops
1416+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/api_key_to_invalidate @elastic/response-ops
1417+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/cases @elastic/kibana-cases
1418+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/connector_token @elastic/response-ops
1419+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/data_connector @elastic/kibana-core
1420+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/data_stream-config @elastic/integration-experience
1421+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/entity-analytics-monitoring-entity-source @elastic/security-entity-analytics
1422+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/entity-engine-descriptor-v2 @elastic/core-analysis
1423+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/entity-store-global-state @elastic/core-analysis
1424+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/epm-packages @elastic/fleet
1425+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/fleet-agent-policies @elastic/fleet
1426+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/fleet-cloud-connector @elastic/fleet
1427+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/fleet-package-policies @elastic/fleet
1428+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/gap_auto_fill_scheduler @elastic/response-ops
1429+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/ingest-agent-policies @elastic/fleet
1430+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/ingest-outputs @elastic/fleet
1431+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/ingest-package-policies @elastic/fleet
1432+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/ingest_manager_settings @elastic/fleet
1433+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/integration-config @elastic/integration-experience
1434+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/maintenance-window @elastic/response-ops
1435+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/markdown @elastic/kibana-presentation
1436+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/old-type-no-migrations @elastic/kibana-core
1437+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/old-type-with-migrations @elastic/kibana-core
1438+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/osquery-pack @elastic/security-defend-workflows
1439+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/osquery-saved-query @elastic/security-defend-workflows
1440+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/person-so-type @elastic/kibana-core
1441+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/product-doc-install-status @elastic/appex-ai-infra
1442+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/search @elastic/kibana-data-discovery
1443+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/search-session @elastic/kibana-data-discovery
1444+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/security-rule @elastic/security-detection-rule-management
1445+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/stream-prompts @elastic/obs-onboarding-team @elastic/obs-sig-events-team
1446+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/task @elastic/response-ops
1447+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/uiam_api_keys_provisioning_status @elastic/response-ops
1448+
/packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/watchlist-entity-source @elastic/security-entity-analytics
1449+
14101450
# Data Discovery
14111451
/x-pack/platform/test/api_integration/services/data_view_api.ts @elastic/kibana-data-discovery
14121452
/src/platform/test/functional/page_objects/unified_field_list.ts @elastic/kibana-data-discovery

packages/kbn-check-saved-objects-cli/src/migrations/__fixtures__/search/10.13.0.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
"description": "Fixture saved search used for modelVersion migration checks",
5656
"tabs": [
5757
{
58-
"id": "ed668b76-545d-5729-94c1-2eabade8ae48",
58+
"id": { "$match": "uuid" },
5959
"label": "Untitled",
6060
"attributes": {
6161
"columns": ["@timestamp", "message"],
@@ -96,7 +96,7 @@
9696
"description": "",
9797
"tabs": [
9898
{
99-
"id": "8a7dda1f-2493-44dd-a0e9-7c6557d02f3a",
99+
"id": { "$match": "uuid" },
100100
"label": "Untitled",
101101
"attributes": {
102102
"columns": [],

0 commit comments

Comments
 (0)