Merge branch 'main' into fix-ms-defender-runscript-slow-tests

Author: szwarckonrad

docs/release-notes/index.md

@@ -299,6 +299,7 @@ For the Elastic Security 9.4.0 release information, refer to [Elastic Security S
 ### Fixes [kibana-9.4.0-fixes]
 
 **Alerting**:
+* Fixes an issue where Stack alerts sent recovery notifications but remained `active` in {{kib}} instead of transitioning to `recovered` [#261012]({{kib-pull}}261012).
 * Fixes stale `uiamApiKey` leaking through object spread in rule updates [#263887]({{kib-pull}}263887).
 * Fixes OpenAPI alerting rule params schemas missing accepted keys for burn-rate windows and Elasticsearch query `sourceFields` [#263634]({{kib-pull}}263634).
 * Fixes an index template update failing due to system-managed fields [#262534]({{kib-pull}}262534).
@@ -573,6 +574,7 @@ For the Elastic Security 9.3.4 release information, refer to [Elastic Security R
 ### Fixes [kibana-9.3.4-fixes]
 
 **Alerting**:
+* Fixes an issue where Stack alerts sent recovery notifications but remained `active` in {{kib}} instead of transitioning to `recovered` [#261012]({{kib-pull}}261012).
 * Adds the `application/x-zip-compressed` MIME type as an accepted value for case file attachments [#262414]({{kib-pull}}262414).
 * Fixes the "Failed to check if maintenance windows are active" error [#261048]({{kib-pull}}261048).
 

docs/release-notes/known-issues.md

@@ -8,6 +8,25 @@ For Elastic {{observability}} known issues, refer to [Elastic Observability know
 
 For Elastic Security known issues, refer to [Elastic Security known issues](docs-content://release-notes/elastic-security/known-issues.md).
 
+::::{dropdown} Stack alerts remain active instead of transitioning to recovered
+
+Applies to: {{stack}} 9.2.7, 9.2.8, 9.3.2, 9.3.3
+
+**Details**
+
+Some Stack alerts send recovery notifications (for example, Slack, email, or webhook) but remain `active` in {{kib}} instead of transitioning to `recovered`.
+
+**Action**
+
+Manually untrack stale alerts or upgrade to {{stack}} 9.3.4 or 9.4.0.
+
+**Resolved**
+
+This issue is resolved in {{stack}} 9.3.4 and 9.4.0.
+
+::::
+
+
 ::::{dropdown} Dashboards with controls might fail to open
 
 Applies to: {{stack}} 9.4.0

packages/kbn-optimizer/limits.yml

@@ -44,7 +44,7 @@ pageLoadAssetSize:
   dataViewManagement: 6250
   dataViews: 66000
   dataVisualizer: 32727
-  developerToolbar: 4467
+  developerToolbar: 5000
   devTools: 8109
   discover: 30501
   discoverEnhanced: 5353
@@ -211,6 +211,6 @@ pageLoadAssetSize:
   visualizationListing: 5148
   visualizations: 52210
   watcher: 10485
-  workflowsExtensions: 38894
+  workflowsExtensions: 38938
   workflowsManagement: 35010
   workplaceAIApp: 6234

src/core/packages/chrome/feature-flags/README.md

@@ -14,3 +14,7 @@ import { isNextChrome } from '@kbn/core-chrome-feature-flags';
 
 const nextChromeEnabled = isNextChrome(featureFlags);
 ```
+
+`NEXT_CHROME_SESSION_STORAGE_KEY` (`dev.core.chrome.next`) is used by the development toolbar
+toggle. The session override is only read after `core.chrome.next` is enabled, so it can disable
+Chrome Next locally during development but cannot enable Chrome Next when the rollout flag is off.

src/core/packages/chrome/feature-flags/chrome_next_toggle.tsx

@@ -0,0 +1,47 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the "Elastic License
+ * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side
+ * Public License v 1"; you may not use this file except in compliance with, at
+ * your election, the "Elastic License 2.0", the "GNU Affero General Public
+ * License v3.0 only", or the "Server Side Public License, v 1".
+ */
+
+import React, { useCallback } from 'react';
+import { EuiBadge, EuiToolTip } from '@elastic/eui';
+import { css } from '@emotion/react';
+import type { FeatureFlagsStart } from '@kbn/core-feature-flags-browser';
+import { isNextChrome, toggleNextChrome } from '.';
+
+const badgeStyles = css`
+  cursor: pointer;
+`;
+
+interface ChromeNextToggleProps {
+  featureFlags: Pick<FeatureFlagsStart, 'getBooleanValue'>;
+}
+
+export const ChromeNextToggle: React.FC<ChromeNextToggleProps> = ({ featureFlags }) => {
+  const isEnabled = isNextChrome(featureFlags);
+
+  const onClick = useCallback(() => {
+    toggleNextChrome(featureFlags);
+  }, [featureFlags]);
+
+  return (
+    <EuiToolTip
+      content={`Click to ${isEnabled ? 'disable' : 'enable'} Chrome Next. Page will reload.`}
+    >
+      <EuiBadge
+        color={isEnabled ? 'success' : 'danger'}
+        css={badgeStyles}
+        iconType="beaker"
+        iconSide="left"
+        onClick={onClick}
+        onClickAriaLabel="Toggle Chrome Next"
+      >
+        Chrome Next: {isEnabled ? 'ON' : 'OFF'}
+      </EuiBadge>
+    </EuiToolTip>
+  );
+};

src/core/packages/chrome/feature-flags/index.ts

@@ -10,8 +10,32 @@
 import type { FeatureFlagsStart } from '@kbn/core-feature-flags-browser';
 
 export const NEXT_CHROME_FEATURE_FLAG_KEY = 'core.chrome.next';
+export const NEXT_CHROME_SESSION_STORAGE_KEY = 'dev.core.chrome.next';
 
 type FeatureFlagsBooleanReader = Pick<FeatureFlagsStart, 'getBooleanValue'>;
 
-export const isNextChrome = (featureFlags: FeatureFlagsBooleanReader): boolean =>
+const isNextChromeFeatureFlagEnabled = (featureFlags: FeatureFlagsBooleanReader): boolean =>
   featureFlags.getBooleanValue(NEXT_CHROME_FEATURE_FLAG_KEY, false);
+
+export const isNextChrome = (featureFlags: FeatureFlagsBooleanReader): boolean => {
+  if (!isNextChromeFeatureFlagEnabled(featureFlags)) {
+    return false;
+  }
+
+  try {
+    const override = sessionStorage.getItem(NEXT_CHROME_SESSION_STORAGE_KEY);
+    return override === null ? true : override === 'true';
+  } catch {
+    return true;
+  }
+};
+
+export const toggleNextChrome = (featureFlags: FeatureFlagsBooleanReader): void => {
+  if (!isNextChromeFeatureFlagEnabled(featureFlags)) {
+    return;
+  }
+
+  const next = !isNextChrome(featureFlags);
+  sessionStorage.setItem(NEXT_CHROME_SESSION_STORAGE_KEY, String(next));
+  window.location.reload();
+};

src/platform/plugins/shared/developer_toolbar/moon.yml

@@ -24,6 +24,7 @@ dependsOn:
   - '@kbn/config-schema'
   - '@kbn/core-chrome-browser-internal-types'
   - '@kbn/measure-component'
+  - '@kbn/core-chrome-feature-flags'
 tags:
   - plugin
   - prod

src/platform/plugins/shared/developer_toolbar/public/plugin.tsx

@@ -14,6 +14,7 @@ import type { InternalChromeStart } from '@kbn/core-chrome-browser-internal-type
 
 import { BehaviorSubject } from 'rxjs';
 import type { DeveloperToolbarItemProps } from '@kbn/developer-toolbar';
+import { NEXT_CHROME_FEATURE_FLAG_KEY } from '@kbn/core-chrome-feature-flags';
 
 export type UnregisterItemFn = () => void;
 export interface DeveloperToolbarItemRegistry {
@@ -59,6 +60,16 @@ export class DeveloperToolbarPlugin
       ),
     });
 
+    if (core.featureFlags.getBooleanValue(NEXT_CHROME_FEATURE_FLAG_KEY, false)) {
+      import('@kbn/core-chrome-feature-flags/chrome_next_toggle').then(({ ChromeNextToggle }) => {
+        this.registerItem({
+          id: 'Chrome Next',
+          children: <ChromeNextToggle featureFlags={core.featureFlags} />,
+          priority: 1,
+        });
+      });
+    }
+
     return {
       registerItem: this.registerItem.bind(this),
     };

src/platform/plugins/shared/developer_toolbar/tsconfig.json

@@ -13,5 +13,6 @@
     "@kbn/config-schema",
     "@kbn/core-chrome-browser-internal-types",
     "@kbn/measure-component",
+    "@kbn/core-chrome-feature-flags",
   ]
 }

src/platform/plugins/shared/workflows_extensions/public/step_registry/step_registry.test.ts

@@ -124,6 +124,18 @@ describe('PublicStepRegistry', () => {
       expect(registry.get(stepId)).toEqual(defaultDefinition);
     });
 
+    it('should not resolve loader until whenReady is called', async () => {
+      const mockLoader = jest.fn().mockResolvedValue(defaultDefinition);
+      registry.register(mockLoader);
+
+      expect(registry.has(stepId)).toBe(false);
+      expect(mockLoader).not.toHaveBeenCalled();
+
+      await registry.whenReady();
+      expect(registry.has(stepId)).toBe(true);
+      expect(mockLoader).toHaveBeenCalled();
+    });
+
     it('should log an error and skip registration when resolved definition duplicates an existing step type ID', async () => {
       registry.register(defaultDefinition);
       const loader = () => Promise.resolve({ ...defaultDefinition, label: 'Other' });