Skip to content

Commit da88774

Browse files
[9.2] [Security Solution][Alerts] Reset selected rows when page index changes (#243729) (#244671)
# Backport This will backport the following commits from `main` to `9.2`: - [[Security Solution][Alerts] Reset selected rows when page index changes (#243729)](#243729) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nicholas Peretti","email":"nicholas.peretti@elastic.co"},"sourceCommit":{"committedDate":"2025-11-28T18:13:33Z","message":"[Security Solution][Alerts] Reset selected rows when page index changes (#243729)\n\n> [!warning]\n> **I am not sure this is the right way to fix this issue**.\n> If you are a reviewer and have a better idea, your suggestion is more\nthan welcome\n\n## Summary\n\nAddresses https://github.com/elastic/kibana/issues/243190\n\n### 🛑 The problem\n\nAs highlighted in the aforementioned issue, the selection of rows in the\nalerts table would persist when turning page.\nThis is a screen-recording of the issue:\n\n\nhttps://github.com/user-attachments/assets/a3b3444a-9253-41d1-b89b-072907c7043c\n\n### 🔍 Context\n\n- Clearing the selection after changing page is what was happening in\nprevious versions of kibana\n- I have noticed that in discovery we do not do this, but in other parts\nof kibana we do\n- I couldn't really narrow the commit that caused this to happen, so I\nhave implemented my own solution\n\n### 💡 The solution\n\nI have added a \"dependency\" to the effect that resets the selection when\nthe page size changes — I thought it was the appropriate place to do it.","sha":"cc0f9c989306b76ae7e4ef1f21d156a7a4674cd5","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting:Investigations","backport:version","v9.3.0","v8.19.8","v9.2.2","v9.1.8"],"title":"[Security Solution][Alerts] Reset selected rows when page index changes","number":243729,"url":"https://github.com/elastic/kibana/pull/243729","mergeCommit":{"message":"[Security Solution][Alerts] Reset selected rows when page index changes (#243729)\n\n> [!warning]\n> **I am not sure this is the right way to fix this issue**.\n> If you are a reviewer and have a better idea, your suggestion is more\nthan welcome\n\n## Summary\n\nAddresses https://github.com/elastic/kibana/issues/243190\n\n### 🛑 The problem\n\nAs highlighted in the aforementioned issue, the selection of rows in the\nalerts table would persist when turning page.\nThis is a screen-recording of the issue:\n\n\nhttps://github.com/user-attachments/assets/a3b3444a-9253-41d1-b89b-072907c7043c\n\n### 🔍 Context\n\n- Clearing the selection after changing page is what was happening in\nprevious versions of kibana\n- I have noticed that in discovery we do not do this, but in other parts\nof kibana we do\n- I couldn't really narrow the commit that caused this to happen, so I\nhave implemented my own solution\n\n### 💡 The solution\n\nI have added a \"dependency\" to the effect that resets the selection when\nthe page size changes — I thought it was the appropriate place to do it.","sha":"cc0f9c989306b76ae7e4ef1f21d156a7a4674cd5"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.2","9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/243729","number":243729,"mergeCommit":{"message":"[Security Solution][Alerts] Reset selected rows when page index changes (#243729)\n\n> [!warning]\n> **I am not sure this is the right way to fix this issue**.\n> If you are a reviewer and have a better idea, your suggestion is more\nthan welcome\n\n## Summary\n\nAddresses https://github.com/elastic/kibana/issues/243190\n\n### 🛑 The problem\n\nAs highlighted in the aforementioned issue, the selection of rows in the\nalerts table would persist when turning page.\nThis is a screen-recording of the issue:\n\n\nhttps://github.com/user-attachments/assets/a3b3444a-9253-41d1-b89b-072907c7043c\n\n### 🔍 Context\n\n- Clearing the selection after changing page is what was happening in\nprevious versions of kibana\n- I have noticed that in discovery we do not do this, but in other parts\nof kibana we do\n- I couldn't really narrow the commit that caused this to happen, so I\nhave implemented my own solution\n\n### 💡 The solution\n\nI have added a \"dependency\" to the effect that resets the selection when\nthe page size changes — I thought it was the appropriate place to do it.","sha":"cc0f9c989306b76ae7e4ef1f21d156a7a4674cd5"}},{"branch":"8.19","label":"v8.19.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nicholas Peretti <nicholas.peretti@elastic.co>
1 parent 404905d commit da88774

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/platform/packages/shared/response-ops/alerts-table/hooks/use_alerts_table_query_params.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ export const useAlertsTableQueryParams = ({
9494
pageSize,
9595
}
9696
);
97-
if (resetPageIndex) {
97+
if (resetPageIndex || pageIndex !== prevQueryParams.pageIndex) {
9898
// Clear any bulk actions selections when the query changes
9999
dispatchBulkAction({ action: BulkActionsVerbs.clear });
100100
}

0 commit comments

Comments
 (0)