tests

Author: petrkrejcik

x-pack/platform/plugins/shared/agent_builder/server/routes/internal/conversations.test.ts

@@ -0,0 +1,93 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+import type { IRouter } from '@kbn/core/server';
+import { kibanaResponseFactory } from '@kbn/core/server';
+import { httpServerMock, loggingSystemMock } from '@kbn/core/server/mocks';
+import { registerInternalConversationRoutes } from './conversations';
+import type { RouteDependencies } from '../types';
+import { internalApiPath } from '../../../common/constants';
+
+const MARK_READ_PATH = `${internalApiPath}/conversations/{conversation_id}/_mark_read`;
+
+describe('registerInternalConversationRoutes - _mark_read', () => {
+  let routeHandler: (ctx: any, req: any, res: any) => Promise<any>;
+  let update: jest.Mock;
+
+  const createMockContext = () => ({
+    core: Promise.resolve({}),
+    licensing: Promise.resolve({
+      license: { status: 'active', hasAtLeast: jest.fn().mockReturnValue(true) },
+    }),
+  });
+
+  const createRequest = (overrides: { params?: object; body?: object } = {}) =>
+    httpServerMock.createKibanaRequest({
+      method: 'post',
+      path: MARK_READ_PATH,
+      params: { conversation_id: 'conv-1' },
+      body: { read: true },
+      ...overrides,
+    });
+
+  beforeEach(() => {
+    jest.clearAllMocks();
+
+    update = jest.fn().mockResolvedValue({ id: 'conv-1', read: true });
+
+    const getInternalServices = jest.fn().mockReturnValue({
+      conversations: {
+        getScopedClient: jest.fn().mockResolvedValue({ update }),
+      },
+    });
+
+    const routeHandlers: Record<string, (ctx: any, req: any, res: any) => Promise<any>> = {};
+
+    const router = {
+      post: jest
+        .fn()
+        .mockImplementation(
+          (config: { path: string }, handler: (ctx: any, req: any, res: any) => Promise<any>) => {
+            routeHandlers[config.path] = handler;
+          }
+        ),
+    } as unknown as IRouter;
+
+    registerInternalConversationRoutes({
+      router,
+      getInternalServices,
+      logger: loggingSystemMock.createLogger(),
+    } as unknown as RouteDependencies);
+
+    routeHandler = routeHandlers[MARK_READ_PATH];
+  });
+
+  it('calls client.update and returns id and read on success', async () => {
+    const response = await routeHandler(
+      createMockContext() as any,
+      createRequest(),
+      kibanaResponseFactory
+    );
+
+    expect(update).toHaveBeenCalledWith({ id: 'conv-1', read: true });
+    expect(response.status).toBe(200);
+    expect(response.payload).toMatchObject({ id: 'conv-1', read: true });
+  });
+
+  it('returns 500 when the persisted read value does not match the requested value', async () => {
+    // Simulates ES returning a stale/legacy doc where `read` is undefined
+    update.mockResolvedValue({ id: 'conv-1', read: undefined });
+
+    const response = await routeHandler(
+      createMockContext() as any,
+      createRequest(),
+      kibanaResponseFactory
+    );
+
+    expect(response.status).toBe(500);
+  });
+});

x-pack/platform/plugins/shared/agent_builder/server/routes/internal/conversations.ts

@@ -65,7 +65,7 @@ export function registerInternalConversationRoutes({
       path: `${internalApiPath}/conversations/{conversation_id}/_mark_read`,
       validate: {
         params: schema.object({
-          conversation_id: schema.string(),
+          conversation_id: schema.string({ maxLength: 256 }),
         }),
         body: schema.object({
           read: schema.boolean(),

x-pack/platform/plugins/shared/agent_builder/server/services/execution/utils/conversations.test.ts

@@ -111,6 +111,8 @@ describe('conversations utils', () => {
         expect(conversationClient.update).toHaveBeenCalledWith(
           expect.objectContaining({
             rounds: [newRound],
+            read: false,
+            status: newRound.status,
           })
         );
       });
@@ -147,6 +149,8 @@ describe('conversations utils', () => {
         expect(conversationClient.update).toHaveBeenCalledWith(
           expect.objectContaining({
             rounds: [existingRound, newRound],
+            read: false,
+            status: newRound.status,
           })
         );
       });
@@ -184,6 +188,8 @@ describe('conversations utils', () => {
         expect(conversationClient.update).toHaveBeenCalledWith(
           expect.objectContaining({
             rounds: [newRound],
+            read: false,
+            status: newRound.status,
           })
         );
       });