Skip to content

Commit e82dd6b

Browse files
committed
[One Discover] [Logs UX] Show full title tooltips on resources badges and only truncate titles in summary column (#241557)
- Make the truncation configurable so that resource badges are rendered without truncation when rendered as individual columns (for Summary column, they'll truncate). - Show the hover tooltip with full titles, always. Before https://github.com/user-attachments/assets/1d296649-9967-4be8-b2e3-fcc738e46244 After https://github.com/user-attachments/assets/ebca3b16-9cc1-4f71-b9a2-b02902fd1ac9 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 4d969df) # Conflicts: # src/platform/packages/shared/kbn-discover-contextual-components/src/data_types/logs/components/cell_actions_popover.tsx # src/platform/packages/shared/kbn-discover-contextual-components/src/data_types/logs/components/summary_column/resource.tsx # src/platform/packages/shared/kbn-discover-contextual-components/src/data_types/logs/components/utils/truncate_preserve_highlight_tags.ts
1 parent 1a3f520 commit e82dd6b

2 files changed

Lines changed: 11 additions & 2 deletions

File tree

src/platform/packages/shared/kbn-discover-contextual-components/src/data_types/logs/components/cell_actions_popover.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,7 @@ export function CellActionsPopover({
161161
export interface FieldBadgeWithActionsProps
162162
extends Pick<CellActionsPopoverProps, 'onFilter' | 'property' | 'value' | 'renderValue'> {
163163
icon?: EuiBadgeProps['iconType'];
164+
truncateTitle?: boolean;
164165
}
165166

166167
interface FieldBadgeWithActionsDependencies {
@@ -177,6 +178,7 @@ export function FieldBadgeWithActions({
177178
property,
178179
renderValue,
179180
value,
181+
truncateTitle = false,
180182
}: FieldBadgeWithActionsPropsAndDependencies) {
181183
return (
182184
<CellActionsPopover
@@ -186,7 +188,7 @@ export function FieldBadgeWithActions({
186188
renderValue={renderValue}
187189
renderPopoverTrigger={({ popoverTriggerProps }) => (
188190
<EuiBadge {...popoverTriggerProps} color="hollow" iconType={icon} iconSide="left">
189-
{truncateMiddle(value)}
191+
{truncateTitle ? truncateMiddle(value) : value}
190192
</EuiBadge>
191193
)}
192194
/>

src/platform/packages/shared/kbn-discover-contextual-components/src/data_types/logs/components/summary_column/resource.tsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,14 @@ export const Resource = ({ fields, limited = false, onFilter, ...props }: Resour
2929
return (
3030
<EuiFlexGroup gutterSize="s" {...props}>
3131
{displayedFields.map(({ name, value, ResourceBadge, Icon }) => (
32-
<ResourceBadge key={name} property={name} value={value} icon={Icon} onFilter={onFilter} />
32+
<ResourceBadge
33+
key={name}
34+
property={name}
35+
value={value}
36+
icon={Icon}
37+
truncateTitle={true}
38+
onFilter={onFilter}
39+
/>
3340
))}
3441
{extraFieldsCount > 0 && (
3542
<div>

0 commit comments

Comments
 (0)