Skip to content

Commit fa6e1f1

Browse files
Copilotalexwizp
andauthored
Fix @elastic/eui/require-table-caption lint violations in drilldown manager UI (#271377)
Two `EuiInMemoryTable` instances in the drilldown manager UI were missing the required `tableCaption` prop, violating `@elastic/eui/require-table-caption`. ### Changes - **`drilldown_template_table`** — Added `tableCaption` with i18n string: *"Drilldown templates"* - **`drilldown_table`** — Added `tableCaption` with i18n string: *"Drilldowns"* ```tsx <EuiInMemoryTable tableCaption={txtTableCaption} items={drilldowns} // ... /> ``` Captions describe the dataset per EUI accessibility guidelines and use `i18n.translate` for localization. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
1 parent 7dbe7b4 commit fa6e1f1

4 files changed

Lines changed: 18 additions & 0 deletions

File tree

src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_table/drilldown_table.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import {
1818
txtEditDrilldown,
1919
txtCloneDrilldown,
2020
txtSelectDrilldown,
21+
txtTableCaption,
2122
txtName,
2223
txtAction,
2324
txtTrigger,
@@ -144,6 +145,7 @@ export const DrilldownTable: React.FC<DrilldownTableProps> = ({
144145
itemId="id"
145146
columns={columns}
146147
responsiveBreakpoint={false}
148+
tableCaption={txtTableCaption}
147149
selection={{
148150
onSelectionChange: (selection) => {
149151
setSelectedDrilldowns(selection.map((drilldown) => drilldown.id));

src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_table/i18n.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,13 @@ export const txtDeleteDrilldowns = (count: number) =>
3838
},
3939
});
4040

41+
export const txtTableCaption = i18n.translate(
42+
'embeddableApi.components.DrilldownTable.tableCaption',
43+
{
44+
defaultMessage: 'Drilldowns',
45+
}
46+
);
47+
4148
export const txtSelectDrilldown = i18n.translate(
4249
'embeddableApi.components.DrilldownTable.selectThisDrilldownCheckboxLabel',
4350
{

src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_template_table/drilldown_template_table.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import {
1717
txtSingleItemCopyActionLabel,
1818
txtActionColumnTitle,
1919
txtTriggerColumnTitle,
20+
txtTableCaption,
2021
} from './i18n';
2122
import { TextWithIcon } from '../text_with_icon';
2223
import { TriggerLineItem } from '../trigger_line_item';
@@ -117,6 +118,7 @@ export const DrilldownTemplateTable: React.FC<DrilldownTemplateTableProps> = ({
117118
},
118119
selectableMessage: () => txtSelectableMessage,
119120
}}
121+
tableCaption={txtTableCaption}
120122
/>
121123
<EuiSpacer />
122124
{!!onClone && !!selected.length && (

src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_template_table/i18n.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,13 @@ export const txtSingleItemCopyActionLabel = i18n.translate(
5454
}
5555
);
5656

57+
export const txtTableCaption = i18n.translate(
58+
'embeddableApi.components.DrilldownTemplateTable.tableCaption',
59+
{
60+
defaultMessage: 'Drilldown templates',
61+
}
62+
);
63+
5764
export const txtCopyButtonLabel = (count: number) =>
5865
i18n.translate('embeddableApi.components.DrilldownTemplateTable.copyButtonLabel', {
5966
defaultMessage: 'Copy ({count})',

0 commit comments

Comments
 (0)