More more more cleanup

Author: Heenawter

src/platform/plugins/shared/dashboard/public/dashboard_api/get_dashboard_api.test.ts

@@ -7,7 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-import { DEFAULT_DASHBOARD_STATE } from './default_dashboard_state';
+import { DEFAULT_DASHBOARD_STATE } from '../../common/default_dashboard_state';
 import { getDashboardApi } from './get_dashboard_api';
 
 describe('initializeSettingsManager', () => {

src/platform/plugins/shared/dashboard/server/api/create/create.ts

@@ -11,14 +11,12 @@ import type { RequestHandlerContext } from '@kbn/core/server';
 import type { RequestTiming } from '@kbn/core-http-server';
 import { DASHBOARD_SAVED_OBJECT_TYPE } from '../../../common/constants';
 import { transformDashboardIn } from '../transforms';
-import { getDashboardCRUResponseBody } from '../get_cru_response_body';
 import type { DashboardCreateResponseBody } from './types';
-import type { getDashboardStateSchema } from '../dashboard_state_schemas';
 import type { DashboardState } from '../types';
+import { getDashboardCRUResponseBody } from '../get_cru_response_body';
 
 export async function create(
   requestCtx: RequestHandlerContext,
-  dashboardStateSchema: ReturnType<typeof getDashboardStateSchema>,
   createBody: DashboardState,
   serverTiming?: RequestTiming,
   isDashboardAppRequest: boolean = false,

src/platform/plugins/shared/dashboard/server/api/read/read.ts

@@ -13,11 +13,9 @@ import type { DashboardSavedObjectAttributes } from '../../dashboard_saved_objec
 import { DASHBOARD_SAVED_OBJECT_TYPE } from '../../../common/constants';
 import { getDashboardCRUResponseBody } from '../get_cru_response_body';
 import type { DashboardReadResponseBody } from './types';
-import type { getDashboardStateSchema } from '../dashboard_state_schemas';
 
 export async function read(
   savedObjectsClient: SavedObjectsClientContract,
-  dashboardStateSchema: ReturnType<typeof getDashboardStateSchema>,
   id: string,
   serverTiming?: RequestTiming,
   isDashboardAppRequest: boolean = false

src/platform/plugins/shared/dashboard/server/api/transforms/out/transform_dashboard_out.ts

@@ -22,7 +22,8 @@ import { DEFAULT_DASHBOARD_STATE } from '../../../../common/default_dashboard_st
 export function transformDashboardOut(
   attributes: DashboardSavedObjectAttributes | Partial<DashboardSavedObjectAttributes>,
   references: SavedObjectReference[] | undefined,
-  isDashboardAppRequest: boolean = false
+  isDashboardAppRequest: boolean = false,
+  isReadRequest: boolean = false
 ): {
   dashboardState: DashboardState;
   warnings: Warnings;