Skip to content

Commit ff7c4e8

Browse files
[9.2] [scout][discover] adjust locator for data view link (#244670) (#244707)
# Backport This will backport the following commits from `main` to `9.2`: - [[scout][discover] adjust locator for data view link (#244670)](#244670) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2025-12-01T08:47:47Z","message":"[scout][discover] adjust locator for data view link (#244670)\n\n## Summary\n\ncloses https://github.com/elastic/kibana/issues/242488\n\nAdjusting locator based on Playwright error message: it failed to\nresolve properly locator with \"*\":\n\n```\n - waiting for locator('[data-test-subj*=\"dataView-switch-link\"]')\n 14 × locator resolved to <button type=\"button\" title=\"logstash-*\" aria-expanded=\"false\" data-test-subj=\"discover-dataView-switch-link\" aria-controls=\"i9c16f611-c16a-11f0-bb7d-e37913b192b6\" class=\"euiButtonEmpty euiFormControlButton css-1f89pwu-euiButtonDisplay-euiButtonEmpty-m-empty-text-euiFormControlButton-compressed-fullWidth\">…</button>\n - unexpected value \"logstash-*\"\n```","sha":"56e89d40c5cccdbab8c299008e960c054db05274","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","test:scout","v9.3.0"],"title":"[scout][discover] adjust locator for data view link","number":244670,"url":"https://github.com/elastic/kibana/pull/244670","mergeCommit":{"message":"[scout][discover] adjust locator for data view link (#244670)\n\n## Summary\n\ncloses https://github.com/elastic/kibana/issues/242488\n\nAdjusting locator based on Playwright error message: it failed to\nresolve properly locator with \"*\":\n\n```\n - waiting for locator('[data-test-subj*=\"dataView-switch-link\"]')\n 14 × locator resolved to <button type=\"button\" title=\"logstash-*\" aria-expanded=\"false\" data-test-subj=\"discover-dataView-switch-link\" aria-controls=\"i9c16f611-c16a-11f0-bb7d-e37913b192b6\" class=\"euiButtonEmpty euiFormControlButton css-1f89pwu-euiButtonDisplay-euiButtonEmpty-m-empty-text-euiFormControlButton-compressed-fullWidth\">…</button>\n - unexpected value \"logstash-*\"\n```","sha":"56e89d40c5cccdbab8c299008e960c054db05274"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/244670","number":244670,"mergeCommit":{"message":"[scout][discover] adjust locator for data view link (#244670)\n\n## Summary\n\ncloses https://github.com/elastic/kibana/issues/242488\n\nAdjusting locator based on Playwright error message: it failed to\nresolve properly locator with \"*\":\n\n```\n - waiting for locator('[data-test-subj*=\"dataView-switch-link\"]')\n 14 × locator resolved to <button type=\"button\" title=\"logstash-*\" aria-expanded=\"false\" data-test-subj=\"discover-dataView-switch-link\" aria-controls=\"i9c16f611-c16a-11f0-bb7d-e37913b192b6\" class=\"euiButtonEmpty euiFormControlButton css-1f89pwu-euiButtonDisplay-euiButtonEmpty-m-empty-text-euiFormControlButton-compressed-fullWidth\">…</button>\n - unexpected value \"logstash-*\"\n```","sha":"56e89d40c5cccdbab8c299008e960c054db05274"}}]}] BACKPORT--> Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co>
1 parent 2d7af22 commit ff7c4e8

2 files changed

Lines changed: 13 additions & 9 deletions

File tree

src/platform/packages/shared/kbn-scout/src/playwright/page_objects/discover_app.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,10 @@ export class DiscoverApp {
3232
await this.page.waitForLoadingIndicatorHidden();
3333
}
3434

35+
getSelectedDataView(): Locator {
36+
return this.page.testSubj.locator('discover-dataView-switch-link');
37+
}
38+
3539
async clickNewSearch() {
3640
await this.page.testSubj.hover('discoverNewButton');
3741
await this.page.testSubj.click('discoverNewButton');

x-pack/platform/plugins/private/discover_enhanced/test/scout/ui/parallel_tests/saved_searches.spec.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,6 @@ const assertNoFilterAndEmptyQuery = async (
2525
).toHaveText('');
2626
};
2727

28-
const assertDataViewIsSelected = async (page: ExtParallelRunTestFixtures['page'], name: string) =>
29-
await expect(
30-
page.testSubj.locator('*dataView-switch-link'),
31-
'Incorrect data view is selected'
32-
).toHaveText(name);
33-
3428
spaceTest.describe(
3529
'Discover app - saved searches',
3630
{ tag: ['@ess', '@svlSearch', '@svlOblt'] },
@@ -85,7 +79,9 @@ spaceTest.describe(
8579
`should unselect saved search when navigating to a 'new'`,
8680
async ({ pageObjects, page }) => {
8781
await pageObjects.discover.goto();
88-
await assertDataViewIsSelected(page, testData.DATA_VIEW_NAME.ECOMMERCE);
82+
await expect(pageObjects.discover.getSelectedDataView()).toHaveText(
83+
testData.DATA_VIEW_NAME.ECOMMERCE
84+
);
8985
await pageObjects.filterBar.addFilter({
9086
...filterFieldAndValue,
9187
operator: 'is',
@@ -113,7 +109,9 @@ spaceTest.describe(
113109

114110
// create new search
115111
await pageObjects.discover.clickNewSearch();
116-
await assertDataViewIsSelected(page, testData.DATA_VIEW_NAME.ECOMMERCE);
112+
await expect(pageObjects.discover.getSelectedDataView()).toHaveText(
113+
testData.DATA_VIEW_NAME.ECOMMERCE
114+
);
117115
await assertNoFilterAndEmptyQuery(filterFieldAndValue, pageObjects, page);
118116

119117
// change data view
@@ -126,7 +124,9 @@ spaceTest.describe(
126124

127125
// create new search again
128126
await pageObjects.discover.clickNewSearch();
129-
await assertDataViewIsSelected(page, testData.DATA_VIEW_NAME.ECOMMERCE);
127+
await expect(pageObjects.discover.getSelectedDataView()).toHaveText(
128+
testData.DATA_VIEW_NAME.ECOMMERCE
129+
);
130130
}
131131
);
132132
}

0 commit comments

Comments
 (0)