Skip to content

[Fleet] Filter non automatic upgrade failed from automatic upgrade status #240328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 24, 2025
Merged

[Fleet] Filter non automatic upgrade failed from automatic upgrade status #240328

merged 14 commits into from
Oct 24, 2025

Conversation

@nchaulet
Copy link
Member

@nchaulet nchaulet commented Oct 23, 2025 •
edited
Loading

Description

Resolve #236392

Filter non automatic upgrade from automatic upgrade,

Server change

Change the way we compute upgrade status to retrieve the related upgrade action and check if it come from an automatic upgrade (is_automatic: true)

API change

Added the failedUpgradeActionIds to the automatic upgrade status list so client side we could filter on agent failing for these actions

nchaulet and others added 6 commits October 23, 2025 10:52
@nchaulet
[Fleet] Filter non automatic upgrade failed from automatic upgrade st…
8cccac2 
…atus
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/capture_oas_snapsho…
a01c5fa 
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/streams --include-path /api/fleet --include-path /api/saved_objects/_import --include-path /api/saved_objects/_export --include-path /api/maintenance_window --include-path /api/agent_builder --update'
@kibanamachine
[CI] Auto-commit changed files from 'make api-docs'
7565f7b
@nchaulet
add unit tests
2d23b5e
@nchaulet
Merge branch 'feature-filter-non-automatic-failed-upgrade' of github.…
acebf44 
…com:elastic/kibana into feature-filter-non-automatic-failed-upgrade
@nchaulet
fix typo
5029f91
@nchaulet nchaulet self-assigned this Oct 23, 2025
@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels labels Oct 23, 2025
@nchaulet nchaulet marked this pull request as ready for review October 23, 2025 19:00
@nchaulet nchaulet requested review from a team as code owners October 23, 2025 19:00
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Oct 23, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 23, 2025

Pinging @elastic/fleet (Team:Fleet)

@nchaulet
Copy link
Member Author

nchaulet commented Oct 23, 2025

@elasticmachine merge upstream

juliaElastic
juliaElastic approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@nchaulet
Copy link
Member Author

nchaulet commented Oct 24, 2025

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 24, 2025

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 2.1MB 2.1MB +248.0B

History

cc @nchaulet

@nchaulet nchaulet merged commit 9a932c0 into main Oct 24, 2025
14 checks passed
@nchaulet nchaulet deleted the feature-filter-non-automatic-failed-upgrade branch October 24, 2025 23:25
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 27, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 27, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 240328 locally
cc: @nchaulet

5 similar comments
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 29, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 240328 locally
cc: @nchaulet

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 30, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 240328 locally
cc: @nchaulet

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 31, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 240328 locally
cc: @nchaulet

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 3, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 240328 locally
cc: @nchaulet

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 4, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 240328 locally
cc: @nchaulet

@nchaulet nchaulet added backport:skip This PR does not require backporting and removed backport:version Backport to applied version labels labels Nov 4, 2025
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliaElastic juliaElastic juliaElastic approved these changes

@mdbirnstiehl mdbirnstiehl mdbirnstiehl approved these changes

Assignees

@nchaulet nchaulet

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Fleet] Auto upgrade status shows upgrade failures from manual upgrades

6 participants

@nchaulet @elasticmachine @kibanamachine @juliaElastic @mdbirnstiehl