[ML] Move duplicate Single Metric Viewer code to single location#263155
Merged
Conversation
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
Contributor
Author
|
/ci |
alvarezmelissa87
changed the title
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
alvarezmelissa87
added
:ml
Feature:Anomaly Detection
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
⏳ Build in-progress, with failures
Failed CI StepsHistory
|
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Tested and couldn't find any regressions in the ML Single Metric Viewer or the dashboard panel. Just left a couple of comments.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
This has been updated and is ready for a final look when you get a chance. 🙏 cc @peteharverson |
peteharverson
approved these changes
May 1, 2026
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
LGTM. Gave it another test, in the ML view and for the embeddable in Dashboard and Cases.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
History
|
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #201020
This PR implements a Single Metric Viewer (SMV) / time series chart refactor: logic that used to live in two places (
timeseriesexplorer.jsandtimeseriesexplorer_embeddable_chart.js) is centralized under a newtimeseriesexplorer_chart_controllerarea so the full-page Time Series Explorer and the embeddable chart share one implementation.Details
Under the new shared module,
timeseriesexplorer_chart_controller/:load_single_metric_context_data.tssmv_host_wiring.tscontext_chart_zoom_pipeline.tsresolve_context_finish_focus_range.tsanomalies_table_data.ts,normalize_table_severity.ts,entity_partition_helpers.tssingle_metric_viewer_chart_surface.tsx,use_single_metric_viewer_chart_model.ts,partition_fields_required_callout.tsxSMV-no-split.mov
SMV-with-split.mov
SMV-tables-under.mov
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.