migrate som / ml / monitoring ui tests to scout#271394
Conversation
|
/flaky scoutConfig:x-pack/platform/plugins/shared/ml/test/scout/api/playwright.config.ts:20 |
|
/flaky scoutConfig:x-pack/platform/plugins/shared/ml/test/scout/ui/playwright.config.ts:20 |
Flaky Test Runner✅ Build triggered - kibana-flaky-test-suite-runner#12466
|
Flaky Test Runner✅ Build triggered - kibana-flaky-test-suite-runner#12467
|
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#12467[✅] x-pack/platform/plugins/shared/ml/test/scout/ui/playwright.config.ts (--arch stateful --domain classic): 20/20 tests passed. |
… into migrate-som-and-ml-ftr-to-scout
|
/flaky scoutConfig:x-pack/platform/plugins/shared/ml/test/scout/api/playwright.config.ts:20 |
Flaky Test Runner✅ Build triggered - kibana-flaky-test-suite-runner#12471
|
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#12471[❌] x-pack/platform/plugins/shared/ml/test/scout/api/playwright.config.ts (--arch stateful --domain classic): 0/20 tests passed. |
|
/flaky scoutConfig:x-pack/platform/plugins/shared/ml/test/scout/api/playwright.config.ts:20 |
Flaky Test Runner✅ Build triggered - kibana-flaky-test-suite-runner#12476
|
|
|
||
| import { tags } from '@kbn/scout'; | ||
| import { expect } from '@kbn/scout/api'; | ||
| import { apiTest, COMMON_HEADERS, CUSTOM_ROLES } from '../fixtures'; |
There was a problem hiding this comment.
Just curious, why we are exporting apiTest in ../fixtures instead of a direct import from kbn/scout?
There was a problem hiding this comment.
good point, currently we don't extend kbn/scout apiTest fixture with any custom logic, so we can important directly from kbn/scout
There was a problem hiding this comment.
No need to change for this PR, just curious. But good to know apiTest can be extended with custom logic. Is that different from mlApiTest?
There was a problem hiding this comment.
mlApiTest is the one extended for this plugin and it should be used in tests. I will push update.
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#12476[❌] x-pack/platform/plugins/shared/ml/test/scout/api/playwright.config.ts (--arch stateful --domain classic): 0/20 tests passed. |
… into migrate-som-and-ml-ftr-to-scout
pickypg
left a comment
There was a problem hiding this comment.
LG Stack Monitoring as long as it passes :)
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]
History
|
|
Starting backport for target branches: 8.19, 9.3, 9.4 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
…sts4 * commit '56de32d81a3c90f159477cdecc8914612ea45332': (27 commits) [One Workflow] Serial polling for execution UI to prevent overlapping API requests (elastic#271072) migrate som / ml / monitoring ui tests to scout (elastic#271394) Upgrade @opentelemetry/host-metrics 0.38.2 → 0.38.3 (elastic#271613) Bump fast-xml-builder to 1.2.0 (elastic#270595) remove redundant top-level after hooks from FTR suites (elastic#271312) [Entity Store] Fix before-all timeout in CSV upload FTR suite and unskip (elastic#269798) [Security Solution] Enable @kbn/change-history feature flag (elastic#270091) (fix) OBS BI - exclude rollup indices from otel telemetry collection plugin (elastic#271453) [Synthetics] All monitors errors page !! (elastic#211205) [One Workflow] managed workflows - restrict mutations (elastic#270896) [Fleet] Fix namespace index templates labels (elastic#271465) [Security solution] Remove stale GenAI ownership (elastic#271593) [kbn-ui] Move skill to proper folder (elastic#270542) [ResponseOps][Alerting V2] Response descriptions are generic and non-specific (elastic#271176) [ES|QL] Dot-prefixed sources validation (elastic#271263) [Scout] Update test config manifests (elastic#271606) [CI] Remove shallow checkout for rspack verify step (elastic#271331) [GH Workflow] Add Node Version (elastic#271578) [ResponseOps] Synchronously invalidate rule API keys on DELETE via `invalidate_api_key_now` (elastic#267556) [* as Code] Remove CM from visualize library and refactor add from library flyout (elastic#269399) ...
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
### Migration Summary 1. ML: `x-pack/platform/test/functional/apps/ml/short_tests/feature_controls` FTR file | Scout spec | Layer -- | -- | -- ml_security.ts (5 role/navlink scenarios) | x-pack/platform/plugins/shared/ml/test/scout/api/tests/feature_controls.spec.ts | API (capabilities) ml_spaces.ts (enabled space → app renders; disabled → 404) | x-pack/platform/plugins/shared/ml/test/scout/ui/tests/feature_controls.spec.ts + same API spec (per-space capabilities) | UI + API Parity: **full**. Browser-only smoke (mlAppPageOverview render + raw 404 JSON on disabled space) kept in UI; capabilities/navlink contracts moved to API. 2. Stack Monitoring: `x-pack/platform/test/functional/apps/monitoring/feature_controls` FTR file | Scout spec | Layer -- | -- | -- monitoring_security.ts (admin sees app, base:all no navlink) | x-pack/platform/plugins/private/monitoring/test/scout/ui/tests/feature_controls.spec.ts | UI monitoring_spaces.ts (enabled/disabled space) | same UI spec | UI Parity: **partial** — documented in the spec header. Migrated: monitoringAppContainer renders for admin (default + enabled space), 404 JSON in disabled space, base:all user does NOT see sidebar link. Not migrated (intentional gap): `monitoring_user` alone → forbidden and `monitoring_user + kibana_admin` → enable denied. Both require the reserved_monitoring ES application privilege, which Scout's setCustomRole cannot provision (the second case was already skipCloud in FTR). 3. Saved Objects Management: `x-pack/platform/test/functional/apps/saved_objects_management/feature_controls` FTR file | Scout spec | Layer -- | -- | -- security.ts (5 role/capability scenarios) | src/platform/plugins/shared/saved_objects_management/test/scout/api/tests/feature_controls.spec.ts | API Same file (browser-only button visibility + appNotFound routing) | src/platform/plugins/shared/saved_objects_management/test/scout/ui/tests/feature_controls.spec.ts | UI Parity: **full**. Pure capability/_find contracts at API, per-role button visibility & appNotFound routing at UI. 4. OSS Saved Objects Management: `src/platform/test/functional/apps/saved_objects_management` FTR file | Scout spec | Layer -- | -- | -- inspect_saved_objects.ts > "renders the envelope" | covered by ui/tests/spaces_integration.spec.ts + existing api/tests/bulk_get.spec.ts | UI + API inspect_saved_objects.ts > "allows to delete a saved object" | src/platform/plugins/shared/saved_objects_management/test/scout/ui/tests/inspect.spec.ts | UI (only confirm-modal flow) show_relationships.ts (invalid relationships) | covered by existing api/tests/relationships_invalid.spec.ts (no new spec needed) | API spaces_integration.ts | src/platform/plugins/shared/saved_objects_management/test/scout/ui/tests/spaces_integration.spec.ts | UI 5. x-pack SOM: `x-pack/platform/test/functional/apps/saved_objects_management` FTR file | Scout spec | Layer -- | -- | -- import_saved_objects_between_versions.ts (3 imports: 7.13, 7.14, 8.0) | API spec for counts + UI render-smoke | API + UI multi_space_import.ts (default-space + non-default-space import) | merged into same api/tests/imports.spec.ts | API Copy-to-space flow | src/platform/plugins/shared/saved_objects_management/test/scout/ui/tests/imports.spec.ts (merged with 7.13 render-smoke) | UI Parity: **full**. Import counts moved to API (no browser); browser-only checks (rendered dashboard, copy flyout summary counters) stay in UI. ### Net CI impact 2 dedicated FTR configs removed (no more per-suite server starts): - x-pack/platform/test/functional/apps/ml/short_tests no longer loads feature_controls. - x-pack/platform/test/functional/apps/monitoring/index.group1.js no longer loads feature_controls. - x-pack/platform/test/functional/apps/saved_objects_management/config.ts — entirely removed. - src/platform/test/functional/apps/saved_objects_management/config.ts — entirely removed. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Migration Summary
x-pack/platform/test/functional/apps/ml/short_tests/feature_controlsParity: full. Browser-only smoke (mlAppPageOverview render + raw 404 JSON on disabled space) kept in UI; capabilities/navlink contracts moved to API.
x-pack/platform/test/functional/apps/monitoring/feature_controlsParity: partial — documented in the spec header.
Migrated: monitoringAppContainer renders for admin (default + enabled space), 404 JSON in disabled space, base:all user does NOT see sidebar link.
Not migrated (intentional gap):
monitoring_useralone → forbidden andmonitoring_user + kibana_admin→ enable denied. Both require the reserved_monitoring ES application privilege, which Scout's setCustomRole cannot provision (the second case was already skipCloud in FTR).x-pack/platform/test/functional/apps/saved_objects_management/feature_controlsParity: full. Pure capability/_find contracts at API, per-role button visibility & appNotFound routing at UI.
src/platform/test/functional/apps/saved_objects_managementx-pack/platform/test/functional/apps/saved_objects_managementParity: full. Import counts moved to API (no browser); browser-only checks (rendered dashboard, copy flyout summary counters) stay in UI.
Net CI impact
2 dedicated FTR configs removed (no more per-suite server starts):