[AWS Onboarding] Add Services step UI by juliaElastic · Pull Request #271719 · elastic/kibana

juliaElastic · 2026-05-28T14:21:42Z

Summary

Implements the Services step in the AWS cloud onboarding wizard — the screen where users select which AWS data streams they want to ingest before proceeding to connect their account.

Services step

aws_service_matrix.ts moved to IngestHub — the matrix is the source of truth for the Services UI and belongs with the plugin that owns it. deliveryMethods entries were converted from plain strings to { method, preferred } objects so the UI can render a "preferred" indicator.
Two-column card grid — each service renders as an EuiCheckableCard showing the service name, signal type badge, and delivery method badge(s).
Search + signal-type filter — a search box (filters on service name) and a "All / Logs / Metrics" button group sit in the same toolbar row. A second row shows the selected count and "Select all" / "Deselect all" buttons.
Initial selection from defaultEnabled — only services with showInUI: true && defaultEnabled: true are pre-checked on first load; selection is persisted to session storage.
Step order changed — Services now comes before Connect, so users pick what they want to collect before authenticating.
What's missing: Required config is not yet shown in the UI, plan to add it as a separate step: https://github.com/elastic/ingest-dev/issues/7621#issuecomment-4543523755

Connect step (follow-on fixes)

Identity Federation hidden when unsupported — the "Federated Identity (Recommended)" option is removed from the auth-method selector when any selected service has identityFederationSupported !== true. Falls back to Static Keys as the default. Enabled for GuardDuty only for testing, as we expect that to be the first to be supported.

Scout UI test

A new Scout smoke test (onboarding_services_step.spec.ts) covers the services step: renders behind feature flag, default selection matches defaultEnabled, signal filter works, Select/Deselect all works, and Next is disabled with no selection.

Test plan

Navigate to the AWS onboarding flow; confirm Services step is the first step shown
Verify default-enabled services are pre-checked; cloudwatch_logs, cloudwatch_metrics, OTel entries are unchecked
Search narrows the list; signal filter shows only logs/metrics services
"Select all" checks all visible services; "Deselect all" clears them; count updates
With no identityFederationSupported services selected, the auth selector in the Connect step shows only Static keys / Temporary keys
Identity Federation reappears when a service with identityFederationSupported: true is selected
Connect step shows a skeleton while cloud connectors load, then renders the tab UI

🤖 Generated with Claude Code

Screenshots

Introduces the Services step in the AWS cloud onboarding flow, letting users pick which AWS data streams to ingest before connecting their account. Key changes: - Move aws_service_matrix from Fleet to IngestHub (source of truth lives closer to the UI that owns it); convert deliveryMethods entries to { method, preferred } objects - Replace single services_step.tsx with a services_step/ directory: ServiceRow (EuiCheckableCard), DeliveryMethodBadge (with ECF tooltip), SignalTypeBadge, ServiceConfigFields accordion - ServicesStep: two-column grid, search box, signal-type filter, Select all / Deselect all, showInUI + defaultEnabled-based initial selection - Reorder wizard steps: Services now comes before Connect so users choose services first - ConnectStep: hides Federated Identity option when none of the selected services have identityFederationSupported - AwsIdentityFederationSetup: skeleton loading while connectors fetch; fix useEffect tab initialisation to fire only once (avoids tab reset on refetch) - Add Scout UI smoke test for the Services step Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Implements the AWS onboarding Services step UI and wires selected services into the Connect step to conditionally hide Identity Federation when unsupported.

Changes:

Adds Services step UI (grid/cards, search, signal-type filter, select/deselect all, session-persisted selection defaults).
Reorders onboarding steps to place Services before Connect, and gates Identity Federation visibility based on selected services.
Adds/updates tests and matrix schema (deliveryMethods now { method, preferred }).

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
x-pack/platform/plugins/shared/ingest_hub/public/onboarding/steps.ts	Reorders steps so Services precedes Connect.
x-pack/platform/plugins/shared/ingest_hub/public/onboarding/step_components/services_step/index.tsx	Implements Services step UI, filtering, and selection controls.
x-pack/platform/plugins/shared/ingest_hub/public/onboarding/step_components/services_step/service_row.tsx	Renders each service as a selectable card row with badges.
x-pack/platform/plugins/shared/ingest_hub/public/onboarding/step_components/services_step/signal_type_badge.tsx	Adds signal-type badge component.
x-pack/platform/plugins/shared/ingest_hub/public/onboarding/step_components/services_step/delivery_method_badge.tsx	Adds delivery-method badge + tooltip + preferred styling.
x-pack/platform/plugins/shared/ingest_hub/public/onboarding/step_components/services_step.tsx	Removes previous placeholder Services step component.
x-pack/platform/plugins/shared/ingest_hub/public/onboarding/onboarding_flow_context.tsx	Persists selected service IDs in session storage with matrix-driven defaults.
x-pack/platform/plugins/shared/ingest_hub/public/onboarding/step_components/connect_step.tsx	Hides Identity Federation option when any selected service doesn’t support it.
x-pack/platform/plugins/shared/ingest_hub/public/onboarding/aws_service_matrix.ts	Moves/updates matrix schema (deliveryMethods entries, identityFederationSupported flag).
x-pack/platform/plugins/shared/ingest_hub/public/onboarding/aws_service_matrix.test.ts	Updates matrix test imports to new filename.
x-pack/platform/plugins/shared/ingest_hub/test/scout/ui/tests/onboarding_services_step.spec.ts	Adds Scout smoke coverage for Services step behaviors.
x-pack/platform/plugins/shared/fleet/public/components/cloud_connector/aws_connect_setup/index.tsx	Plumbs `showIdentityFederation` into connect setup.
x-pack/platform/plugins/shared/fleet/public/components/cloud_connector/aws_connect_setup/aws_auth_type_selector.tsx	Filters auth-type options based on `showIdentityFederation`.
x-pack/platform/plugins/shared/fleet/public/components/cloud_connector/aws_connect_setup/aws_identity_federation_setup.tsx	Adds skeleton while connectors load; refactors tab click handler.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

infra-vault-gh-plugin-prod · 2026-06-01T07:15:24Z

Pinging @elastic/fleet (Team:Fleet)

kibanamachine · 2026-06-01T10:07:52Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 60dc17d
Build duration: 63 mins

Failed CI Steps

Test Failures

[job] [logs] Scout Lane #4 - stateful-classic / default / local-stateful-classic - Entity analytics management page - Privileges - should show privileges callout and disable switch for user without risk engine privileges
[job] [logs] Scout Lane #4 - stateful-classic / default / local-stateful-classic - Entity analytics management page - Risk Score tab - should discard changes when clicking discard button
[job] [logs] Scout Lane #4 - stateful-classic / default / local-stateful-classic - Entity analytics management page - Risk Score tab - should show save bar when toggling closed alerts switch
[job] [logs] Scout Lane #4 - stateful-classic / default / local-stateful-classic - Entity analytics management page - Risk Score tab - should show save bar when toggling retain checkbox

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`ingestHub`	45	49	+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	2.8MB	2.8MB	+259.0B
`ingestHub`	2.4KB	27.9KB	+25.5KB
total			+25.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`ingestHub`	13.1KB	7.2KB	-5.9KB

Unknown metric groups

async chunk count

id	before	after	diff
`ingestHub`	1	2	+1

History

bhapas · 2026-06-01T08:44:45Z

+const TOOLTIPS: Partial<Record<DeliveryMethod, string>> = {
+  cloud_forwarder: i18n.translate(
+    'xpack.ingestHub.servicesStep.deliveryMethod.cloudForwarderTooltip',
+    { defaultMessage: 'EDOT Cloud Forwarder' }


Should we call it EDOT Cloud Forwarder? I guess we are retiring this name?

bhapas · 2026-06-01T08:46:41Z

+        label={
+          <EuiFlexGroup alignItems="center" gutterSize="m" responsive={false}>
+            <EuiFlexItem>
+              <EuiText size="s">


Do we not show Icon for the service here? along with name? Like

juliaElastic requested a review from bhapas May 28, 2026 14:22

juliaElastic added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels May 28, 2026

juliaElastic requested a review from Copilot May 28, 2026 14:28

Copilot AI reviewed May 28, 2026

View reviewed changes

kibanamachine and others added 5 commits May 28, 2026 14:34

Changes from node scripts/lint_ts_projects --fix

fdff531

Changes from node scripts/regenerate_moon_projects.js --update

56551a2

fix checks

01db0fc

fix checks

304c93f

fix review comments

99df3d4

juliaElastic marked this pull request as ready for review May 28, 2026 15:02

juliaElastic requested review from a team as code owners May 28, 2026 15:02

juliaElastic requested a review from kfirpeled May 28, 2026 15:02

Merge branch 'main' into aws-onboarding-services-step

969bfad

juliaElastic requested a review from a team as a code owner June 1, 2026 07:15

botelastic Bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jun 1, 2026

juliaElastic added 2 commits June 1, 2026 09:36

fix tests

e92de3d

fix scout tests

60dc17d

remove launch cloudformation button in static keys form

170fb0d

bhapas reviewed Jun 1, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AWS Onboarding] Add Services step UI#271719

[AWS Onboarding] Add Services step UI#271719
juliaElastic wants to merge 10 commits into
elastic:mainfrom
juliaElastic:aws-onboarding-services-step

juliaElastic commented May 28, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

infra-vault-gh-plugin-prod Bot commented Jun 1, 2026

Uh oh!

kibanamachine commented Jun 1, 2026

async chunk count

Uh oh!

bhapas Jun 1, 2026

Uh oh!

bhapas Jun 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

juliaElastic commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Services step

Connect step (follow-on fixes)

Scout UI test

Test plan

Screenshots

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

infra-vault-gh-plugin-prod Bot commented Jun 1, 2026

Uh oh!

kibanamachine commented Jun 1, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

async chunk count

History

Uh oh!

bhapas Jun 1, 2026

Choose a reason for hiding this comment

Uh oh!

bhapas Jun 1, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

juliaElastic commented May 28, 2026 •

edited

Loading