From 16ef9ac231861f7d2ff99221f000afc276bbb920 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 27 May 2026 07:36:15 +0000 Subject: [PATCH 1/4] Initial plan From 18d860147db197dd019f993e7c4ade864e51e973 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 27 May 2026 07:41:03 +0000 Subject: [PATCH 2/4] fix: add tableCaption to EuiInMemoryTable in drilldown components Adds the required `tableCaption` prop to two `EuiInMemoryTable` instances in the drilldown manager UI to fix `@elastic/eui/require-table-caption` ESLint violations for the @elastic/kibana-presentation team. --- .../components/drilldown_table/drilldown_table.tsx | 2 ++ .../components/drilldown_table/i18n.ts | 7 +++++++ .../drilldown_template_table/drilldown_template_table.tsx | 2 ++ .../components/drilldown_template_table/i18n.ts | 7 +++++++ 4 files changed, 18 insertions(+) diff --git a/src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_table/drilldown_table.tsx b/src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_table/drilldown_table.tsx index 75938e46b4077..610be65f09024 100644 --- a/src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_table/drilldown_table.tsx +++ b/src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_table/drilldown_table.tsx @@ -18,6 +18,7 @@ import { txtEditDrilldown, txtCloneDrilldown, txtSelectDrilldown, + txtTableCaption, txtName, txtAction, txtTrigger, @@ -144,6 +145,7 @@ export const DrilldownTable: React.FC = ({ itemId="id" columns={columns} responsiveBreakpoint={false} + tableCaption={txtTableCaption} selection={{ onSelectionChange: (selection) => { setSelectedDrilldowns(selection.map((drilldown) => drilldown.id)); diff --git a/src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_table/i18n.ts b/src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_table/i18n.ts index 773dc4f2decdd..31c29548f774e 100644 --- a/src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_table/i18n.ts +++ b/src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_table/i18n.ts @@ -38,6 +38,13 @@ export const txtDeleteDrilldowns = (count: number) => }, }); +export const txtTableCaption = i18n.translate( + 'embeddableApi.components.DrilldownTable.tableCaption', + { + defaultMessage: 'Drilldowns attached to this panel', + } +); + export const txtSelectDrilldown = i18n.translate( 'embeddableApi.components.DrilldownTable.selectThisDrilldownCheckboxLabel', { diff --git a/src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_template_table/drilldown_template_table.tsx b/src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_template_table/drilldown_template_table.tsx index 1030e216d8f97..38349026f0bce 100644 --- a/src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_template_table/drilldown_template_table.tsx +++ b/src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_template_table/drilldown_template_table.tsx @@ -17,6 +17,7 @@ import { txtSingleItemCopyActionLabel, txtActionColumnTitle, txtTriggerColumnTitle, + txtTableCaption, } from './i18n'; import { TextWithIcon } from '../text_with_icon'; import { TriggerLineItem } from '../trigger_line_item'; @@ -117,6 +118,7 @@ export const DrilldownTemplateTable: React.FC = ({ }, selectableMessage: () => txtSelectableMessage, }} + tableCaption={txtTableCaption} /> {!!onClone && !!selected.length && ( diff --git a/src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_template_table/i18n.ts b/src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_template_table/i18n.ts index 56371dd52a163..68dea5098ee59 100644 --- a/src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_template_table/i18n.ts +++ b/src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_template_table/i18n.ts @@ -54,6 +54,13 @@ export const txtSingleItemCopyActionLabel = i18n.translate( } ); +export const txtTableCaption = i18n.translate( + 'embeddableApi.components.DrilldownTemplateTable.tableCaption', + { + defaultMessage: 'Drilldown templates available to copy', + } +); + export const txtCopyButtonLabel = (count: number) => i18n.translate('embeddableApi.components.DrilldownTemplateTable.copyButtonLabel', { defaultMessage: 'Copy ({count})', From 8480af85da80deff3c13a2a7820d4666f67a07f0 Mon Sep 17 00:00:00 2001 From: Alexey Antonov Date: Wed, 27 May 2026 10:52:06 +0300 Subject: [PATCH 3/4] Update i18n.ts --- .../drilldown_manager_ui/components/drilldown_table/i18n.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_table/i18n.ts b/src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_table/i18n.ts index 31c29548f774e..ec14556f1b9e7 100644 --- a/src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_table/i18n.ts +++ b/src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_table/i18n.ts @@ -41,7 +41,7 @@ export const txtDeleteDrilldowns = (count: number) => export const txtTableCaption = i18n.translate( 'embeddableApi.components.DrilldownTable.tableCaption', { - defaultMessage: 'Drilldowns attached to this panel', + defaultMessage: 'Drilldowns', } ); From 21e46aaa9d7b48338b7b2208030136c54ba4164c Mon Sep 17 00:00:00 2001 From: Alexey Antonov Date: Wed, 27 May 2026 10:52:27 +0300 Subject: [PATCH 4/4] Update i18n.ts --- .../components/drilldown_template_table/i18n.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_template_table/i18n.ts b/src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_template_table/i18n.ts index 68dea5098ee59..20afbc5680795 100644 --- a/src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_template_table/i18n.ts +++ b/src/platform/plugins/shared/embeddable/public/drilldowns/drilldown_manager_ui/components/drilldown_template_table/i18n.ts @@ -57,7 +57,7 @@ export const txtSingleItemCopyActionLabel = i18n.translate( export const txtTableCaption = i18n.translate( 'embeddableApi.components.DrilldownTemplateTable.tableCaption', { - defaultMessage: 'Drilldown templates available to copy', + defaultMessage: 'Drilldown templates', } );