[APM] Add TransactionsTable, ActionsMenu, and Sparkline in @kbn/apm-ui-shared#272090
Open
iblancof wants to merge 20 commits into
Open
[APM] Add TransactionsTable, ActionsMenu, and Sparkline in @kbn/apm-ui-shared#272090iblancof wants to merge 20 commits into
iblancof wants to merge 20 commits into
Conversation
iblancof
added
release_note:skip
|
Pinging @elastic/obs-exploration-team (Team:obs-exploration) |
…s://github.com/iblancof/kibana into 271310-apm-decouple-transactionstable-from-apm
Contributor
💔 Build Failed
Failed CI StepsMetrics [docs]Module Count
Async chunks
History
cc @iblancof |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #271310
Adds three new shared components to
@kbn/apm-ui-shared:TransactionsTable,ActionsMenu, andSparkline.These components are being extracted now to support an upcoming service flyout, which needs a transactions table that can be embedded outside the existing APM page context.
No new functionality has been introduced: the shared component covers exactly the same feature set as the existing APM transactions table.
Note
Migrating the existing APM transactions table to use this shared component is tracked as a follow-up:
How to test
Start Storybook for
kbn-apm-ui-shared:shared/TransactionsTableand verify all stories render: Default, Loading, Empty, MaxCountExceeded (shows cardinality warning and triggersonSearchQueryChangeon search), WithHeaderActions, and Complete (sparklines, comparison bars, alerts badge, and actions menu).shared/ActionsMenuand verify FlatActions, GroupedActions, and WithSubPanel: the menu opens on click, navigates to the sub-panel, and closes after selecting an action.shared/Sparklineand verify line and bar variants, loading state, and the null-gap dotted-line rendering.