make the install command raise exception if some error happened

Fixes #5862

Author: Pere Urbon-Bayes

qa/rspec/commands/base.rb

@@ -4,6 +4,8 @@
 
 module ServiceTester
 
+  class InstallException < Exception; end
+
   class Base
     LOCATION="/logstash-build".freeze
     LOGSTASH_PATH="/usr/share/logstash/".freeze

qa/rspec/commands/debian.rb

@@ -22,9 +22,14 @@ def package_for(filename, base=ServiceTester::Base::LOCATION)
 
     def install(package, host=nil)
       hosts = (host.nil? ? servers : Array(host))
+      errors = []
       at(hosts, {in: :serial}) do |_|
-        sudo_exec!("dpkg -i --force-confnew #{package}")
+        cmd = sudo_exec!("dpkg -i --force-confnew #{package}")
+        if cmd.exit_status != 0
+          errors << cmd.stderr.to_s
+        end
       end
+      raise InstallException.new(errors.join("\n")) unless errors.empty?
     end
 
     def uninstall(package, host=nil)

qa/rspec/commands/redhat.rb

@@ -22,12 +22,12 @@ def package_for(filename, base=ServiceTester::Base::LOCATION)
 
     def install(package, host=nil)
       hosts  = (host.nil? ? servers : Array(host))
-      errors = {}
+      errors = []
       at(hosts, {in: :serial}) do |_host|
         cmd = sudo_exec!("yum install -y  #{package}")
-        errors[_host] = cmd.stderr unless cmd.stderr.empty?
+        errors << cmd.stderr unless cmd.stderr.empty?
       end
-      errors
+      raise InstallException.new(errors.join("\n")) unless errors.empty?
     end
 
     def uninstall(package, host=nil)

qa/rspec/commands/suse.rb

@@ -19,12 +19,12 @@ def package_for(filename, base=ServiceTester::Base::LOCATION)
 
     def install(package, host=nil)
       hosts  = (host.nil? ? servers : Array(host))
-      errors = {}
+      errors = []
       at(hosts, {in: :serial}) do |_host|
         cmd = sudo_exec!("zypper --no-gpg-checks --non-interactive install  #{package}")
-        errors[_host] = cmd.stderr unless cmd.stderr.empty?
+        errors << cmd.stderr unless cmd.stderr.empty?
       end
-      errors
+      raise InstallException.new(errors.join("\n")) unless errors.empty?
     end
 
     def uninstall(package, host=nil)