Update span enrichment to check processor.event to check if a trace is an elastic transaction

Author: isaacaflores2

enrichments/internal/elastic/span.go

@@ -746,7 +746,15 @@ func isTraceRoot(span ptrace.Span) bool {
 
 func isElasticTransaction(span ptrace.Span) bool {
 	flags := tracepb.SpanFlags(span.Flags())
+
+	// Events may have already been defined as an elastic transaction.
+	// check the processor.event value to avoid incorrectly classifying
+	// a span.
+	processorEvent, _ := span.Attributes().Get(elasticattr.ProcessorEvent)
+
 	switch {
+	case processorEvent.Str() == "transaction":
+		return true
 	case isTraceRoot(span):
 		return true
 	case (flags & tracepb.SpanFlags_SPAN_FLAGS_CONTEXT_HAS_IS_REMOTE_MASK) == 0:

enrichments/internal/elastic/span_test.go

@@ -229,6 +229,31 @@ func TestElasticTransactionEnrich(t *testing.T) {
 				elasticattr.TransactionType:                "request",
 			},
 		},
+		{
+			name: "http_status_ok_processor_event_set",
+			input: func() ptrace.Span {
+				span := getElasticTxn()
+				span.SetName("testtxn")
+				span.Attributes().PutInt(string(semconv25.HTTPStatusCodeKey), http.StatusOK)
+				span.Attributes().PutStr(elasticattr.ProcessorEvent, "transaction")
+				return span
+			}(),
+			config: config.Enabled().Transaction,
+			enrichedAttrs: map[string]any{
+				elasticattr.TimestampUs:                    startTs.AsTime().UnixMicro(),
+				elasticattr.TransactionSampled:             true,
+				elasticattr.TransactionRoot:                true,
+				elasticattr.TransactionID:                  "0100000000000000",
+				elasticattr.TransactionName:                "testtxn",
+				elasticattr.ProcessorEvent:                 "transaction",
+				elasticattr.TransactionRepresentativeCount: float64(1),
+				elasticattr.TransactionDurationUs:          expectedDuration.Microseconds(),
+				elasticattr.EventOutcome:                   "success",
+				elasticattr.SuccessCount:                   int64(1),
+				elasticattr.TransactionResult:              "HTTP 2xx",
+				elasticattr.TransactionType:                "request",
+			},
+		},
 		{
 			name: "http_status_1xx",
 			input: func() ptrace.Span {
@@ -2146,7 +2171,18 @@ func TestIsElasticTransaction(t *testing.T) {
 			}(),
 			isTxn: false,
 		},
+		{
+			name: "elastic transaction type is already defined",
+			input: func() ptrace.Span {
+				span := ptrace.NewSpan()
+				span.Attributes().PutStr(elasticattr.ProcessorEvent, "transaction")
+				return span
+			}(),
+			isTxn: true,
+		},
 	} {
-		assert.Equal(t, tc.isTxn, isElasticTransaction(tc.input))
+		t.Run(tc.name, func(t *testing.T) {
+			assert.Equal(t, tc.isTxn, isElasticTransaction(tc.input))
+		})
 	}
 }