test(acc): ignore deployment_not_found in the sweeper (#1058)

Search lag and concurrent leftover sweeps can 404 Shutdown after the suite already passed; treat that as success like resource delete.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: dimuon

ec/acc/deployment_sweep_test.go

@@ -18,15 +18,19 @@
 package acc
 
 import (
+	"errors"
 	"log"
+	"net/http"
 	"strings"
 	"sync"
 	"time"
 
 	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
 
 	"github.com/elastic/cloud-sdk-go/pkg/api"
+	"github.com/elastic/cloud-sdk-go/pkg/api/apierror"
 	"github.com/elastic/cloud-sdk-go/pkg/api/deploymentapi"
+	"github.com/elastic/cloud-sdk-go/pkg/client/deployments"
 	"github.com/elastic/cloud-sdk-go/pkg/models"
 	"github.com/elastic/cloud-sdk-go/pkg/multierror"
 	"github.com/elastic/cloud-sdk-go/pkg/plan"
@@ -105,12 +109,33 @@ func shutdownDeployment(c *api.API, dep string, wg *sync.WaitGroup) error {
 		API: c, DeploymentID: dep,
 	})
 	if err != nil {
+		if alreadyDestroyed(err) {
+			return nil
+		}
 		return err
 	}
 
-	return planutil.Wait(plan.TrackChangeParams{
+	if err := planutil.Wait(plan.TrackChangeParams{
 		API: c, DeploymentID: dep,
-	})
+	}); err != nil && !alreadyDestroyed(err) {
+		return err
+	}
+	return nil
+}
+
+func alreadyDestroyed(err error) bool {
+	if err == nil {
+		return false
+	}
+	var shutdownNF *deployments.ShutdownDeploymentNotFound
+	if errors.As(err, &shutdownNF) {
+		return true
+	}
+	var getNF *deployments.GetDeploymentNotFound
+	if errors.As(err, &getNF) {
+		return true
+	}
+	return apierror.IsRuntimeStatusCode(err, http.StatusNotFound)
 }
 
 func staleDeployment(lastModified time.Time) bool {

ec/acc/deployment_sweep_test_test.go

@@ -18,8 +18,18 @@
 package acc
 
 import (
+	"errors"
+	"net/http"
+	"sync"
 	"testing"
 	"time"
+
+	"github.com/go-openapi/runtime"
+
+	"github.com/elastic/cloud-sdk-go/pkg/api"
+	"github.com/elastic/cloud-sdk-go/pkg/api/apierror"
+	"github.com/elastic/cloud-sdk-go/pkg/api/mock"
+	"github.com/elastic/cloud-sdk-go/pkg/client/deployments"
 )
 
 func Test_staleDeployment(t *testing.T) {
@@ -59,3 +69,74 @@ func Test_staleDeployment(t *testing.T) {
 		})
 	}
 }
+
+func Test_alreadyDestroyed(t *testing.T) {
+	tests := []struct {
+		name string
+		err  error
+		want bool
+	}{
+		{
+			name: "nil is not destroyed",
+		},
+		{
+			name: "shutdown 404 is destroyed",
+			err:  &deployments.ShutdownDeploymentNotFound{},
+			want: true,
+		},
+		{
+			name: "wrapped shutdown 404 is destroyed",
+			err:  apierror.Wrap(&deployments.ShutdownDeploymentNotFound{}),
+			want: true,
+		},
+		{
+			name: "get 404 is destroyed",
+			err:  &deployments.GetDeploymentNotFound{},
+			want: true,
+		},
+		{
+			name: "generic 404 is destroyed",
+			err:  &runtime.APIError{Code: http.StatusNotFound},
+			want: true,
+		},
+		{
+			name: "403 is not destroyed",
+			err:  &runtime.APIError{Code: http.StatusForbidden},
+		},
+		{
+			name: "500 is not destroyed",
+			err:  &runtime.APIError{Code: http.StatusInternalServerError},
+		},
+		{
+			name: "unrelated error is not destroyed",
+			err:  errors.New("boom"),
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if got := alreadyDestroyed(tt.err); got != tt.want {
+				t.Errorf("alreadyDestroyed() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}
+
+func Test_shutdownDeployment_notFound(t *testing.T) {
+	var wg sync.WaitGroup
+	wg.Add(1)
+	err := shutdownDeployment(api.NewMock(mock.SampleNotFoundError()), mock.ValidClusterID, &wg)
+	wg.Wait()
+	if err != nil {
+		t.Errorf("shutdownDeployment() not-found error = %v, want nil", err)
+	}
+}
+
+func Test_shutdownDeployment_serverError(t *testing.T) {
+	var wg sync.WaitGroup
+	wg.Add(1)
+	err := shutdownDeployment(api.NewMock(mock.SampleInternalError()), mock.ValidClusterID, &wg)
+	wg.Wait()
+	if err == nil {
+		t.Fatal("shutdownDeployment() 500 error = nil, want error")
+	}
+}