Merge pull request #26 from elasticias/fix/restore-ngondestroy

1.0.1 — restore ngOnDestroy on the V2 abstracts

Author: aybezz

libs/core/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@elasticias/core",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "peerDependencies": {
     "@angular/common": "^21.0.0",
     "@angular/core": "^21.0.0",

libs/screens/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@elasticias/screens",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "peerDependencies": {
     "@angular/common": "^21.0.0",
     "@angular/core": "^21.0.0",

libs/screens/src/lib/abstract/screen/abstract-detail-screen-v2.component.ts

@@ -2,7 +2,7 @@ import {
     Component,
     DestroyRef,
     Injector,
-    OnInit,
+    OnDestroy, OnInit,
     computed,
     inject,
     signal,
@@ -450,4 +450,12 @@ export abstract class AbstractDetailScreenV2<TItem extends object = any>
         return m ? m[1] : url;
     }
 
+    // AbstractComponent declares `abstract ngOnDestroy()`, so this must exist.
+    // There is genuinely nothing to tear down here; removing it would push the
+    // requirement onto every consumer component.
+    // eslint-disable-next-line @angular-eslint/no-empty-lifecycle-method
+    ngOnDestroy(): void {
+        // The route subscription is auto-unsubscribed via takeUntilDestroyed.
+        // Subclasses can override to release their own resources.
+    }
 }

libs/screens/src/lib/abstract/screen/abstract-report-screen-v2.component.ts

@@ -2,7 +2,7 @@ import {
   Component,
   inject,
   Injector,
-  OnInit,
+  OnDestroy, OnInit,
   Signal,
   signal,
 } from '@angular/core';
@@ -218,4 +218,11 @@ export abstract class AbstractReportScreenV2
     );
   }
 
+    // AbstractComponent declares `abstract ngOnDestroy()`, so this must exist.
+    // There is genuinely nothing to tear down here; removing it would push the
+    // requirement onto every consumer component.
+    // eslint-disable-next-line @angular-eslint/no-empty-lifecycle-method
+    ngOnDestroy(): void {
+    // NSwag observables complete after one emission — nothing to tear down.
+    }
 }

libs/screens/src/lib/abstract/screen/abstract-search-screen-v2.component.ts

@@ -3,7 +3,7 @@ import {
   computed,
   inject,
   Injector,
-  OnInit,
+  OnDestroy, OnInit,
   signal,
 } from '@angular/core';
 import { take } from 'rxjs';
@@ -798,4 +798,12 @@ export abstract class AbstractSearchScreenV2<TItem = any>
     });
   }
 
+    // AbstractComponent declares `abstract ngOnDestroy()`, so this must exist.
+    // There is genuinely nothing to tear down here; removing it would push the
+    // requirement onto every consumer component.
+    // eslint-disable-next-line @angular-eslint/no-empty-lifecycle-method
+    ngOnDestroy(): void {
+    // Subclasses can override to clean up subscriptions; nothing to
+    // tear down on the base since search subscriptions auto-complete.
+    }
 }

libs/screens/src/lib/abstract/screen/abstract-sub-screen-v2.component.ts

@@ -2,7 +2,7 @@ import {
   Component,
   inject,
   Injector,
-  OnInit,
+  OnDestroy, OnInit,
   signal,
 } from '@angular/core';
 import { Permissions } from '@elasticias/types';
@@ -79,4 +79,12 @@ export abstract class AbstractSubScreenV2
     }
   }
 
+    // AbstractComponent declares `abstract ngOnDestroy()`, so this must exist.
+    // There is genuinely nothing to tear down here; removing it would push the
+    // requirement onto every consumer component.
+    // eslint-disable-next-line @angular-eslint/no-empty-lifecycle-method
+    ngOnDestroy(): void {
+    // NSwag observables complete after one emission — nothing to tear
+    // down; subclasses override when they hold live subscriptions.
+    }
 }

libs/types/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@elasticias/types",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "sideEffects": false,
   "repository": {
     "type": "git",

libs/ui/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@elasticias/ui",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "peerDependencies": {
     "@angular/common": "^21.0.0",
     "@angular/core": "^21.0.0",

libs/utils/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@elasticias/utils",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "sideEffects": false,
   "repository": {
     "type": "git",