Skip to content

Commit 17cae97

Browse files
committed
fix acl drop
1 parent df43665 commit 17cae97

1 file changed

Lines changed: 17 additions & 10 deletions

File tree

ccloud/cluster/acl.go

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,14 @@ const (
5252

5353
type KafkaAcl struct {
5454
common.BaseModel
55-
ClusterId string `json:"cluster_id,omitempty"`
56-
ResourceType AclResourceType `json:"resource_type,omitempty"`
57-
ResourceName string `json:"resource_name,omitempty"`
58-
PatternType AclPatternType `json:"pattern_type,omitempty"`
59-
Principal string `json:"principal,omitempty"`
60-
Host string `json:"host,omitempty"`
61-
Operation AclOperationType `json:"operation,omitempty"`
62-
Permission AclPermissionType `json:"permission,omitempty"`
55+
ClusterId string `json:"cluster_id,omitempty" url:"-"`
56+
ResourceType AclResourceType `json:"resource_type,omitempty" url:"resource_type,omitempty"`
57+
ResourceName string `json:"resource_name,omitempty" url:"resource_name,omitempty"`
58+
PatternType AclPatternType `json:"pattern_type,omitempty" url:"pattern_type,omitempty"`
59+
Principal string `json:"principal,omitempty" url:"principal,omitempty"`
60+
Host string `json:"host,omitempty" url:"host,omitempty"`
61+
Operation AclOperationType `json:"operation,omitempty" url:"operation,omitempty"`
62+
Permission AclPermissionType `json:"permission,omitempty" url:"permission,omitempty"`
6363
}
6464

6565
type KafkaAclList struct {
@@ -128,12 +128,19 @@ func (c *ConfluentClusterClient) CreateAcl(acl *KafkaAclCreateReq) error {
128128
}
129129

130130
func (c *ConfluentClusterClient) DeleteAcl(acl *KafkaAcl) error {
131-
res, err := c.doRequest(c.clusterInfo.Acls.Related, acl.Id, "DELETE", nil, nil)
131+
var url string
132+
if acl.Metadata.Self != nil && *acl.Metadata.Self != "" {
133+
url = *acl.Metadata.Self
134+
} else {
135+
url = c.clusterInfo.Acls.Related
136+
}
137+
138+
res, err := c.doRequest(url, "", "DELETE", nil, acl)
132139
if err != nil {
133140
return err
134141
}
135142

136-
if http.StatusNoContent != res.StatusCode {
143+
if http.StatusOK != res.StatusCode && http.StatusNoContent != res.StatusCode {
137144
return fmt.Errorf("failed to delete acl: %s", res.Status)
138145
}
139146

0 commit comments

Comments
 (0)