Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

WebSocket and host-rules Switch #74

Open
@jhleath

Description

@jhleath

I am grateful for you adding support for the --host-rules command line switch; however, the addition of this tag seems to have introduced errors involving the resolution of websockets (ws://) domains.

It appears as though when the host rules switch is active for a domain, websockets requests to that domain never complete (they stay pending forever, without contacting the server). I have concluded that they cannot successfully resolve the name.

I have experimented with Atom-Shell and Chrome proper, and Chrome will correctly handle the websockets request with the host-rules flag, while Atom-Shell will only load the websocket if it doesn't include the host-rules url (i.e. switching to xip.io). Thanks for all your help!

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions