fix: allow publishing to Snap Store to be disabled with snap-specific snap.publish options (#8896)

Author: BrandonXLF

.changeset/three-doors-dream.md

@@ -0,0 +1,5 @@
+---
+"app-builder-lib": patch
+---
+
+fix: allow publishing to Snap Store to be disabled with snap specific publish options

packages/app-builder-lib/src/targets/snap.ts

@@ -259,7 +259,7 @@ export default class SnapTarget extends Target {
       target: this,
       arch,
       packager,
-      publishConfig: publishConfig == null ? { provider: "snapStore" } : publishConfig,
+      publishConfig,
     })
   }
 
@@ -269,16 +269,14 @@ export default class SnapTarget extends Target {
 }
 
 function findSnapPublishConfig(config?: Configuration): SnapStoreOptions | null {
+  const fallback: SnapStoreOptions = { provider: "snapStore" }
+
   if (!config) {
-    return null
+    return fallback
   }
 
   if (config.snap?.publish) {
-    const configCandidate = findSnapPublishConfigInPublishNode(config.snap.publish)
-
-    if (configCandidate) {
-      return configCandidate
-    }
+    return findSnapPublishConfigInPublishNode(config.snap.publish)
   }
 
   if (config.linux?.publish) {
@@ -297,7 +295,7 @@ function findSnapPublishConfig(config?: Configuration): SnapStoreOptions | null
     }
   }
 
-  return null
+  return fallback
 }
 
 function findSnapPublishConfigInPublishNode(configPublishNode: Publish): SnapStoreOptions | null {