Skip to content

Commit b1480d9

Browse files
authored
chore: update dockerfile node images to LTS (#8927)
1 parent 53a8193 commit b1480d9

File tree

4 files changed

+12
-8
lines changed

4 files changed

+12
-8
lines changed

.github/workflows/docker-build.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ jobs:
1313
fail-fast: false
1414
matrix:
1515
nodeVersion: [
16-
22.13.0,
17-
20.18.1,
18-
18.20.5,
16+
22.14.0,
17+
20.18.3,
18+
18.20.7,
1919
16.20.2,
2020
14.21.3
2121
]

.github/workflows/test.yaml

+3-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,9 @@ jobs:
4040
id: changed-files-specific
4141
uses: tj-actions/changed-files@c65cd883420fd2eb864698a825fc4162dd94482c # v44
4242
with:
43-
files: docker/**/*
43+
files: |
44+
docker/**/*
45+
.github/workflows/docker*
4446
4547
- name: Output all changed files
4648
env:

.nvmrc

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
22.13.1
1+
22.14.0

docker/base/Dockerfile

+5-3
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,10 @@ RUN apt-get update -yqq && apt-get -qq dist-upgrade && \
2323

2424
# Resolves the following error due to dependency requirements
2525
# /root/.cache/electron-builder/winCodeSign/winCodeSign-2.6.0/linux/osslsigncode: error while loading shared libraries: libcrypto.so.1.1: cannot open shared object file: No such file or directory
26-
# The missing libcrypto.so.1.1 is part of libssl1.1 but Ubuntu 22.04 upgraded to libssl3, so we must install it manually
27-
ARG LIB_SSL1_VERSION=2.23
26+
# The missing libcrypto.so.1.1 is part of libssl1.1 but Ubuntu 22.04 upgraded to libssl3, so we must install it manually.
27+
# Note: The libssl1.1_1.1.1f-1ubuntuXXXXX.deb asset occasionally is removed from the "pool" when a new version is released.
28+
# To identify the new version number, go to http://security.ubuntu.com/ubuntu/pool/main/o/openssl and search for `libssl1.1_` to update this var accordingly.
29+
ARG LIB_SSL1_VERSION=2.24
2830
RUN wget -q "http://security.ubuntu.com/ubuntu/pool/main/o/openssl/libssl1.1_1.1.1f-1ubuntu${LIB_SSL1_VERSION}_amd64.deb" && \
2931
dpkg -i libssl1.1*.deb && \
3032
rm libssl1.1*.deb
@@ -41,4 +43,4 @@ ENV LANGUAGE=C.UTF-8
4143
ENV LC_ALL=C.UTF-8
4244

4345
ENV DEBUG_COLORS=true
44-
ENV FORCE_COLOR=true
46+
ENV FORCE_COLOR=true

0 commit comments

Comments
 (0)