Skip to content
This repository was archived by the owner on Oct 1, 2020. It is now read-only.
This repository was archived by the owner on Oct 1, 2020. It is now read-only.

Issue with containsControlCharacters #120

Open
@plessbd

Description

@plessbd

After debugging an issue with @desouzas, we were able to find an issue with how files are being detected as binary or not. This function seems to be where the fix needs to be (https://github.com/electron/electron-compile/blob/master/src/file-change-cache.js#L341)

Something small like:

<section class="dashboard-container">
    <dashboard></dashboard>
</section>

gets detected as binary.

However, change it to have a few more spaces

<section class="dashboard-container">
    <dashboard>   </dashboard>
</section>

and it works.

My initial solution in #119 "fixes" the issue but I do not know if that is really the right place for this.
I think an option to disable the detection of binary files, or switching to system based detection like 'file ' (https://github.com/mscdex/mmmagic) might be a better way to detect binary files

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions